http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8190 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #79 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks quite promising! Some questions on details: You (almost) follow common levels like: LOG_EMERG system is unusable LOG_ALERT action must be taken immediately LOG_CRIT critical conditions LOG_ERR error conditions LOG_WARNING warning conditions LOG_NOTICE normal, but significant, condition LOG_INFO informational message LOG_DEBUG debug-level message Why no alert level? Note that LogLite also supports 8 levels (0=unusable, 1=close to unusable) Displaying 1-Unusable is not intuitively clear (in the prefs)? If you include html comments in staff doc-head-open, why not in opac side? Note that you add a test in opac-search (info statement). Is the eval require+die for Koha::Utils::Logger in the third patch really an improvement? I am no packaging expert :) But is adding this module in install_misc/debian.packages enough? Changing status to reflect need for clarification (or adjustment). -- You are receiving this mail because: You are watching all bug changes.