https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #52 from David Cook <dcook@prosentient.com.au> --- Overall, I'm liking where this is going, but there are a few problems. 1. When using Translated Notices, the language selected for the UI is fetched from the patron's "Preferred language for notices", but is inconsistent with what you'd expect from the UI. If you have "Default", you'll see the default regardless of what language you pick in the UI. I propose that we use the UI language for this language for a more consistent look and feel. I'll include that in a patch. 2. If no SVG is provided in a template, it will generate Javascript errors. There should probably always be a SVG, but it's good to handle all scenarios. I'll fix that. 3. When editing the VIRTUALCARD template, it's not clear that "my_barcode" and "my_image" are valid substitutions. I'll fix that. 4. It's not clear that the user needs to go to Tools > Notices and slips, click "New notice", choose "Patrons", and then enter VIRTUALCARD for the Code. I think adding an empty default notice would work well. I'll do that too. 5. It probably wouldn't hurt to reference the Notices and slips from the "OPACVirtualCard" system preference too... I can do that too. -- You are receiving this mail because: You are watching all bug changes.