https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187696&action=edit Bug 40659: Add ability to customize OPACVirtualCard -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187696|0 |1 is obsolete| | --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 187697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187697&action=edit Bug 40659: Add ability to customize OPACVirtualCard To test: 1. Turn on the OPACVirtualCard. 2. Log in to the OPAC as a patron and go look at your Library card ( opac-virtual-card.pl ) 3. APPLY PATCH, updatedatabase, restart_all 4. Go again at your patron's card on the OPAC ( opac-virtual-card.pl ), it should look exactly the same. 5. Go to Tools > Notices > VIRTUALCARD 6. You should see the default content for the library card. 7. Play around with different variables from borrower, like [% borrower.firstname%] and branches, like [% branch.branchcode %] 8. You can also move around the barcode by using the placeholder value [% my_barcode %]. 9. Put the [% my_barcode %] variable anywhere you want in the notice then go to the sys pref "OPACVirtualCardBarcode". 10. Change to different barcode types and relaod the library card page ( opac-virtual-card.pl ). You should notice the barcode type is being honored. 11. Turn on OPACpatronimages AND patronimages, then upload a patron image for your patron. 12. Use the [% my_image %] variable anywhere you want in the notice to place the patron image. 13. Leaving the [% my_image %] variable as is, turn off OPACpatronimages. 14. Reload the OPAC page, no image should display. 15. Delete the VIRTUALCARD notice. 16. Go back to the OPAC page and with the notice deleted you should see the hardcoded content. ie: the page should look exactly the same as it does without this patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187697|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 187895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187895&action=edit Bug 40659: Add ability to customize OPACVirtualCard To test: 1. Turn on the OPACVirtualCard. 2. Log in to the OPAC as a patron and go look at your Library card ( opac-virtual-card.pl ) 3. APPLY PATCH, updatedatabase, restart_all 4. Go again at your patron's card on the OPAC ( opac-virtual-card.pl ), it should look exactly the same. 5. Go to Tools > Notices > VIRTUALCARD 6. You should see the default content for the library card. 7. Play around with different variables from borrower, like [% borrower.firstname%] and branches, like [% branch.branchcode %] 8. You can also move around the barcode by using the placeholder value [% my_barcode %]. 9. Put the [% my_barcode %] variable anywhere you want in the notice then go to the sys pref "OPACVirtualCardBarcode". 10. Change to different barcode types and relaod the library card page ( opac-virtual-card.pl ). You should notice the barcode type is being honored. 11. Turn on OPACpatronimages AND patronimages, then upload a patron image for your patron. 12. Use the [% my_image %] variable anywhere you want in the notice to place the patron image. 13. Leaving the [% my_image %] variable as is, turn off OPACpatronimages. 14. Reload the OPAC page, no image should display. 15. Delete the VIRTUALCARD notice. 16. Go back to the OPAC page and with the notice deleted you should see the hardcoded content. ie: the page should look exactly the same as it does without this patch. Signed-off-by: Marie Martino <martinom43@morainevalley.edu> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|Signed Off |Failed QA --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #0)

Libraries would like more flexibility in the virtual card shown to patrons via the OPAC. Making that virtual card use a notice template would make is highly customizable.

It would also introduce a security vulnerability. I was weighing up whether to use "Failed QA" or "In Discussion", but I figured I'd opt for the former. I think an argument could be made that other Notes & Slips might already have vulnerabilities in them. I haven't reviewed them in depth. However, for new code, I think that we want to do better - in any case. -- On a related note, I think "HTML Customizations" would make more sense than Notes & Slips for this type of change. That might then dovetail in work that Lucas has done for adding templating to show extra MARC fields on the detail page. I can't recall the bug number but I'm sure Lucas will know it. (Of course, with the "HTML Customizations" we're in a bit of a bind where you can't use the WYSIWYG, you have to use the text editor, but that would be the same thing as Notes & Slips anyway.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #8)

I can't recall the bug number but I'm sure Lucas will know it.

It's bug 39860 which I've added as a See Also -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- (In reply to Andrew Fuerste-Henry from comment #10)

(In reply to David Cook from comment #8)

...

However, for new code, I think that we want to do better - in any case.

Can you provide some further detail on what "do better" would mean to you in this situation? What is it about the approach on 39860 that meets your needs better than the work here?

Yeah for sure. I can DM you with more in-depth info, but here I'll say that bug 39860 uses the HTML::Scrubber to allow a safe range of HTML to be added. I'd add it's not about my needs, but rather the security of Koha as a whole. I'm just quite active in the security space. At some point, I hope to either add some additional coding guidelines or a separate "Safe Coding Guidelines" to complement the existing coding guidelines, which should then make things clearer. Thanks for the question! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #11)

(In reply to Andrew Fuerste-Henry from comment #10)

...

(In reply to David Cook from comment #8)

...

However, for new code, I think that we want to do better - in any case.

Can you provide some further detail on what "do better" would mean to you in this situation? What is it about the approach on 39860 that meets your needs better than the work here?

Yeah for sure. I can DM you with more in-depth info, but here I'll say that bug 39860 uses the HTML::Scrubber to allow a safe range of HTML to be added.

I'd add it's not about my needs, but rather the security of Koha as a whole. I'm just quite active in the security space. At some point, I hope to either add some additional coding guidelines or a separate "Safe Coding Guidelines" to complement the existing coding guidelines, which should then make things clearer. Thanks for the question!

Is there any reason those details cannot be shared here fro transparency? If scrubbing the HTML is the only issue then I think this should be left in Notices/Slips where it can be scrubbed. The reason is simple, notices/slips already has a pattern for using placeholder/substitutions which will be need in this bug. I advocate to leave this in notice/slips for that reason. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> ---

What about translatability? I was thinking HTML Customizations would be better as people could add in custom labels for each of their different language interfaces?

Notices are translatable. There is a TranslateNotices system preference to allow them to be. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27334 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #15)

(In reply to Lucas Gass (lukeg) from comment #14)

...

...

What about translatability? I was thinking HTML Customizations would be better as people could add in custom labels for each of their different language interfaces?

Notices are translatable. There is a TranslateNotices system preference to allow them to be.

Ahh right. That's good.

Hmm, conceptually I think it still fits best in HTML Customizations, as it's an HTML Customization. But... I do take your point.

Maybe "Notices and slips" needs a re-brand, and to move out of the "Patrons and circulation" area of "Tools".

After all, we have the OAI_HARVEST_REPORT and Report templates in "Notices and slips" as well. Huh, SFTP_FAILURE and SFTP_SUCCESS as well. That's interesting.

Yeah, all right. I think "Notices and slips" is far enough gone now that it's fine to use it for this purpose.

--

So yeah I think if scrubbing is added then it should be all good.

I did find this already open bug: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36525 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- After speaking with Martin I am convinced that this should go in HTML customization, not notice/slips. Going forward notice/slips should only be used for things that are considered "communications". All other customization belong in additional contents. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27334 --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Lucas Gass (lukeg) from comment #17)

After speaking with Martin I am convinced that this should go in HTML customization, not notice/slips.

Going forward notice/slips should only be used for things that are considered "communications". All other customization belong in additional contents.

I changed my mind after reviewing Bug 27334. It is not close to ready for inclusion. It has pretty glaring security issues and doesn't deal with CodeMirrror vs TinyMCE at all. So this needs to stay in Notice/Slips until there is a viable alternative. At which point we'd already have a bunch of things to migrate out of notice/slips. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27334 [Bug 27334] Add Template Toolkit support to news items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- Yeah it's a really tough one. Some of the things I've found in bug 11583 also make bug 27334 even harder to implement than one might think. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39860 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39860 [Bug 39860] Add a way to allow for additional/custom MARC fields in the record display -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 188358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188358&action=edit Bug 40659: Unit tests for new Scrubber profile -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41086 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Lucas Gass (lukeg) from comment #22)

The profile called 'opac' is extremely limited. I am wondering if we need some sort of hint/tip on the VIRTUALCARD template page telling the user what HTML are allowed. If I was working without knowledge of what tags are allowed it would be frustrating.

That's a really good point. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

I feel it would be cleaner to keep the default template, that makes this available for any language installed without putting extra work on the library and have the customization as an optional extra that replaces the default.

We could think of other solutions, but I am a bit tired of the clean-up we have to do with each update, just because our default is not English and we do provide lots of translations for users in the OPAC. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Right now, all you need to do is switch a system preference to make the feature work. If this is added non-English libraries will have to also add translations. This feels backwards for a template that should be provided translated out of the box. Could we handle it like OpacMaintenance? We have a default in the template, that can be overwritten if needed with your own text/styling. Nothing would change for updating libraries, no disruptions, no extra work. But it would still be customizable if needed. So yes, I suggest removing the default notices and add the standard template back. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #30)

I didn't quite understand the conversation for a little while there, but now I think that I agree with Katrin.

Keeping the status quo would be good. So the idea would be that this feature allows an opt-in way to customize the format? That sounds good to me.

It would probably be useful to provide a sample template somewhere though. Do we put one in the wiki and then link to it from the system preference description? Or maybe we could put a static file or modal somewhere that could be linked to from the system preference description?

Makes sense to me. I believe all we have to do is drop the first patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I have obsoleted the first patch, so this should again be ready for testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187896|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to David Cook from comment #33)

Hmm could we get a rebase? Looks like "Close two divs in sample notice" is causing a problem.

Done! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 189633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189633&action=edit Bug 40659: Change Scrubber profile name to opac_virtual_card -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #39 from Victor Grousset/tuxayo <victor@tuxayo.net> --- QA note: code coverage is good ^^ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188357|0 |1 is obsolete| | --- Comment #41 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 193498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193498&action=edit Bug 40659: Add Scrubber profile and scrub the contents of VIRTUALCARD template Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189633|0 |1 is obsolete| | --- Comment #43 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 193500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193500&action=edit Bug 40659: Change Scrubber profile name to opac_virtual_card Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #45 from Victor Grousset/tuxayo <victor@tuxayo.net> --- side note: data-barcode="..." data-barcode-format="..." end up as expected in the HTML sent by the server but then not in the final DOM as seen with the inspector. That's not due to these patches but just letting y'all know about this oddity. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #47 from Victor Grousset/tuxayo <victor@tuxayo.net> --- The two `alt=""` being empty. Sorry for the unclear phrasing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #48 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #47)

The two `alt=""` being empty.

Sorry for the unclear phrasing.

I'm sorry, Victor. It is still unclear to me where the two empty alts are. Can you clarify for me? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I can't get a clear answer on why this is FQA, so setting back to 'Signed off'. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #45)

side note: data-barcode="..." data-barcode-format="..." end up as expected in the HTML sent by the server but then not in the final DOM as seen with the inspector. That's not due to these patches but just letting y'all know about this oddity.

That sounded odd, but if you look at koha-tmpl/opac-tmpl/bootstrap/js/barcode-generator.js it's because that SVG gets replaced using the ID and data-* attributes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #53 from David Cook <dcook@prosentient.com.au> --- ( You know what would be cool... if in "Notices and slips" you could show a default string as a placeholder for the Content..." ) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- Created attachment 197830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197830&action=edit Bug 40659: Add ability to customize OPACVirtualCard To test: 1. Turn on the OPACVirtualCard. 2. Log in to the OPAC as a patron and go look at your Library card ( opac-virtual-card.pl ) 3. APPLY PATCH, updatedatabase, restart_all 4. Go again at your patron's card on the OPAC ( opac-virtual-card.pl ), it should look exactly the same. 5. Go to Tools > Notices > VIRTUALCARD 6. You should see the default content for the library card. 7. Play around with different variables from borrower, like [% borrower.firstname%] and branches, like [% branch.branchcode %] 8. You can also move around the barcode by using the placeholder value [% my_barcode %]. 9. Put the [% my_barcode %] variable anywhere you want in the notice then go to the sys pref "OPACVirtualCardBarcode". 10. Change to different barcode types and relaod the library card page ( opac-virtual-card.pl ). You should notice the barcode type is being honored. 11. Turn on OPACpatronimages AND patronimages, then upload a patron image for your patron. 12. Use the [% my_image %] variable anywhere you want in the notice to place the patron image. 13. Leaving the [% my_image %] variable as is, turn off OPACpatronimages. 14. Reload the OPAC page, no image should display. 15. Delete the VIRTUALCARD notice. 16. Go back to the OPAC page and with the notice deleted you should see the hardcoded content. ie: the page should look exactly the same as it does without this patch. Signed-off-by: Marie Martino <martinom43@morainevalley.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #56 from David Cook <dcook@prosentient.com.au> --- Created attachment 197832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197832&action=edit Bug 40659: Unit tests for new Scrubber profile Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #58 from David Cook <dcook@prosentient.com.au> --- Created attachment 197834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197834&action=edit Bug 40659: (follow-up) add empty default VIRTUALCARD notice Also include a reference to the notice template from sysprefs Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #60 from David Cook <dcook@prosentient.com.au> --- Created attachment 197836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197836&action=edit Bug 40659: (follow-up) prevent Javascript errors when SVG missing Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |dcook@prosentient.com.au |y.org | --- Comment #62 from David Cook <dcook@prosentient.com.au> --- So I've added a bunch of follow-ups. I've reset it to "Needs Signoff" just because I have quite a few there. While I think they all make sense, it would be good to get some feedback and a test. With all 8 patches, I think I would be willing to do "Passed QA". -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #64 from David Cook <dcook@prosentient.com.au> --- Btw testing the database update should include both "updatedatabase" and "reset_all" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197830|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197832|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #65 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198021&action=edit Bug 40659: Add ability to customize OPACVirtualCard To test: 1. Turn on the OPACVirtualCard. 2. Log in to the OPAC as a patron and go look at your Library card ( opac-virtual-card.pl ) 3. APPLY PATCH, updatedatabase, restart_all 4. Go again at your patron's card on the OPAC ( opac-virtual-card.pl ), it should look exactly the same. 5. Go to Tools > Notices > VIRTUALCARD 6. You should see the default content for the library card. 7. Play around with different variables from borrower, like [% borrower.firstname%] and branches, like [% branch.branchcode %] 8. You can also move around the barcode by using the placeholder value [% my_barcode %]. 9. Put the [% my_barcode %] variable anywhere you want in the notice then go to the sys pref "OPACVirtualCardBarcode". 10. Change to different barcode types and relaod the library card page ( opac-virtual-card.pl ). You should notice the barcode type is being honored. 11. Turn on OPACpatronimages AND patronimages, then upload a patron image for your patron. 12. Use the [% my_image %] variable anywhere you want in the notice to place the patron image. 13. Leaving the [% my_image %] variable as is, turn off OPACpatronimages. 14. Reload the OPAC page, no image should display. 15. Delete the VIRTUALCARD notice. 16. Go back to the OPAC page and with the notice deleted you should see the hardcoded content. ie: the page should look exactly the same as it does without this patch. Signed-off-by: Marie Martino <martinom43@morainevalley.edu> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #67 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198023&action=edit Bug 40659: Unit tests for new Scrubber profile Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #69 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198025&action=edit Bug 40659: (follow-up) add empty default VIRTUALCARD notice Also include a reference to the notice template from sysprefs Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #71 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 198027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198027&action=edit Bug 40659: (follow-up) prevent Javascript errors when SVG missing Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #73 from David Cook <dcook@prosentient.com.au> --- All right I think that should be good to go to Passed QA now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40659 --- Comment #74 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.