https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #69 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Emily Lamancusa from comment #66) Thanks a lot!
Notes from my testing: The majority of it seems to be working as it's supposed to. I ran into a few problems with filtering, though:
1. When using the general "Search" field at the top of the table, the filter often failed with the error message: “Something went wrong when loading the table: 500 Internal Server Error”. In this case, the displayed result set remained unchanged.
This is driving me crazy and I am totally stuck. I have pushed some info to a separate branch bug_33568_wip https://gitlab.com/joubu/Koha/-/commit/c7969388f1a59ad83a2bf82df1d0abf9a8c06...
3. If StaffDetailItemSelection and/or LocalCoverImages is turned off, the alignment of the drop-down filters for the other columns is offset by 1 for each of the two sysprefs that is disabled
Good catch. Fixed in "Fix columns shift when pref are off".
4. The general "Search" bar at the top of the table can only search on AV codes, not display names (is this intentionally left for follow-up since the column-specific filters were fixed by adding drop-downs?)
Yes, that's a limitation of our DT/REST API for now. We need to deal with that but that's not for here.
A couple of other minor things that do not need to be blockers: 1. The "Clear filter" button (next to the general "Search" box at the top of the table) is always disabled
Weird, I am sure I fixed that already. This is not related directly to this table (see the patron search for instance). It should be reported separately.
2. Missing space after the transit date: “In transit from Springfield to Fairfield since 01/25/2024There is an item level hold on this item (priority = 0).”
Done (fixed inline) (In reply to Emily Lamancusa from comment #67)
Feedback from the MCPL staff who looked at the patch:
Inability to sort/filter on status: Front-line staff don't often do this, so it's not a big deal for them. However, acquisitions staff do need to sort/filter by item status on bib records pretty frequently. It would be great if that could be prioritized as a follow-up, even if it's a filter that's more hard-coded than we'd like with a FIXME for later.
It can be done, but it is not trivial. We need to move the logic to perl.
Hiding columns based on whether the first page of results returns data: This doesn't come up often for us (most columns in our system either always have data or very rarely have data), though I see how this could potentially be an issue for other libraries.
As state in a previous comment this is impossible to resolve.
Finally, the reload time when changing the sort/filter was also a concern - if you do multiple sorts/filters on smaller bibs, this can actually increase the overall loading time. The potential follow-up that was discussed earlier, to block the Ajax reload when all items are showing, could definitely help with this, especially on smaller bibs.
To be honest I have no idea how easy/hard it is to implement. But I will be happy to look into it. Don't hesitate to open new bug reports depending on this one, if you have enhancement ideas/requests. -- You are receiving this mail because: You are watching all bug changes.