https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |katrin.fischer@bsz-bw.de, | |kyle@bywatersolutions.com, | |lucas@bywatersolutions.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com, | |oleonard@myacpl.org, | |pedro.amorim@ptfs-europe.co | |m, tomascohen@gmail.com Depends on| |33037, 33497 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've pushed a remote branch as WIP/POC, see https://gitlab.com/joubu/Koha/-/commits/bug_33568 This is really awesome, please have a look! I let the git history to show how I made the changes, step by step. But we could decide to squash later if needed. There is still a lot of work to be done, and I would like to make sure I won't be alone on this one before spending more time on it. I think we really to do this move, it will help people with lot of items attached to a single biblio. I am expecting support with: * early code review (now, it's ready for that) * answer the FIXMEs (in git log and code), can be done inline in gitlab? * help with the remaining work * testing session (it will need to be fully tested before we push it) * keeping in mind that this is on its way and we should not work/push big changes to this script/template (!) It's either a candidate for an early push to 23.11, and a couple of you are with me, or I drop it now (read that I am not going to rebase it if the conflicts are getting tricky). Let me know what you think about it and if you are willing (and how) to help me here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 [Bug 33037] [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 [Bug 33497] Reduce DB calls on staff detail page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26802 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Oh wait... this is for the staff interface? Hmm... it's probably a more concern for us for the OPAC. Telling staff they have to wait a while isn't so bad in comparison to expecting public users to wait. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- On (In reply to David Cook from comment #5)

I was looking at the REST API route /biblios/XXX/items for some discovery but realized it needed more for the "Status" column unless I wanted to re-implement all the logic that we've embedded in the template view layer...

Wonder if there's something to be done with this one and bug 16826 and https://github.com/NatLibFi/koha-plugin-rest-di

That is totally outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #6)

That is totally outside the scope of this bug.

Sure although it'll relate in the future one hopes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33746 Depends on|33746 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33746 [Bug 33746] [omnibus] speed improvement -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151339&action=edit Bug 33568: Preserve item selection across pagination and filtering BTW Do we really need StaffDetailItemSelection? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Michaela Sieber from comment #11)

(In reply to Jonathan Druart from comment #8)

...

Remote branch rebased and a couple of fixes added.

Setting status to Needs Signoff, this is ready to get feedback from testers.

Is there a test plan?

There is a lot to test here, so it's hard to provide an exhaustive list. The idea is to catch bugs I have missed. You need to play with: * datatable features (column visibility, sorting, filtering, show/hide filters) * sysprefs SeparateHoldings and SeparateHoldingsBranch * syspref StaffDetailItemSelection * the different action links (when you select at least one item) * item cover images * item groups (EnableItemGroups) * bundles of items (there is still a FIXME to display the 'Manage bundle' button) * display of other values (recall, status, holds, checkout and renewal count, URIs) * host records * course reserves * analytic (this is still a FIXME) * print label button (SpineLabelShowPrintOnBibDetails) * edit permissions will show the edit buttons * and the other things I have missed in this list? :) In the code there are still FIXMEs: * display library names instead of codes * desk name is not displayed anymore * checkout due date is not correctly formatted * other technical ones for QA.

btw: it is not possible to test the patch in a sandbox http://staff-b33568.sandboxes.ptfs-europe.co.uk/

Error: Template process failed: undef error - C4::Koha::GetAuthorisedValues(): DBI Exception: DBD::mysql::st execute failed: 'koha_b32748.av.category' isn't in GROUP BY at /kohadevbox/koha/Koha/Template/Plugin/AuthorisedValues.pm line 39 at /kohadevbox/koha/C4/Templates.pm line 127

There is something wrong going on but it's not related to this patch. The same of the sandbox was 'b33568' but the error is refering to another instance 'b32748'. To test this change you need to pass the info to the remote branch (there was a patch that has been wrongly attached here): 1. Don't pass a bug number 2. Click "advanced options" 3. "Git remote & branch" should be https://gitlab.com/joubu/Koha and bug_33568 I've just tested and it is working, see https://staff-bug33568.sandboxes.biblibre.eu/cgi-bin/koha/catalogue/detail.p... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33804 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33804 [Bug 33804] Implement as_due_date for $date (js-date-format) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |33817 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 [Bug 33817] Composition of an item bundle can be changed if checked out -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32802 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32802 [Bug 32802] Bundle handling JS should be moved to an asset -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #16)

A few minor things:

Thanks!

- use "fa fa-filter" icon for the "Show filters" link

Commit "Restore filters" adjusted.

- the bulk actions controls (delete, modify) appear if you click a checkbox but not if you click "Select all"

Done in "Fix select/clear all links".

- The checkbox column should not be sortable (an existing bug)

This seems trivial to fix but it's not. The problem is the StaffDetailItemSelection (I've let a comment somewhere, IMO we should remove it, I don't see how it can be useful). As it's an existing bug I would like to deal with this specific bug on a separate bug report. I have opened bug 33860.

I like the choice to hide all the table controls until you click "Show filters" but I am concerned that others might miss the quick filter box. I hope others will comment on that.

There was actually a bug. I've adjusted "Fix DT dom and remove DT info if not needed". The idea is to display the search and pagination only if there is pagination. If all the items are displayed then we show a simple table and browser search ctrl+f can then be used to search on the displayed info. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #18)

* Filters are operating on codes not values, 'FPL' works in 'Home library' but 'Fairview' doesn't

Yes, we should add dropdown lists for itemtype and libraries, like we do on the patron search. But for instance "home library" contains the location as well, that's not that easy :-/

* Location appears in 'Home library' column, but cannot be filtered on code or value

See above.

* Status column not filterable or sortable

Yes, that's no longer possible, and won't be possible, at least in a first iteration. That's not trivial it seems. See the following commit: Bug 33568: Status FIXME We need tests here! See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine).

* Date columns filters only work on SQL formats '2023-06-01' works '06/01/2023' doesn't

I thought I fixed that earlier somewhere else. And I did, on https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145096 But that's not nice. Not considering this high priority for now and considering outside the scope of this bug.

* Click 'show filters', 'hide filters' and repeat X 2 - status column disappears?

See the following commit: Bug 33568: Restore filters FIXME - If we click 'show filters' the 'columns' list does not contain all the columns. We are destroying the DT and the hidden columns are removed from the dom. I think there are 2 possible solutions here: 1. don't destroy but adjust the 'dom' parameter of DT (I didn't manage to make this work correctly, because of the th filters) 2. Move the th definition in the JS init of DT

If you do choose to show all items, a sort action requires reloading the whole table - is it possible to sort/filter on the loaded data?

We could imagine a "freeze" button to remove the AJAX driven behaviour, if all data are loaded. But the behaviour will then be different. It will help to filter/sort on columns on which it's not possible server-side, but I am not sure it's a good idea... Remaining TODOs (in addition of the FIXMEs in the code): * Display the library name of the patron "A patron from LIBRARY NAME" if the patron's data must be hidden. This is related to bug 29523. * Fix bug 33817 * Fix bug 33804 * Add dropdown lists for itemtype, libraries (current library and library) and collection in the column filter row (like we do on the main patron search). However how do we deal with "home library" which contains the location as well? * Search by formatted date (see bug 32505) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 33037, which changed state. Bug 33037 Summary: [Bugs 32555 and 31313 follow-up] Koha does not display difference between enumchron and serialseq in record detail view (OPAC and intranet) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33037 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34211 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34211 [Bug 34211] Add +strings for GET /api/v1/biblios/:biblio_id/items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #19)

* Search by formatted date (see bug 32505)

Done on bug 34226. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Remote branch rebased against master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 33497, which changed state. Bug 33497 Summary: Reduce DB calls on staff detail page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33497 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #24) Thanks a lot for your time on this one! :)

This is working really well in all the tests I could think of. I identified two issues:

1. Item cover images are not showing up.

See commit "Bug 33568: Fix local cover images"

2. The "Select all" control doesn't trigger the display of the batch actions controls, and likewise the "Clear all" control doesn't hide them. Clicking the checkbox works as it should.

I cannot recreate this exact problem but I found a couple of problems with the checkbox selection and the show/hide filters, which have been fixed on "Bug 33568: Fix 'actions' links when filters are shown/hidden", so hopefully yours is fixed as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #25)

See commit "Bug 33568: Fix local cover images" "Bug 33568: Fix 'actions' links when filters are shown/hidden"

These issues have indeed been resolved. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34353 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34353 [Bug 34353] We don't need 'SpineLabelShowPrintOnBibDetails' anymore -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34358 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34358 [Bug 34358] Generalise library selection filter for datatables -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30113 | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34358 | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com | |, lmstrand@gmail.com, | |sophie.meynieux@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15054 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Owen Leonard from comment #30)

I'm getting this error which breaks the loading of the table:

Uncaught TypeError: can't access property "notforloan", row.item_type is undefined

Should be fixed now. Looks like I forgot to include one change in my previous push :-/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 33817, which changed state. Bug 33817 Summary: Composition of an item bundle can be changed if checked out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33817 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34832 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34832 [Bug 34832] [OMNIBUS] API all the Tables! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #34 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #33)

I don't see that. The filters are not there and the link is "Show filters".

Well, I'm not seeing it now either. I do see another issue with the SeparateHoldings preference: If you're looking at a record which has no items that belong to "your" library you'll see a tab for that library saying "No matching records" See http://127.0.0.1:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=9 in the sample data for example (with SeparateHoldingsBranch set to "home library"). Before this patch Koha would display only a single "Holdings" tab showing all items. I'm not sure this is necessarily an unwanted change, but it is a difference. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #36 from Owen Leonard <oleonard@myacpl.org> --- Add my signoff, Jonathan, I think I've tested everything I can think of! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- And rebased on top of bug 34913. Still looks good, no obvious errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Laurence Rault from comment #39)

A bit late, tested on real data with record having more than 2500 items

What was wrong in my test : 1) each time I click show filter or hide filter : some \n \n \n \n \n \n \n \n \n \n display

2) no checkbox in Other holdings tab if there is the first "my library" tab (even as superlibrarian)

3) cannot place a hold, gateway timeout after having chosen the patron from the suggested list

4) with syspref StaffDetailItemSelection disabled : impossible to charge table (error 500)

5) EnableItemGroups : No item group column in Other holdings tab

Can you provide me with the commit id on which you have tested? Using the English interface or French? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #42 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #41)

(In reply to Laurence Rault from comment #39)

...

4) with syspref StaffDetailItemSelection disabled : impossible to charge table (error 500)

I do recreate this one!

Fixed on "Bug 33568: Fix ordering". It should also correct the default ordering. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Laurence Rault from comment #43)

3) cannot place a hold, gateway timeout after having chosen the patron from the suggested list

load of page request.pl : 40 s for 1000 items more than 60 s for 1600 items (and timeout at 60s) The patch does not change items display for this page ?

Nope! Only catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #46 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As soon as I see 29523 move I'll come back to this.. it's right at the top of my pile but I'm struggling to juggle with that one still teetering on the edge. ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Testing here... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #48)

I am sorry, but my testing didn't go as well as I had hoped for :(

Problems: 1) One of the commit messages needs to be fixed

Two were kept for history, I removed them from the branch.

2) When there is no barcode, it appears as 'null' in the column

Fixed in "Bug 33568: Do not display 'null' when no barcode"

3) 'Host records' column should not be available, when EasyAnalytics is turned off.

Fixed in "Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off"

4) Table configuration doesn't appear to be used as expected. I checked: Catalog > holdings_table has only holdings_issues and holdings_renewals hidden by default. But the table keeps appearing with only a minimum number of columns and a lot of them hidden. Unfortunately the hidden column also includes much neded ones like callnumber. Any changes I make don't seem to stick.

The table is hiding empty columns. So if the x items displayed on the page do not have callnumber, then the column will be hidden, even if other pages have items with callnumber. Is that what you are seeing? See commit message "Bug 33568: Hide empty columns". It is what we are doing already on master, but here we don't want to fetch all the items to know if data exist for each each column...

5) SpineLabelShowPrintOnBibDetails: the callnumber print on longer opens in small size modal. This also has the effect, that there is no way to close this window without printing.

Fixed in "Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails"

6) The status column is no longer sortable. It's sortable in 22.11 and works well there. Alos: I can't activate a filter for this column and the normal filter doesn't find the contents of the column. There is no way to find the 'checked out' or 'ordered' items in that list.

See commit message for "Bug 33568: Status" """ See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). """

7) When an item is checked out, there is no longer a link to the patron's account.

Fixed in "Bug 33568: Restore link to patron"

8) hidepatronname doesn't seem to have any effect.

I think this is a bug in js-patron-format.inc, it should be reported separately.

9) Using the single search box on top of the table: "checked" doesn't find the checked out items. In 22.11 that works.

If we want that we need a filter at the top of the page. That should be a separate bug.

10) StaffDetailItemSelection: when disabled, not only the checkboxes are gone, but I can also no longer activate the column specific filters. In 22.11 this is still possible when the select feature is disabled.

Fixed in "Bug 33568: Restore column filters when StaffDetailItemSelection is off"

Notes/Questions: 1) Currently some column only show when there is data for them, like course reserves. this is very helpful in preserving space, but doesn't seem to be the case anymore.

"Preserving space"? See above.

2) Right now we see all items immediately in the table, one the page has loaded. Now we only see the first 20. Libraries might feel this is a too low default setting. It would be great if we could have that configurable in table settings from the start.

It should be very easy to implement. I will do it when this reaches master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, this was a quick return :) There are at least 2 points that give me some headache here in that it changes behavior in a way that will hurt library workflows. (marked DISCUSS). I think they need more time/thought and eyes on them before we are ready here. Librarians: We need you to tell us how you use this table!

...

Problems: 1) One of the commit messages needs to be fixed Two were kept for history, I removed them from the branch.

NOT OK - QA script still complains: * Commit title does not contain 'follow-up' correctly spelt - fd8d8f5ba2 (Bug 33568: (folow-up) Restore filters) * We also got some perltidy complaints on top.

...

2) When there is no barcode, it appears as 'null' in the column Fixed in "Bug 33568: Do not display 'null' when no barcode"

OK - Confirmed fixed.

...

3) 'Host records' column should not be available, when EasyAnalytics is turned off.

Fixed in "Bug 33568: Hide 'Host records' if EasyAnalyticalRecords is off"

OK - Confirmed fixed.

...

4) Table configuration doesn't appear to be used as expected. I checked: Catalog > holdings_table has only holdings_issues and holdings_renewals hidden by default. But the table keeps appearing with only a minimum number of columns and a lot of them hidden. Unfortunately the hidden column also includes much neded ones like callnumber. Any changes I make don't seem to stick.

The table is hiding empty columns. So if the x items displayed on the page do not have callnumber, then the column will be hidden, even if other pages have items with callnumber. Is that what you are seeing? See commit message "Bug 33568: Hide empty columns". It is what we are doing already on master, but here we don't want to fetch all the items to know if data exist for each each column...

DISCUSS - Yes, confirmed - the column visibility is determined by the value savailable on the first visible page. I think this could be problematic, I'd really like to get more opinions, favourably from daily Koha users on this.

...

5) SpineLabelShowPrintOnBibDetails: the callnumber print on longer opens in small size modal. This also has the effect, that there is no way to close this window without printing.

Fixed in "Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails"

NOT OK - I yarn build, restart_all... but the modal is not 'modaling' for me. I still opens full size in a new tab.

...

6) The status column is no longer sortable. It's sortable in 22.11 and works well there. Alos: I can't activate a filter for this column and the normal filter doesn't find the contents of the column. There is no way to find the 'checked out' or 'ordered' items in that list.

See commit message for "Bug 33568: Status" """ See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). """

DISCUSS - So the problem here is that we are storing different numeric values and therefore cannot sort on anything useful... is that it? I believe that could be an issue for a lot of libraries, as it stands now for the before and after: Before * Can sort on status * Can search on status using column filter * Can search on status using the top table search field (overall search) After * Can't do any of that. It's definitely something that we need to get more eyes on again as it could be seen as quite disruptive. Crazy idea: could we collect the status appearing in the data (all of them) and provide a pull down for limiting somehow? A multi select maybe?

...

7) When an item is checked out, there is no longer a link to the patron's account.

Fixed in "Bug 33568: Restore link to patron"

OK - Confirmed fixed.

...

8) hidepatronname doesn't seem to have any effect.

I think this is a bug in js-patron-format.inc, it should be reported separately.

I double-checked in current master: hide: Checked out to 42 : due 04.11.2023 don't hide: Checked out to koha (42) : due 04.11.2023 So it does look like it's related to this patch set somehow. Sorry.

...

9) Using the single search box on top of the table: "checked" doesn't find the checked out items. In 22.11 that works.

If we want that we need a filter at the top of the page. That should be a separate bug.

I was talking about the filter on top of the table - are we talking about the same thing?

...

10) StaffDetailItemSelection: when disabled, not only the checkboxes are gone, but I can also no longer activate the column specific filters. In 22.11 this is still possible when the select feature is disabled.

Fixed in "Bug 33568: Restore column filters when StaffDetailItemSelection is off"

OK - Confirmed fixed. 11) NEW: Column filters for item type and current library don't show as a pull down. Holding branch does.

...

Notes/Questions: 1) Currently some column only show when there is data for them, like course reserves. this is very helpful in preserving space, but doesn't seem to be the case anymore.

"Preserving space"? See above.

Yep, understood now. Hesitating.

...

2) Right now we see all items immediately in the table, one the page has loaded. Now we only see the first 20. Libraries might feel this is a too low default setting. It would be great if we could have that configurable in table settings from the start.

It should be very easy to implement. I will do it when this reaches master.

I filed it separately as: Bug 35191 - Make entries per page configurable for items table on staff detail page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem I see is, that we have lot of libraries that won't need this change, they have only a few items per record and everything works fine. They might see some of this a a regression, also it seems we still have some things to iron out and we are running out of time. Then there is the big libraries that would be happy to have this as they experience problems with records with many items - they might be happy to accept the changes. I think rushing a decision between 3 people (you, me, RM) here would not be good right now. We should aim to have this on the Road map early next release and maybe we can get some more reactions (I am thinking of ways to reach out) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd be keen to see this pushed pretty much immediately after release giving us a whole cycle to really work through the issues presented and making for a trivial backport for those libraries very keen. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Moving forward please? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we should put it on the road map if it isn't yet and I'd really like to give libraries a chance to get involved. With the holidays coming up, I mid-January might be a good time window to work on this. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #59 from Nick Clemens <nick@bywatersolutions.com> --- I agree with Joubu - this will become unwieldy to improve unless pushed. It will make some changes to the current display, and we can handle those individually on smaller bugs once we have this base. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #61 from Andrii Nugged <nugged@gmail.com> --- We can take this for our libraries in Finland and maybe for Ukraine in our custom build for testing, until this "more or less complete". They asking for this feature. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Andrii Nugged from comment #61)

We can take this for our libraries in Finland and maybe for Ukraine in our custom build for testing, until this "more or less complete". They asking for this feature.

Is it being tested? Any feedback? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33195 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33195 [Bug 33195] Reindent the bibliographic details page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Emily Lamancusa from comment #64)

I'll take a look at this early next week. I think I can get others from MCPL to test too - we have bibs with hundreds of items, and would definitely like to see performance improvements on that move forward!

Thanks Emily, that would be awesome. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #67 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Feedback from the MCPL staff who looked at the patch: Inability to sort/filter on status: Front-line staff don't often do this, so it's not a big deal for them. However, acquisitions staff do need to sort/filter by item status on bib records pretty frequently. It would be great if that could be prioritized as a follow-up, even if it's a filter that's more hard-coded than we'd like with a FIXME for later. Hiding columns based on whether the first page of results returns data: This doesn't come up often for us (most columns in our system either always have data or very rarely have data), though I see how this could potentially be an issue for other libraries. Finally, the reload time when changing the sort/filter was also a concern - if you do multiple sorts/filters on smaller bibs, this can actually increase the overall loading time. The potential follow-up that was discussed earlier, to block the Ajax reload when all items are showing, could definitely help with this, especially on smaller bibs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Signed Off --- Comment #70 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #69)

(In reply to Emily Lamancusa from comment #66)

Thanks a lot!

...

Notes from my testing: The majority of it seems to be working as it's supposed to. I ran into a few problems with filtering, though:

1. When using the general "Search" field at the top of the table, the filter often failed with the error message: “Something went wrong when loading the table: 500 Internal Server Error”. In this case, the displayed result set remained unchanged.

This is driving me crazy and I am totally stuck. I have pushed some info to a separate branch bug_33568_wip https://gitlab.com/joubu/Koha/-/commit/ c7969388f1a59ad83a2bf82df1d0abf9a8c065b3

"Fixed" on "Bug 33568: Remove LPAD ordering" -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/-/commits/bug_33568 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Bug 33568 depends on bug 34913, which changed state. Bug 34913 Summary: Upgrade DataTables from 1.10.18 to 1.13.6 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34913 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #72 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #49)

...

4) Table configuration doesn't appear to be used as expected. I checked: Catalog > holdings_table has only holdings_issues and holdings_renewals hidden by default. But the table keeps appearing with only a minimum number of columns and a lot of them hidden. Unfortunately the hidden column also includes much neded ones like callnumber. Any changes I make don't seem to stick.

The table is hiding empty columns. So if the x items displayed on the page do not have callnumber, then the column will be hidden, even if other pages have items with callnumber. Is that what you are seeing? See commit message "Bug 33568: Hide empty columns".

It is what we are doing already on master, but here we don't want to fetch all the items to know if data exist for each each column...

I think we should remove the feature of hiding empty columns entirely. It is a really small 'feature' that causes less harm than the benefits it brings. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #74 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #73)

I see what you mean, but we need to test this maybe - it can "blow up" the table quite a bit. thinking of the notes fields (materials, internal note, OPAC note, enumchron...) that you would want to see when set and not hide via column settings by default.

For libraries with only a few items per record, this could be seen as quite a regression. Would it be possible to only "activate" this behavior if we have a paged items table? Like check the count of items and then behave differently? (just brainstorming, we need to decide on something, I am aware)

I've been thinking about it, and maybe what we need is some sort of hint/tooltip that displays some of that info? So they can safely hide the columns entirely, but still know there's some extra info. Trying to see from another angle to unlock this. I get it. I understand your concern, but it is too tiny compared to the benefits having this in master will bring. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #76 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #75)

I think it's important we keep both use cases in mind. Big libraries with many items that could immensely profit from this, but also the huge number of small libraries where this might create problems.

My proposal is the way I keep both cases in mind :-D I just think some sacrifices will need to be made at the beginning and maybe we can later re-add things as people express their opinions. That said,

What about the suggestion I made about making the behavior dependent on number of items? I believe that could give us best of both worlds.

* Show all columns if the display is paginated, like you suggested. * Keep the behavior Jonathan implemented for records with unpaginated display (number of items <= number of items per page).

this could work. It would be a matter of hearing from Jonathan as he's invested a lot of time and needs to tell us if he can adjust that needed bit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Besides the conversation about columns visibility, I found this odd behavior: I picked `CGI programming with Perl` for my tests, and added some extra items: ``` perl -mt::lib::TestBuilder -e 'my $t = t::lib::TestBuilder->new; foreach my $i (1..100) { $t->build_sample_item({ biblionumber => 11 }); }' ``` And even though TestBuilder generated 100 random libraries for those items (checked on the DB) all the 'Home library' and 'Holding library' columns are displaying empty! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #80 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #79)

I'm reverting the FQA as I cannot reproduce anymore. Marked my comment as important as Jonathan might have some insight on what might have happened (I feel some caching got in the middle).

Right, t::lib::TestBuilder totally skips Koha::<Class>->store, and thus cache invalidation doesn't take place. Sorry for the noise! This is PQA in my opinion. Will wait until we hear from Jonathan about the columns display solution. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #81)

There are really too many columns to display them all. I think the solution proposed by this patch is a good compromise and we need to hear from end users to adjust the behaviour if needed.

I am OK with that. IIRC it would mean that not much changes for libraries with few items, which is good for now. What do you think about adding a little tool tip to the relevant section on the columns configuration page? Maybe something like: "Please note that if a field is not used on the first page of items int he holdings table, it will be automatically hidden from display and can be made visible on demand. You can still use the column configuration to permanently hide columns from the holdings table." Trying to minimize the surprise and manage expectations :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Cool. Tomas, ready to pass QA or do we miss something else? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #85 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164308&action=edit Bug 33568: Remove debug_display This is useless, we could move it to its own bug report if needed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #87 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164310&action=edit Bug 33568: Display string version of coded values + format dates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #89 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164312&action=edit Bug 33568: Display item type image Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #91 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164314&action=edit Bug 33568: Cover images Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #93 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164316&action=edit Bug 33568: Temporary set searchable to false where no data Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #95 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164318&action=edit Bug 33568: Add columns visibility Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #97 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164320&action=edit Bug 33568: Fix search on item type Is this good? Cannot we return incorrect results here? Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #99 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164322&action=edit Bug 33568: Item groups FIXME - we need tests, but I'd like to make sure there is no an easier way to do this many to many things. Tomas? Filter on the "Item group" column needs to be tested! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #101 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164324&action=edit Bug 33568: Status FIXME We need tests here! See the FIXME in the code, we are losing the ability to search on the status, but this is really impossible to implement if we are not storing the status (DB or search engine). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #103 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164326&action=edit Bug 33568: URI Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #105 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164328&action=edit Bug 33568: public notes Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #107 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164330&action=edit Bug 33568: Print label button Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #109 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164332&action=edit Bug 33568: Separate holdings This needs to be well tested! Sysprefs SeparateHoldings and SeparateHoldingsBranch As well as the "Lost items in staff interface" that can be defined at patron's category level. This patch is simply restoring the previous behaviour but I think we could do better. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #111 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164334&action=edit Bug 33568: Escape all the things Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #113 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164336&action=edit Bug 33568: Fix action links display Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #115 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164338&action=edit Bug 33568: Use as_due_date to display due dates Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #117 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164340&action=edit Bug 33568: Bug 33568: Display library names instead of codes for first hold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #119 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164342&action=edit Bug 33568: Display the desk name for the first hold Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #121 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164344&action=edit Bug 33568: Restore host records Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #123 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164346&action=edit Bug 33568: Move code to a dedicated include file Not very nice but at least the code is isolated in a separate file and reduce the size of detail.tt We could also move the code related to the item bundle that is included inside this same table. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #125 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164348&action=edit Bug 33568: Fix select/clear all links Follow-up for "Bug 33568: Preserve item selection across pagination and filtering" FIXME We should deal with the items selection in a better way, but I would not consider it blocker, that can be done later. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #127 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164350&action=edit Bug 33568: Prevent 500 when filtering by item type (FIXMEs) See FIXMEs added by this patch Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #129 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164352&action=edit Bug 33568: Fix local cover images We need to reprocess the images when the table is refreshed, to do that we teach verify_cover_images to go through a given container instead of the whole document, and pass a call back function to build_items_table that will be called when DataTables will have redrawn the table (drawCallback). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #131 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164354&action=edit Bug 33568: (bug 34226 follow-up) Add type=date to date columns Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #133 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164356&action=edit Bug 33568: Do not embed item types Performance for 1000 items from 22 to 19s It replaces the input in the column header filter with a dropdown list. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #135 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164359&action=edit Bug 33568: Add some missing StaffDetailItemSelection conditionals Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #137 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164361&action=edit Bug 33568: JSON-encode html output of build_table This prevents error with quotes coming from translations Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #139 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164363&action=edit Bug 33568: Do not display 'null' when no barcode Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #141 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164365&action=edit Bug 33568: Fix popup behaviour for SpineLabelShowPrintOnBibDetails Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #143 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164367&action=edit Bug 33568: Restore column filters when StaffDetailItemSelection is off Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #145 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164369&action=edit Bug 33568: (follow-up) Fix ordering - WIP This is not working. We are still getting the error Unable to programatically derive a required group_by from the supplied order_by criteria. To proceed either add an explicit group_by, or simplify your order_by to only include plain columns (supplied order_by: 'lpad_copynumber'). To recreate the problem you can go to detail.pl and search for something Without search the query is working. The problem appears when the query has WHERE parameters added and "GROUP BY" is added. DBIC is adding to the GROUP BY what is added to the select, but does not handle this situation (not a plain column). You can play with: 1. Remove from Koha::Items->search_ordered 475 'lpad_copynumber', => all good 2. Remove the following block from /usr/share/perl5/DBIx/Class/Storage/DBIHacks.pm 584 # only consider real columns (for functions the user got to do an explicit group_by) 585 my $chunk_ci; 586 if ( 587 @{$order_by[$o_idx]} != 1 588 or 589 # only declare an unknown *plain* identifier as "leftover" if we are called with 590 # aliastypes to examine. If there are none - we are still in _resolve_attrs, and 591 # can just assume the user knows what they want 592 ( ! ( $chunk_ci = $colinfos->{$order_by[$o_idx][0]} ) and $attrs->{_aliastypes} ) 593 ) { 594 push @$leftovers, $order_by[$o_idx][0]; 595 } => all good I don't know if we are doing something wrong here, but I have no idea how we can build the group_by explicitely. Is there another way to do this? Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #147 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164371&action=edit Bug 33568: Remove LPAD ordering This is coming from bug 3521 it seems. And we are going to deal with this later if people complains. kidclamp> the performance issue for sites with many copies is bigger than sorting issues imho kidclamp> drop the LPAD I say :-) Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #149 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164373&action=edit Bug 33568: POD fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #151 from Jonathan Druart <jonathan.druart@gmail.com> --- Thanks Tomas! I have added Laurence and Emily as well as yours. Laurence and Emily have done extended testing and I think they deserve their signed-off-by lines on this one. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36535 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36535 [Bug 36535] 33568 introduced too many changes in modules without tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 --- Comment #155 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33568 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164308|0 |1 is obsolete| | Attachment #164309|0 |1 is obsolete| | Attachment #164310|0 |1 is obsolete| | Attachment #164311|0 |1 is obsolete| | Attachment #164312|0 |1 is obsolete| | Attachment #164313|0 |1 is obsolete| | Attachment #164314|0 |1 is obsolete| | Attachment #164315|0 |1 is obsolete| | Attachment #164316|0 |1 is obsolete| | Attachment #164317|0 |1 is obsolete| | Attachment #164318|0 |1 is obsolete| | Attachment #164319|0 |1 is obsolete| | Attachment #164320|0 |1 is obsolete| | Attachment #164321|0 |1 is obsolete| | Attachment #164322|0 |1 is obsolete| | Attachment #164323|0 |1 is obsolete| | Attachment #164324|0 |1 is obsolete| | Attachment #164325|0 |1 is obsolete| | Attachment #164326|0 |1 is obsolete| | Attachment #164327|0 |1 is obsolete| | Attachment #164328|0 |1 is obsolete| | Attachment #164329|0 |1 is obsolete| | Attachment #164330|0 |1 is obsolete| | Attachment #164331|0 |1 is obsolete| | Attachment #164332|0 |1 is obsolete| | Attachment #164333|0 |1 is obsolete| | Attachment #164334|0 |1 is obsolete| | Attachment #164335|0 |1 is obsolete| | Attachment #164336|0 |1 is obsolete| | Attachment #164337|0 |1 is obsolete| | Attachment #164338|0 |1 is obsolete| | Attachment #164339|0 |1 is obsolete| | Attachment #164340|0 |1 is obsolete| | Attachment #164341|0 |1 is obsolete| | Attachment #164342|0 |1 is obsolete| | Attachment #164343|0 |1 is obsolete| | Attachment #164344|0 |1 is obsolete| | Attachment #164345|0 |1 is obsolete| | Attachment #164346|0 |1 is obsolete| | Attachment #164347|0 |1 is obsolete| | Attachment #164348|0 |1 is obsolete| | Attachment #164349|0 |1 is obsolete| | Attachment #164350|0 |1 is obsolete| | Attachment #164351|0 |1 is obsolete| | Attachment #164352|0 |1 is obsolete| | Attachment #164353|0 |1 is obsolete| | Attachment #164354|0 |1 is obsolete| | Attachment #164355|0 |1 is obsolete| | Attachment #164356|0 |1 is obsolete| | Attachment #164358|0 |1 is obsolete| | Attachment #164359|0 |1 is obsolete| | Attachment #164360|0 |1 is obsolete| | Attachment #164361|0 |1 is obsolete| | Attachment #164362|0 |1 is obsolete| | Attachment #164363|0 |1 is obsolete| | Attachment #164364|0 |1 is obsolete| | Attachment #164365|0 |1 is obsolete| | Attachment #164366|0 |1 is obsolete| | Attachment #164367|0 |1 is obsolete| | Attachment #164368|0 |1 is obsolete| | Attachment #164369|0 |1 is obsolete| | Attachment #164370|0 |1 is obsolete| | Attachment #164371|0 |1 is obsolete| | Attachment #164372|0 |1 is obsolete| | Attachment #164373|0 |1 is obsolete| | Attachment #164374|0 |1 is obsolete| | Attachment #164472|0 |1 is obsolete| | --- Comment #156 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164480&action=edit Bug 33568: Fix translatability issues -- You are receiving this mail because: You are watching all bug changes.