https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa (emlam) from comment #4)
This generally looks good!
Just one question - why was:
error => eval { $_->{error} } || "$_"
changed to:
error => eval { $_->message } || eval { $_->error } || "$_"
Also, not a blocker, but can the barcode include a link to the item record since the itemnumber is being passed anyway? (I'm happy to add this when I QA if you're okay with that)
It is my attempt to get the more human readable message "intransit_cannot_withdraw" instead of the full exception "Exception 'Koha::Exceptions::Item::Transfer::OnLoan' thrown 'onloan_cannot_withdraw'" But when I think about it I don't think we need all the fallbacks message -> error => $_ -- You are receiving this mail because: You are watching all bug changes.