[Bug 41884] New: Job report for batch item modifications that fail due to PreventWithdrawingItemsStatus has no details on failed items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Bug ID: 41884 Summary: Job report for batch item modifications that fail due to PreventWithdrawingItemsStatus has no details on failed items Initiative type: --- Sponsorship --- status: Product: Koha Version: 25.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org If PreventWithdrawingItemsStatus is set to prevent withdrawal of in transit and/or checked out items, and some items in a batch item modification fail because they're either in transit or checked out, the job details screen does not provide any information about which items failed or the reason for the failure. At a minimum, it should show the item number or barcode so that libraries know which items need attention. When individual items can't be withdrawn due to the system preference, the error message notes the reason, so ideally that would be included in the job report too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version|25.11 |Main -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #1 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193367&action=edit Bug 41884: Add better reporting when item fails to modify via batch mod To test: 1. Search for the system preference, PreventWithDrawingItemsStatus 2. Select both in transit and checked out, then save 3. Find an item and put it in transit. 4. Try to batch modify the item, making it withdrawen. 5. View the details of job, you should see 1 item could not be modified. 6. APPLY PATCH, restart_all 7. Try the steps again, this time when you get to the details of the job you should see more information on the item that failed: 1 item could not be modified. 39999000001457 : Item is in transit 8. Repeat this steps with a a checkout out item. 9. Also try with multiple items that will fail, ensure the display looks good. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 193596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193596&action=edit Bug 41884: Add better reporting when item fails to modify via batch mod To test: 1. Search for the system preference, PreventWithDrawingItemsStatus 2. Select both in transit and checked out, then save 3. Find an item and put it in transit. 4. Try to batch modify the item, making it withdrawen. 5. View the details of job, you should see 1 item could not be modified. 6. APPLY PATCH, restart_all 7. Try the steps again, this time when you get to the details of the job you should see more information on the item that failed: 1 item could not be modified. 39999000001457 : Item is in transit 8. Repeat this steps with a a checkout out item. 9. Also try with multiple items that will fail, ensure the display looks good. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I think it would be better not to have a space before the colon, but I couldn't work out how to do that: - instead of 39999000005097 : Item is in transit - show as 39999000005097: Item is in transit I wasn't quite sure what was meant in steps 8 and 9 - I did a batch modification to make the items withdrawn, where multiple items were in transit and one item was already checked out. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- This generally looks good! Just one question - why was: error => eval { $_->{error} } || "$_" changed to: error => eval { $_->message } || eval { $_->error } || "$_" Also, not a blocker, but can the barcode include a link to the item record since the itemnumber is being passed anyway? (I'm happy to add this when I QA if you're okay with that) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #5 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Oop, BatchUpdate.t is failing too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Emily Lamancusa (emlam) from comment #4)
This generally looks good!
Just one question - why was:
error => eval { $_->{error} } || "$_"
changed to:
error => eval { $_->message } || eval { $_->error } || "$_"
Also, not a blocker, but can the barcode include a link to the item record since the itemnumber is being passed anyway? (I'm happy to add this when I QA if you're okay with that)
It is my attempt to get the more human readable message "intransit_cannot_withdraw" instead of the full exception "Exception 'Koha::Exceptions::Item::Transfer::OnLoan' thrown 'onloan_cannot_withdraw'" But when I think about it I don't think we need all the fallbacks message -> error => $_ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193596|0 |1 is obsolete| | --- Comment #7 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193860&action=edit Bug 41884: Add better reporting when item fails to modify via batch mod To test: 1. Search for the system preference, PreventWithDrawingItemsStatus 2. Select both in transit and checked out, then save 3. Find an item and put it in transit. 4. Try to batch modify the item, making it withdrawen. 5. View the details of job, you should see 1 item could not be modified. 6. APPLY PATCH, restart_all 7. Try the steps again, this time when you get to the details of the job you should see more information on the item that failed: 1 item could not be modified. 39999000001457 : Item is in transit 8. Repeat this steps with a a checkout out item. 9. Also try with multiple items that will fail, ensure the display looks good. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193860|0 |1 is obsolete| | --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193861&action=edit Bug 41884: Add better reporting when item fails to modify via batch mod To test: 1. Search for the system preference, PreventWithDrawingItemsStatus 2. Select both in transit and checked out, then save 3. Find an item and put it in transit. 4. Try to batch modify the item, making it withdrawen. 5. View the details of job, you should see 1 item could not be modified. 6. APPLY PATCH, restart_all 7. Try the steps again, this time when you get to the details of the job you should see more information on the item that failed: 1 item could not be modified. 39999000001457 : Item is in transit 8. Repeat this steps with a a checkout out item. 9. Also try with multiple items that will fail, ensure the display looks good. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193862&action=edit Bug 41884: Make barcode a link to the item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 193863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193863&action=edit Bug 41884: Adjust tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193863|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 197098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197098&action=edit Bug 41884: Add better reporting when item fails to modify via batch mod To test: 1. Search for the system preference, PreventWithDrawingItemsStatus 2. Select both in transit and checked out, then save 3. Find an item and put it in transit. 4. Try to batch modify the item, making it withdrawen. 5. View the details of job, you should see 1 item could not be modified. 6. APPLY PATCH, restart_all 7. Try the steps again, this time when you get to the details of the job you should see more information on the item that failed: 1 item could not be modified. 39999000001457 : Item is in transit 8. Repeat this steps with a a checkout out item. 9. Also try with multiple items that will fail, ensure the display looks good. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #12 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 197099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197099&action=edit Bug 41884: Make barcode a link to the item Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #13 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 197100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197100&action=edit Bug 41884: Adjust tests Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #14 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Thanks for the updates, Lucas! (Also sorry I missed that you did them a month ago!) All looks good now - setting to PQA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #15 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41884 --- Comment #16 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org