https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you Lisette and Jason for your time and feedback here.
Maybe Supplying Agency Request ID Addressed in: https://github.com/openfifth/koha/commit/1b8a6160e82da4c914bb771b913ddb81a07...
I like "Requesting agency has requested" I think it's more clear Addressed in: https://github.com/openfifth/koha/commit/81a4b2b8430e3cc261c5bd73d28b877bb7b...
Some tests failed: [FAIL] t/db_dependent/Koha/ILL/ISO18626/Request.t FAIL file_permissions File must have the exec flag [FAIL] t/db_dependent/api/v1/iso18626/request.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 149) forbidden pattern: Use https:// instead of http:// for URLs (line 344) Addressed in: https://github.com/openfifth/koha/commit/cfa17d601f2aaacd3fafa695548e5fd77ed...
Otherwise it looks great. -Cancellation is still missing but we had discussed that's on your to do. -Cannot delete a requesting agency with iso requests --I think that should wait until 41178 is pushed so we can build on top of it/use or extend the vue components being introduced there. -Capitalization on some UI components --Should Widget Picker on /cgi-bin/koha/ill/home be capitalized like that? --/cgi-bin/koha/ill/iso18626_requests should Agency in the table headers be capitalized? --On the details of the request, should 'ISO18626 Messages' have messages capitalized? Not followed up with these. Please let me know if any are blockers. Cancellation works but it's not yet circulation authoritative i.e. cancelling a hold does not cancel the supply ILL request. This is tricky as the requesting agency must first request cancellation and only then the supplying agency cancels. That use case is covered.
I also agree with Lisette that tabbing the table out by status with a count on each tab would be beneficial. Addressed by: https://github.com/openfifth/koha/commit/453e7a974ba706ae105529d52c6a2def874... This does not add tabs, but adds a filter to the status column which allows the same effect e.g. filter by status. It does not behave like a facet for now but that can be followed-up after.
It would also be nice if the statuses were more human-readable (i.e. RequestReceived = Pending, LoanCompleted = Complete, etc.). I agree. For now I've gone with the ISO18626 status names exactly for transparency but we can revisit this in future work.
This is looking good to me. I'm happy to sign off if the lack of visible bib info I mentioned in comment 15 can be addressed in future work. Agreed. Thank you. Opened bug 42428.
-- You are receiving this mail because: You are watching all bug changes.