https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Crazy to see huge stuff like that pushed in a month, right before the release... 155 files changed, 10184 insertions(+), 241 deletions(-) The number of tests is terribly low regarding the diff. There are new concepts introduced without discussion (Koha::Controller, Vue's Patron autocomplete), that should have been on separate bug reports. Some comments in the code should have been resolved before push. * //Write handling of supply ILL params here ? before submit? * TODOs * This one seems blocker: + get: () => { + ILLModule: 1; + }, // TODO: Fetch from API Commented JS code in request.tt Strings in .vue files not translatable (not using $__()) Vue's v-html is being removed on another bug, because of potential XSS The new occurrence added to components/LinkWrapper.vue should be investigated. Syspref's getAll should have used the new endpoint. What is actually done on bug 41995 (trivial patch waiting for QA for 2 months now). Several tests on Jenkins are failing, adding additional_work_needed. -- You are receiving this mail because: You are watching all bug changes.