https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thank you for taking the time to look at this Tomás! I've noticed a lot of inconsistencies creeping in lately, but haven't got around to creating a bug to fix them. I'll go through and review the changes properly tomorrow (for me). Sentences in parentheses ------------------------ One thing I noticed after a quick review of the changes is that for complete standalone sentences in parentheses, the full stop should be inside the ending bracket, not outside. For example: - This change is correct - it should have a full stop, and it should be at the end of the sentence after the bracket: Automatic generation also has to be enabled for each credit type (<a href="/cgi-bin/koha/admin/credit_types.pl">Configure credit types</a>). - This change is not correct - it should have a full stop, but as it is a complete sentence the full stop should go before the closing bracket .): (This is the default From: address for emails unless there is one for the particular library, and is referred to when an internal error occurs). Reference: https://www.grammarly.com/blog/punctuation-capitalization/parentheses-and-br... Enable/Don't enable vs Yes/No ----------------------------- I agree with this change for consistency - it should be one or the other. Katrin and Caroline made a lot of changes a few years ago to standardise on Enable/Don't enable, or maybe it was Show/Don't show (I can't find the bug). (The other pet peeve I have is when the system preference name includes enable or use, for example UseCashRegisters and EnablePointOfSale. I think the system preference name should describe the feature, and turning it on or off should an option for the system preference.) Other things ------------ I think we should add any of these things that are inconsistent to the terminology list https://wiki.koha-community.org/wiki/Terminology - we added show/don't show vs display/don't display a while ago. We should also probably cover some of the "rules" about naming system preferences (after agreement) in https://wiki.koha-community.org/wiki/System_Preferences The documentation team has adopted the Google developer documentation style guide as our base style guide - once I've created an editable version of this for the documentation team, we can add our exceptions and specific rules to that as well. (English grammar is hard, even for native speakers!) -- You are receiving this mail because: You are watching all bug changes.