https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com CC| |tomascohen@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Thank you for taking the time to look at this Tomás! I've noticed a lot of inconsistencies creeping in lately, but haven't got around to creating a bug to fix them. I'll go through and review the changes properly tomorrow (for me). Sentences in parentheses ------------------------ One thing I noticed after a quick review of the changes is that for complete standalone sentences in parentheses, the full stop should be inside the ending bracket, not outside. For example: - This change is correct - it should have a full stop, and it should be at the end of the sentence after the bracket: Automatic generation also has to be enabled for each credit type (<a href="/cgi-bin/koha/admin/credit_types.pl">Configure credit types</a>). - This change is not correct - it should have a full stop, but as it is a complete sentence the full stop should go before the closing bracket .): (This is the default From: address for emails unless there is one for the particular library, and is referred to when an internal error occurs). Reference: https://www.grammarly.com/blog/punctuation-capitalization/parentheses-and-br... Enable/Don't enable vs Yes/No ----------------------------- I agree with this change for consistency - it should be one or the other. Katrin and Caroline made a lot of changes a few years ago to standardise on Enable/Don't enable, or maybe it was Show/Don't show (I can't find the bug). (The other pet peeve I have is when the system preference name includes enable or use, for example UseCashRegisters and EnablePointOfSale. I think the system preference name should describe the feature, and turning it on or off should an option for the system preference.) Other things ------------ I think we should add any of these things that are inconsistent to the terminology list https://wiki.koha-community.org/wiki/Terminology - we added show/don't show vs display/don't display a while ago. We should also probably cover some of the "rules" about naming system preferences (after agreement) in https://wiki.koha-community.org/wiki/System_Preferences The documentation team has adopted the Google developer documentation style guide as our base style guide - once I've created an editable version of this for the documentation team, we can add our exceptions and specific rules to that as well. (English grammar is hard, even for native speakers!) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Thanks for the feedback! (In reply to David Nind from comment #3)

Thank you for taking the time to look at this Tomás!

I've noticed a lot of inconsistencies creeping in lately, but haven't got around to creating a bug to fix them.

I'll go through and review the changes properly tomorrow (for me).

Sentences in parentheses ------------------------

One thing I noticed after a quick review of the changes is that for complete standalone sentences in parentheses, the full stop should be inside the ending bracket, not outside.

I really didn't understand the need for parenthesis there. But I agree: if the parenthesis is kept, the full stop should be inside of the parenthesis.

(English grammar is hard, even for native speakers!)

I agree with all the things you said, including the above comment. I will amend the patch with your suggestion to move full stops inside the parenthesis, and leave the next ones to more expert eyes for now. I just focused on what bugged me on translating. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175965|0 |1 is obsolete| | --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 175966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175966&action=edit Bug 38785: Punctuation inconsistencies in preferences descriptions This patch fixes some inconsistencies I noticed during translation. Most of them are punctuation related. To test: 1. Apply this patch 2. Check all the changed places and notice things display nicely on the `System preferences` UI. 3. Sign off :-D Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to David Nind from comment #9)

Rationale: The web accessibility guidelines are that link text should be meaningful, not just "here". Screen readers read out all the links, so hearing "Here" multiple times is not very useful - you want to know where the link will take you.

Thanks, David! I'll keep learning forever :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38785 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Punctuation inconsistencies |Punctuation inconsistencies |in preferences descriptions |in system preference | |descriptions -- You are receiving this mail because: You are watching all bug changes.