https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from David Nind <david@davidnind.com> --- Hi Lawrence. Thanks for the updated patch! A few things: 1. Everything works as per the test plan. 2. However, the original issue isn't fixed. If you: - click the "Suspend" button for a hold (without selecting the tick box for the hold) - complete the suspension (click Suspend in the pop-up window) - the tick box in the table header is selected - and the "X holds selected" after the table has the total number of holds Note: After applying the patch, and a restart_all, I also cleared the browser cache (and tested both in the Check out and Details sections for the patron) 3. Bug title in the commit message. Needs to be in the format: Bug XXXXX: Bug title (Note: you don't need to put rebased or anything else at the end of the title) 4. The qa script complains about tidiness: qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 1 commit(s) (applied to f019e49 'f9 Bug 42106: Spelling: Failed to loa') Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/js/holds.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/holds.js Result: [FAIL] koha-tmpl/intranet-tmpl/prog/js/holds.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/holds.js` Processing additional checks PASS! David -- You are receiving this mail because: You are watching all bug changes.