[Bug 41445] New: Wrong info about holds selection after hold suspending
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Bug ID: 41445 Summary: Wrong info about holds selection after hold suspending Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: roman.dolny@jezuici.pl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com After suspending a hold at patron's holds tab, incorrect information about holds selection is displayed. To reproduce: 1. Have unsuspended hold(s). 2. Go to patron's account, "Details" or "Check out", and "Holds" tab. 3. Click "Suspend" button in "Suspend?" column and confirm modal. 4. Notice: 4.1 checked header checkbox (first column) - not correct, checkbox(es) below are not checked 4.2 number of holds selected in line below the holds table - not correct, checkbox(es) above are not checked, buttons "Cancel selected" and "Suspend selected" are active -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |loreganlloyd@clamsnet.org Assignee|koha-bugs@lists.koha-commun |loreganlloyd@clamsnet.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #1 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 192544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192544&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state Replace .click() on select_hold_all with explicit .prop("checked", false) to prevent suspend, resume, cancel, and group hold actions from incorrectly checking the select-all checkbox and showing a wrong selected holds count. Test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count does not appear 6. Repeat steps 3-5 from the Check out -> Holds tab 7. Repeat using Resume, Cancel, and Group hold actions Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |CLAMS list of Sponsors| | Status|Needs Signoff |Signed Off Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192544|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 192548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192548&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state Replace .click() on select_hold_all with explicit .prop("checked", false) to prevent suspend, resume, cancel, and group hold actions from incorrectly checking the select-all checkbox and showing a wrong selected holds count. Test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count does not appear 6. Repeat steps 3-5 from the Check out -> Holds tab 7. Repeat using Resume, Cancel, and Group hold actions Sponsored-by: CLAMS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the holds table release notes| |for a patron after a hold | |is suspended (in the "Check | |out" and "Details" section | |for a patron record in the | |staff interface). | | | |After suspending a hold, no | |holds are selected in the | |holds table. | | | |Previously, after | |suspending a hold: | |- The tick box in table | |header (the first column) | |was selected | |- There was no tick in any | |of the tick boxes for | |individual | | holds | |- The count at the bottom | |for "holds selected" was | |the total | | number of holds | |- The action buttons were | |active ("Cancel selected" | |and "Suspend selected") --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. It took me a while to understand what the issue was before the patch - "wrong info" didn't help. 8-) 2. Place some holds for a patron. 3. Go to the patron's account, and the holds tab under either the "Check out" or "Details" section. 4. Suspend a hold and then the pop-up window that lets you select a "suspend until" date appears. 5. Immediately after you click "Suspend" from the pop-up window, note that: - The tick box in the holds table header (the first column) is selected - There is no tick in any of the tick boxes for individual holds - The count at the bottom shows the total number of holds - The action buttons are active ("Cancel selected" and "Suspend selected") 6. After the patch, things for step 5 are shown as expected - that is, no holds are selected: - The tick box in the holds table header in the first column is not selected - No individual holds are selected - The count at the bottom for "holds selected" is 0 - None of the action buttons are active ("Cancel selected" and "Suspend selected") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au Status|Signed Off |Failed QA --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Mmm the behaviour between the "Cancel selected" and "Suspend selected" buttons is inconsistent. If you cancel the "Cancel" modal, it clears the selections. If you cancel the "Suspend" modal, it keeps the selections. After I cancel 1 hold, the "Holds" tab still says 3, it says "1 holds selected" and the "Cancel selected" and "Suspend selected" buttons are still active. I'm not sure how to do the "Group hold actions" in the test plan. Needs more information. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192548|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #5 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198036&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state Replace .click() on select_hold_all with explicit .prop("checked", false) to prevent suspend, resume, cancel, and group hold actions from incorrectly checking the select-all checkbox and showing a wrong selected holds count. Test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count does not appear 6. Repeat steps 3-5 from the Check out -> Holds tab 7. Repeat using Resume, Cancel, and Group hold actions Sponsored-by: CLAMS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #6 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198037&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state Replace .click() on select_hold_all with explicit .prop("checked", false) to prevent suspend, resume, cancel, and group hold actions from incorrectly checking the select-all checkbox and showing a wrong selected holds count. Test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count does not appear 6. Repeat steps 3-5 from the Check out -> Holds tab 7. Repeat using Resume, Cancel, and Group hold actions Sponsored-by: CLAMS Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #7 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198038&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) Adjust behavior so that cancel or closing "Cancel" modal does not clear selections. Ensures after canceling a hold 'Holds' tab badge shows the current count. While this patch standardizes the .click() toggle pattern associated with #group-modal for consistency, I am going to remove group holds info from the testing because group modal adjustments seem out of scope for this update as additional adjustments would be required elsewhere. - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context, also replacing the .click() toggle pattern with direct prop manipulation - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Select one or more unsuspended holds and verify count on holds selected is correct 4. Select Suspect, then Suspend on the modal 5. Notice selection boxes are unchecked and holds selected count is zero 6. Repeat steps 3-5 pressing the trash can under the Delete column instead 7. Repeat steps 3-5 using the 'Cancel selected' button underneath the holds table 8. Repeat steps 3-5 using the 'Suspend Selected' button under the holds table 9. Select an unsuspended hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections maintain selected and count of holds selected is correct 10. Repeat step 9 using 'Suspend selected' button Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #8 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... Also, I'm not sure that "...(follow up) is required in the commit title (see the commit message guidelines for correct use of "follow-up" https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) git bz apply 41445 📋 Bug 41445 - Wrong info about holds selection after hold suspending • 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): Patch application failed for attachment 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #9 from David Nind <david@davidnind.com> --- git bz apply 41445 📋 Bug 41445 - Wrong info about holds selection after hold suspending • 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) The patch no longer applies 8-(... (pasting the full message - sha1/fake ancestor erros). Also, I'm not sure that "...(follow up) is required in the commit title (see the commit message guidelines for correct use of "follow-up" https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): Patch application failed for attachment 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) Patches left in /tmp/41DhyqJoWv for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/41DhyqJoWv/0001-198038.patch) failed: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/holds.js). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #10 from David Nind <david@davidnind.com> --- Third time lucky! The patch no longer applies 8-(... Getting a sha1/fake ancestor error. Also, I'm not sure that "...(follow up) is required in the commit title (see the commit message guidelines for correct use of "follow-up" https://wiki.koha-community.org/wiki/Commit_messages#Follow-ups) Apply patch output with sha1/fake ancestor error at the end =========================================================== git bz apply 41445 📋 Bug 41445 - Wrong info about holds selection after hold suspending • 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) Apply? [(y)es, (n)o, (i)nteractive] y Preparing 1 patch(es): ✓ Prepared 1 patch(es) Applying 1 patch(es): Patch application failed for attachment 198038 - Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state (follow up) Patches left in /tmp/41DhyqJoWv for manual application if needed To resolve: 1. Fix conflicts (use 'git mergetool' or edit files manually) 2. Stage resolved files with 'git add' 3. Continue with 'git bz apply --continue' or 'git am --continue' 4. Or skip this patch with 'git bz apply --skip' 5. Or abort with 'git bz apply --abort' Error: Apply failed: Git command (git am -3 /tmp/41DhyqJoWv/0001-198038.patch) failed: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/js/holds.js). error: could not build fake ancestor hint: Use 'git am --show-current-patch=diff' to see the failed patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198038|0 |1 is obsolete| | --- Comment #11 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198095&action=edit Fix hold actions incorrectly toggling select-all checkbox state (rebased) Adjust behavior so that cancel or closing 'Cancel' modal does not clear selections. Ensures after canceling a hold 'Holds' tab badge shows the current count. While this patch standardizes the .click() toggle pattern associated with #group-modal for consistency, I am going to remove group holds info from the testing because group modal adjustments seem out of scope for this update as additional adjustments would be required elsewhere. - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context, also replacing the .click() toggle pattern with direct prop manipulation - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Select one or more unsuspended holds and verify count on holds selected is correct 4. Select Suspend button in Suspend? column, then Suspend on the modal 5. Notice selection boxes are unchecked and holds selected count is zero 6. Repeat steps 3-5 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation' in the modal 7. Repeat steps 3-5 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation' in the modal 8. Select a hold. Click on a trash can icon the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections maintain selected and count of holds selected is correct 9. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections maintain selected and count of holds selected is correct 10. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections maintain selected and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from David Nind <david@davidnind.com> --- Hi Lawrence. Thanks for the updated patch! A few things: 1. Everything works as per the test plan. 2. However, the original issue isn't fixed. If you: - click the "Suspend" button for a hold (without selecting the tick box for the hold) - complete the suspension (click Suspend in the pop-up window) - the tick box in the table header is selected - and the "X holds selected" after the table has the total number of holds Note: After applying the patch, and a restart_all, I also cleared the browser cache (and tested both in the Check out and Details sections for the patron) 3. Bug title in the commit message. Needs to be in the format: Bug XXXXX: Bug title (Note: you don't need to put rebased or anything else at the end of the title) 4. The qa script complains about tidiness: qa Tag v25.05.00-1 found in /kohadevbox/koha — checking out branch main in /kohadevbox/qa-test-tools Already on 'main' Your branch is up to date with 'origin/main'. testing 1 commit(s) (applied to f019e49 'f9 Bug 42106: Spelling: Failed to loa') Processing files [RUNNING] koha-tmpl/intranet-tmpl/prog/js/holds.js [FAIL] koha-tmpl/intranet-tmpl/prog/js/holds.js Result: [FAIL] koha-tmpl/intranet-tmpl/prog/js/holds.js FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl koha-tmpl/intranet-tmpl/prog/js/holds.js` Processing additional checks PASS! David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #13 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198112&action=edit Bug 41445: Fix hold actions incorrectly toggling select-all checkbox state Replace `.click()` toggle calls on `.select_hold_all` with explicit prop manipulation throughout holds.js. The `.click()` approach toggled the checkbox state rather than reliably clearing it, causing the select-all checkbox and holds-selected counter to be incorrectly set after hold actions. - Replace `.click()` toggle in suspend-modal-submit done handler with direct prop manipulation; this was the root cause of the original report — suspending a single hold via the button would check select-all and show total holds selected - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Without selecting any checkboxes, click the Suspend button in the Suspend? column and confirm — verify select-all is NOT checked and holds selected count is zero 4. Select one or more unsuspended holds and verify count on holds selected is correct 5. Select Suspend button in Suspend? column, then Suspend on the modal 6. Notice selection boxes are unchecked and holds selected count is zero 7. Repeat steps 4-6 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation" in the modal 8. Repeat steps 4-6 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation" in the modal 9. Select a hold. Click on a trash can icon in the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 10. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 11. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #14 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 198113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198113&action=edit Bug 41445: Wrong info about holds selection after hold suspending Replace `.click()` toggle calls on `.select_hold_all` with explicit prop manipulation throughout holds.js. The `.click()` approach toggled the checkbox state rather than reliably clearing it, causing the select-all checkbox and holds-selected counter to be incorrectly set after hold actions. - Replace `.click()` toggle in suspend-modal-submit done handler with direct prop manipulation; this was the root cause of the original report — suspending a single hold via the button would check select-all and show total holds selected - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Without selecting any checkboxes, click the Suspend button in the Suspend? column and confirm — verify select-all is NOT checked and holds selected count is zero 4. Select one or more unsuspended holds and verify count on holds selected is correct 5. Select Suspend button in Suspend? column, then Suspend on the modal 6. Notice selection boxes are unchecked and holds selected count is zero 7. Repeat steps 4-6 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation" in the modal 8. Repeat steps 4-6 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation" in the modal 9. Select a hold. Click on a trash can icon in the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 10. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 11. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198095|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198113|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 198115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198115&action=edit Bug 41445: Wrong info about holds selection after hold suspending Replace `.click()` toggle calls on `.select_hold_all` with explicit prop manipulation throughout holds.js. The `.click()` approach toggled the checkbox state rather than reliably clearing it, causing the select-all checkbox and holds-selected counter to be incorrectly set after hold actions. - Replace `.click()` toggle in suspend-modal-submit done handler with direct prop manipulation; this was the root cause of the original report — suspending a single hold via the button would check select-all and show total holds selected - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Without selecting any checkboxes, click the Suspend button in the Suspend? column and confirm — verify select-all is NOT checked and holds selected count is zero 4. Select one or more unsuspended holds and verify count on holds selected is correct 5. Select Suspend button in Suspend? column, then Suspend on the modal 6. Notice selection boxes are unchecked and holds selected count is zero 7. Repeat steps 4-6 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation" in the modal 8. Repeat steps 4-6 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation" in the modal 9. Select a hold. Click on a trash can icon in the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 10. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 11. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- If I select 3 holds to cancel a click "Canceled selected" I get a pop-up with: This action will cancel 3 hold(s). When bulk suspending there should be a similar message, there isn't. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #17 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 201412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201412&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org Status|Needs Signoff |Failed QA --- Comment #18 from Brendan Lawlor <blawlor@clamsnet.org> --- There's a small bug if you have multiple holds selected and click on the trash icon in the Delete? column, the modal will warn This action will cancel x holds for the number of selected holds, but when you confirm it only cancels the hold for the row. The behavior of only doing the cancel action on the row that you clicked is correct, but the badge in the modal showing the number is inaccurate in this case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198115|0 |1 is obsolete| | Attachment #201412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 203658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203658&action=edit Bug 41445: Wrong info about holds selection after hold suspending Replace `.click()` toggle calls on `.select_hold_all` with explicit prop manipulation throughout holds.js. The `.click()` approach toggled the checkbox state rather than reliably clearing it, causing the select-all checkbox and holds-selected counter to be incorrectly set after hold actions. - Replace `.click()` toggle in suspend-modal-submit done handler with direct prop manipulation; this was the root cause of the original report — suspending a single hold via the button would check select-all and show total holds selected - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Without selecting any checkboxes, click the Suspend button in the Suspend? column and confirm — verify select-all is NOT checked and holds selected count is zero 4. Select one or more unsuspended holds and verify count on holds selected is correct 5. Select Suspend button in Suspend? column, then Suspend on the modal 6. Notice selection boxes are unchecked and holds selected count is zero 7. Repeat steps 4-6 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation" in the modal 8. Repeat steps 4-6 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation" in the modal 9. Select a hold. Click on a trash can icon in the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 10. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 11. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 203659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203659&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from David Nind <david@davidnind.com> --- (In reply to Brendan Lawlor from comment #18)
There's a small bug if you have multiple holds selected and click on the trash icon in the Delete? column, the modal will warn This action will cancel x holds for the number of selected holds, but when you confirm it only cancels the hold for the row.
The behavior of only doing the cancel action on the row that you clicked is correct, but the badge in the modal showing the number is inaccurate in this case.
Can confirm that this is the case. If you do the same and click 'Suspend", you don't get a date selection box (and no similar message) and it only suspends the first hold. Whichever way we go, they should be consistent - that is, if you select multiple but click the individual delete or suspend button it should delete/suspend either only the selected hold or all the holds. I'm not sure what the behavour was like when there wasn't a bug. Apologies for the sign off - was testing at the same time and didn't notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org --- Comment #22 from Jason Robb <jrobb@sekls.org> --- Another tiny thing - in the MSG_SUSPEND_ALERT badge (visible when you select multiple holds then suspend them at once), the count is shown as a white number on a yellow box which is hard to read. I think that badge span just needs to have the "text-bg-warning" class rather than "bg-warning" class to pull in the proper styles and make it a black number on yellow. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203659|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #23 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 203660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203660&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. Incorporates QA feedback. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). 9. With multiple holds selected, click on a trashcan icon in the Delete? column. Note the absence of the alert This Action will cancel x holds in the modal. Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #24 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 203661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203661&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. Incorporates QA feedback, removing cancel hold warning alert from modal after canceling a single hold via the Delete? column and adjusts styling for readability in the MSG_SUSPEND_ALERT badge when suspending multiple holds. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). 9. With multiple holds selected, click on a trashcan icon in the Delete? column. Note the absence of the alert This Action will cancel x holds in the modal. Sponsored-by: CLAMS Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #25 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Thanks for the feedback, everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #26 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 203669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203669&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. Incorporates QA feedback, removing cancel hold warning alert from modal after canceling a single hold via the Delete? column and adjusts styling for readability in the MSG_SUSPEND_ALERT badge when suspending multiple holds. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). 9. With multiple holds selected, click on a trashcan icon in the Delete? column. Note the absence of the alert This Action will cancel x holds in the modal. Assisted by: Opus 5 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203669|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #27 from Jason Robb <jrobb@sekls.org> --- Created attachment 203818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203818&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. Incorporates QA feedback, removing cancel hold warning alert from modal after canceling a single hold via the Delete? column and adjusts styling for readability in the MSG_SUSPEND_ALERT badge when suspending multiple holds. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). 9. With multiple holds selected, click on a trashcan icon in the Delete? column. Note the absence of the alert This Action will cancel x holds in the modal. Assisted by: Opus 5 (Anthropic) Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #28 from Jason Robb <jrobb@sekls.org> --- I tried the various scenarios and everything worked great for me! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203658|0 |1 is obsolete| | Attachment #203818|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #29 from Jason Robb <jrobb@sekls.org> --- Created attachment 203822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203822&action=edit Bug 41445: Wrong info about holds selection after hold suspending Replace `.click()` toggle calls on `.select_hold_all` with explicit prop manipulation throughout holds.js. The `.click()` approach toggled the checkbox state rather than reliably clearing it, causing the select-all checkbox and holds-selected counter to be incorrectly set after hold actions. - Replace `.click()` toggle in suspend-modal-submit done handler with direct prop manipulation; this was the root cause of the original report — suspending a single hold via the button would check select-all and show total holds selected - Remove premature deletion of localStorage.selectedHolds from the 'Cancel selected' click handler; selections were being lost before the user confirmed the action - Remove the select_hold_all guard in the cancelModalConfirmBtn done handler so selections are always cleared after a confirmed cancel, not only when select-all was used - Remove the holdsTable reload from the cancelModal hidden.bs.modal handler; it was rebuilding the DOM on dismiss (wiping visual checkbox state) and was redundant on confirm since .success() already reloads - Apply the same fixes in the load_patron_holds_table context - Update the holds tab badge count on draw.dt so it reflects the current row count after any table reload Revised test plan: 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Without selecting any checkboxes, click the Suspend button in the Suspend? column and confirm — verify select-all is NOT checked and holds selected count is zero 4. Select one or more unsuspended holds and verify count on holds selected is correct 5. Select Suspend button in Suspend? column, then Suspend on the modal 6. Notice selection boxes are unchecked and holds selected count is zero 7. Repeat steps 4-6 using the trash can icon in the 'Delete?' column and clicking "Confirm cancellation" in the modal 8. Repeat steps 4-6 using the 'Cancel selected' button underneath the holds table clicking "Confirm cancellation" in the modal 9. Select a hold. Click on a trash can icon in the 'Delete?' column. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 10. Select an unsuspended hold. Click the 'Suspend Selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct 11. Select a hold. Click the 'Cancel selected' button under the holds table. Use the X to dismiss modal or click cancel. Confirm selections remain and count of holds selected is correct Sponsored-by: CLAMS Assisted by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #30 from Jason Robb <jrobb@sekls.org> --- Created attachment 203823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203823&action=edit Bug 41445: Wrong info about holds selection after hold suspending (follow up) Adds bulk suspend warning message and fixes warning message cleanup. Incorporates QA feedback, removing cancel hold warning alert from modal after canceling a single hold via the Delete? column and adjusts styling for readability in the MSG_SUSPEND_ALERT badge when suspending multiple holds. To test: 1. Apply previous patch 2. Navigate to a patron with multiple holds 3. Select multiple holds and click cancel selected. Notice alert: This action will cancel 2 hold(s). hit cancel. 4. Click Cancel selected. Notice alert isn't displayed in modal (This action will cancel 2 hold(s).) 5. Click suspend selected. Notice there is no alert. 6. Apply new patch. 7. Repeat step 3-4. Confirm alert is displayed in cancel selected modal both times. 8. Repeat step 5. Confirm alert is displayed This action will suspend 2 hold(s). 9. With multiple holds selected, click on a trashcan icon in the Delete? column. Note the absence of the alert This Action will cancel x holds in the modal. Assisted by: Opus 5 (Anthropic) Signed-off-by: Jason Robb <jrobb@sekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- This is untranslatable as is: var MSG_SUSPEND_ALERT = __( "This action will suspend <span class='badge text-bg-warning'>%s</span> hold(s)." ); We shouldn't mix text to translate and HTML. https://wiki.koha-community.org/wiki/Coding_Guidelines#JS3:_Avoid_strings_wh... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #32 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 205452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205452&action=edit Bug 41445: (QA follow-up) Avoid mixing text and markup in translatable string Update avoids mixing text and markup in MSG_SUSPEND_ALERT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #205452|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #33 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 205470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=205470&action=edit Bug 41445: (follow-up) Avoid mixing text and markup in translatable string Update avoids mixing text and markup in MSG_SUSPEND_ALERT Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #34 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I can no longer recreate the issue as originally reported. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #35 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- I was able to replicate the original issue. Here are the steps I took on main (26.06.00) in KTD. 1. Create a patron with 2 or more holds, none of them suspended. 2. Go to the patron's account → Details tab (or Check out — both behave the same). 3. Click the Holds tab. Note the starting state: the header checkbox in the first column is unticked, no row checkboxes are ticked, the counter below the table reads "0 holds selected", and "Cancel selected" and "Suspend selected" are greyed out. 4. Without ticking any checkbox, click the Suspend button in the "Suspend?" column for any hold. 5. Click Suspend in the modal to confirm. 6. Note the incorrect state: - the header checkbox (first column) is now ticked - none of the row checkboxes are ticked - the counter reads "X holds selected", where X is the total number of holds in the table - "Cancel selected" and "Suspend selected" are now enabled, but clicking either does nothing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #36 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 206073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206073&action=edit Image of holds table with incorrect holds selected count -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thanks Lawrence, now I am recreating. A couple things here: 1. Are we doing too much here? Why not just? - $(".select_hold_all").click(); + $(".select_hold_all").prop("checked", false); + $(".holds_table .select_hold").prop("checked", false); + localStorage.selectedHolds = "[]"; + updateSelectedHoldsButtonCounters(); 2. How will these changes effect reserve/request.tt? Do we need to add something about that page to the test plan since the same code is called there? kohadev-koha@kohadevbox:koha(main)$ git grep 'js/holds.js' koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt: [% Asset.js("js/holds.js") | $raw %] koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: [% Asset.js("js/holds.js") | $raw %] koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt: [% Asset.js("js/holds.js") | $raw %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206073|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #38 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- 1. Sounds good. I will implement as such which will address the bug description. All other work can be considered out of scope and require new bug reports and fixes, such as fixes to the cancel holds modal's cleanup, cleanup after resuming a single hold with multiple item checkboxes checked, and the warning in the bulk suspend modal. 2. When implemented as suggested, the change to holds.js will not change behavior on reserve/request.tt as the suspend modal causing the issue is not shown there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203822|0 |1 is obsolete| | Attachment #203823|0 |1 is obsolete| | Attachment #205470|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #39 from Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> --- Created attachment 206310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206310&action=edit Bug 41445: Fix cleanup after single hold is suspended This fixes information displayed in the holds table for a patron after a single hold is suspended (in the "Check out" and "Details" sections for a patron record in the staff interface). After suspending a hold, no holds are selected in the holds table, the select_hold_all checkbox is unchecked, and the holds select badge counter is 0. Test plan: 0. Apply patch 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count is set to 0 6. Repeat steps 3-5 from the Check out -> Holds tab Assisted-by: Opus 5 (Anthropic) Sponsored-by: CLAMS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This fixes the holds table |This fixes the holds table release notes|for a patron after a hold |for a patron after a single |is suspended (in the "Check |hold is suspended (in the |out" and "Details" section |"Check out" and "Details" |for a patron record in the |section for a patron record |staff interface). |in the staff interface). | | |After suspending a hold, no |After suspending a hold, no |holds are selected in the |holds are selected in the |holds table. |holds table. | | |Previously, after |Previously, after |suspending a hold: |suspending a hold: |- The tick box in table |- The tick box in table |header (the first column) |header (the first column) |was selected |was selected |- There was no tick in any |- There was no tick in any |of the tick boxes for |of the tick boxes for |individual |individual | holds | holds |- The count at the bottom |- The count at the bottom |for "holds selected" was |for "holds selected" was |the total |the total | number of holds | number of holds |- The action buttons were |- The action buttons were |active ("Cancel selected" |active ("Cancel selected" |and "Suspend selected") |and "Suspend selected") -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lawrence O'Regan-Lloyd <loreganlloyd@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206310|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #40 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 206685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206685&action=edit Bug 41445: Fix cleanup after single hold is suspended This fixes information displayed in the holds table for a patron after a single hold is suspended (in the "Check out" and "Details" sections for a patron record in the staff interface). After suspending a hold, no holds are selected in the holds table, the select_hold_all checkbox is unchecked, and the holds select badge counter is 0. Test plan: 0. Apply patch 1. Go to a patron with 2 or more active holds 2. Navigate to Details -> Holds tab 3. Click Suspend on a single hold and confirm 4. Verify the select-all checkbox remains unchecked 5. Verify the selected holds count is set to 0 6. Repeat steps 3-5 from the Check out -> Holds tab Assisted-by: Opus 5 (Anthropic) Sponsored-by: CLAMS Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #41 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.11.00 |26.11.00,26.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41445 --- Comment #42 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to 26.05.x for the upcoming 26.05.06 release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org