https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38329 Bug ID: 38329 Summary: Remove orphan confirm_deletion() in supplier.tt Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org Depends on: 28082 A dozen years ago, we used YUI rather than Bootstrap, and https://git.koha-community.org/Koha-community/Koha/src/commit/f05a8c839f7bd2... was actually used. The switch to Bootstrap duplicated the function in koha-tmpl/intranet-tmpl/prog/en/includes/acquisitions-toolbar.inc, so we had two of them with slightly different strings (and I'm not going down the rabbit-hole of which one was actually used), until bug 28082 switched it from a link with href="javascript:confirm_deletion()" to a form a couple of years ago. Luckily, that was on 22.05, before every currently supported version, so it doesn't matter which one was used, because there's only one and it is unused on every current version. Now, it's just a complete orphan which gives a false-positive for anyone looking for the ?op="delete" which will fail due to CSRF protection. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28082 [Bug 28082] Add acquisitions toolbar to vendors on vendor search page -- You are receiving this mail because: You are watching all bug changes.