https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24609 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Tomás Cohen Arazi from comment #11)
The code for update() is missing a ->discard_changes() call before returning $checkout->to_api, so the timestamp does not look updated on the response,
Regarding the logic in it, I'm worried about the simplicity and how this might need some round actions to trigger things like account fixes, etc.I'm not saying it is wrong, but it looks suspiciously simple without having dug too much into the area recently (i.e. I would accept an 'is safe' from you, if you say so).
By 'round' actions, do you mean things like triggering an updateFines call ? -- You are receiving this mail because: You are watching all bug changes.