https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43121 Bug ID: 43121 Summary: Vue: Don't pattern match on translatable strings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@gmail.com, matt.blenkinsop@openfifth.co.uk, me@paulderscheid.xyz Target Milestone: --- I think we've discovered a bad design pattern here, that crept into the Vue work: We sometimes match untranslatable strings on translatable strings, so they won't match in an installation that is not English. Example: koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: { name: "Ordering information", pane: 2 }, koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), koha-tmpl/intranet-tmpl/prog/js/vue/components/Vendors/VendorResource.vue: group: $__("Ordering information"), I believe there are more occurences for this and we maybe need a coding guideline. In other cases we seem to have both translatable, which probably works, but still seems like a less than ideal pattern. We should be matching on things, that don't change between languages. Note: the problems in the vendor detail Vue is visible as a display bug (sequence of sections) in 26.05. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.