http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #11)
Hi Jonathan, Katrin,
could you take a look at the license and check if you want to update to GPL3? FAIL C4/Search/History.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 261) Will be fixed in a followup.
(In reply to Katrin Fischer from comment #12)
I wonder if PurgeSearchHistory should be moved into the new module, what do you think? It was introduced by bug 10361.
I open a new report for that : bug 10933. (In reply to Katrin Fischer from comment #13)
Some more notes:
1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this.
I wasn't aware about this rule. I just see it's in the coding guidelines but I am wondering if it is currently the case. Looking at the Koha namespace a lot of modules don't use the CamelCase notation.
2) Shouldn't Search_SearchHistory.t be Search_History.t?
Not from this patch. Bug 10933 will delete this file.
3) Search_SearchHistory.t also fails for me:
I will fix that! -- You are receiving this mail because: You are watching all bug changes.