http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20734 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20734&action=edit Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20734|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20951&action=edit Bug 10807: Add an authority search history for the OPAC -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10862 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20951|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20988 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20988&action=edit [SIGNED-OFF] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 20990 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20990&action=edit Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Owen, Thank you for the followup, I let you change the status to "signed off" if it is good for you. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, could you take a look at the license and check if you want to update to GPL3? FAIL C4/Search/History.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 261) OK valid OK critic Continueing testing... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |gmcharlt@gmail.com --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some more notes: 1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this. 2) Shouldn't Search_SearchHistory.t be Search_History.t? 3) Search_SearchHistory.t also fails for me: [~/kohaclone (52-10807-authoritysearchhistory)]> prove t/db_dependent/Search_SearchHistory.t t/db_dependent/Search_SearchHistory.t .. 1/6 # Failed test 'use C4::Search;' # at t/db_dependent/Search_SearchHistory.t line 24. # Tried to use 'C4::Search'. # Error: "AddSearchHistory" is not exported by the C4::Search module # Can't continue after import errors at (eval 26) line 2 # BEGIN failed--compilation aborted at (eval 26) line 2. t/db_dependent/Search_SearchHistory.t .. 2/6 Undefined subroutine &main::AddSearchHistory called at t/db_dependent/Search_SearchHistory.t line 39. # Looks like you planned 6 tests but ran 2. # Looks like you failed 1 test of 2 run. # Looks like your test exited with 255 just after 2. t/db_dependent/Search_SearchHistory.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 5/6 subtests Failing for 3), but please check with Galen about 1) if possible and take a look at the other comments. Thx! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #11)

Hi Jonathan, Katrin,

could you take a look at the license and check if you want to update to GPL3? FAIL C4/Search/History.pm OK pod FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 261) Will be fixed in a followup.

(In reply to Katrin Fischer from comment #12)

I wonder if PurgeSearchHistory should be moved into the new module, what do you think? It was introduced by bug 10361.

I open a new report for that : bug 10933. (In reply to Katrin Fischer from comment #13)

Some more notes:

1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this.

I wasn't aware about this rule. I just see it's in the coding guidelines but I am wondering if it is currently the case. Looking at the Koha namespace a lot of modules don't use the CamelCase notation.

2) Shouldn't Search_SearchHistory.t be Search_History.t?

Not from this patch. Bug 10933 will delete this file.

3) Search_SearchHistory.t also fails for me:

I will fix that! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21362&action=edit Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Galen Charlton from comment #18)

(In reply to Jonathan Druart from comment #14)

...

...

1) The subs in Search:History.pm don't seem to follow our usual naming conventions. I am a bit unsure about this.

I wasn't aware about this rule. I just see it's in the coding guidelines but I am wondering if it is currently the case. Looking at the Koha namespace a lot of modules don't use the CamelCase notation.

Yeah, we haven't been consistent. I have no strong feelings one way or the other.

Me either, except I think that for a module that isn't OO, get is a bad name for a subroutine. If it were $history->get() I'd be ok with that. But having to fully qualify it Search::History::get() to make it meaningful I think is a bit clumsy. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #20)

(In reply to Chris Cormack from comment #19)

...

Me either, except I think that for a module that isn't OO, get is a bad name for a subroutine.

If it were $history->get() I'd be ok with that. But having to fully qualify it Search::History::get() to make it meaningful I think is a bit clumsy.

Indeed, although a fully-qualified Search::History::get() might be better than optionally exporting a GetSearchHistory().

But I think we're more or less on the same page -- best of all would be turning it into a class, and I think that could be done with only a small effort.

Hello Chris and Galen, I created the module in the C4 namespace precisely because it is not a OO module. There are some doubt (at least for me) about how to create a new module into Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc. The last time I thought I created a correct module (bug 10363), the patch has been ejected in the discussion status. With this patch, I simply tried to group search history code into a module in order to re-use it somewhere else (bug 10862). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Jonathan Druart from comment #21)

I created the module in the C4 namespace precisely because it is not a OO module.

I don't recall there be any requirement that the Koha names *only* be for OO-modules. New modules should preferentially be OO, but there is a place in Koha for modules that are simply collections of utility code. In this case, Koha::Search::History can be readily made OO, IMO.

There are some doubt (at least for me) about how to create a new module into Koha: Dbix will arrive shortly (or not), Moo, Class::Accessor, etc.

I suggest running with Class::Accessor -- there are plenty of examples in the Koha namespace already. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #23)

(In reply to Jonathan Druart from comment #21)

...

I created the module in the C4 namespace precisely because it is not a OO module.

I don't recall there be any requirement that the Koha names *only* be for OO-modules. New modules should preferentially be OO, but there is a place in Koha for modules that are simply collections of utility code.

Galen, It is in the coding guidelines: http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL15:_Object-oriente... To me this module is not perfect (by far). So I had a preference for submitting the module as it into the C4 namespace.

In this case, Koha::Search::History can be readily made OO, IMO.

I will try to move the existing module to the Koha namespace. But I prefer to do it after these patches (and patches from bug 10862) will be pushed. Hope that make sense. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22561 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22561&action=edit Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22563&action=edit Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #31 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22565 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22565&action=edit Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23677&action=edit Bug 10807: FIX if zebra is down, total is undef The search_history.total column cannot be undef. This patch adds a default value for the total value. Signed-off-by: Owen Leonard <oleonard@myacpl.org> This change doesn't negatively affect search history as far as I can tell but I also can't reproduce the bug it is meant to fix, so take this signoff with a grain of salt. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23679&action=edit Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23681&action=edit Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #39 from Jonathan Druart <jonathan.druart@biblibre.com> --- I fixed a conflict in the first patch and add a new patch for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11430 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #41 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, I am sorry, but there are too many conflicts outside of updatedatabase. Could you please rebase? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24222&action=edit Bug 10807 [Follow-up] OPAC: There is no authority search history This follow-up makes two changes: 1) Change "biblio" to "catalog" when referring to non-authority searches. 2) Make display of the authority search tab dependent on the OpacAuthorities system preference. If OPAC authority searches are disabled we shouldn't show a tab which will always be empty. To test, view the OPAC search history page with the OpacAuthorities preference both on and off. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24224&action=edit Bug 10807: FIX UT t/db_dependent/Search_SearchHistory.t Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 24226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=24226&action=edit Bug 10807: Add an authority search history for the OPAC - bootstrap Patch for the bootstrap theme Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |katrin.fischer@bsz-bw.de --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Starting to test... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |10677 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #51 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Back on this. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #53 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27372 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27372&action=edit [PASSED QA] Bug 10807: Add an authority search history for the OPAC Like biblio, this feature provides an authority search history. This history is available for connected and disconnected user. If the user is not logged in Koha, the history is stored in a cookie named 'KohaOpacRecentSearches'. The search history feature is now factorized in a new module. This patch adds: - 1 new db field search_history.type. It permits to distinguish the search type (biblio or authority). - 1 new module C4::Search::History. It deals with 2 different storages: db or cookie - 2 new UT files: t/Search/History.t and t/db_dependent/Search/History.t - 1 new behavior: the 'Search history' link (on the top-right corner of the screen) is always displayed. Test plan: 1/ Switch on the 'EnableOpacSearchHistory' syspref. 2/ Go on the opac and log out. 3/ Launch some biblio and authority searches. 4/ Go on your search history page. 5/ Check that all yours searches are displayed. 6/ Click on some links and check that results are consistent. 7/ Delete your biblio history searches. 8/ Delete your authority searches history searches. 9/ Launch some biblio and authority searches 10/ Delete all your history (cross on the top-right corner) 11/ Check that all your history search is empty. 12/ Launch some biblio and authority searches. 13/ Login to your account. 14/ Check that all previous searches are displayed. 15/ Launch some biblio and authority searches. 16/ Check that these previous searches are displayed under "Current session". 17/ Play with the 4 delete links (current / previous and biblio / authority). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All patches together pass QA script and tests. Also, new tests in t/db_dependent/ pass. Tested in all 4 OPAC themes, being logged in and anonymous. Anonymous search history will be appended to personal search history after logging in. Also verified that cleanup_database still purges search history, now also including the authority searchs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #55 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27374&action=edit [PASSED QA] Bug 10807: Change the GPL version to v3+ Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #57 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27376&action=edit [PASSED QA] Bug 10807: The new field search_history.type should be a varchar(16) varchar(255) is too wide for "biblio" and "authority" values. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 --- Comment #59 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 27378 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27378&action=edit Bug 10807: Follow-up: Change wording of tabs Changed the tabs from Catalog and Authority to Catalog searches and Authority searches to be a bit more specific. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24224|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24226|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #24222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10807 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.