https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43866 Bug ID: 43866 Summary: Patron name and card number should not be clickable in remaining 'Checking out to' headings Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle@bywatersolutions.com Depends on: 43220 Target Milestone: --- Follow-up to Bug 43220, which stopped the patron name and card number being a link in the "Checking out to" label above the barcode input on circ/circulation.pl. Two other "Checking out to" headings still render the patron name and card number as a link, by including patron-title.inc without the no_html flag: 1. koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt (around line 1060): an <h4> "Checking out to ..." shown inside the warning circmessage when the patron cannot check out (noissues is set, and OnSiteCheckoutsForce is not enabled). 2. koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation_batch_checkouts.tt (around line 85): the <legend> "Checking out to ..." on the batch checkout page. Pass no_html=1 to patron-title.inc in both places, as Bug 43220 did, so the headings are plain text and consistent with the main checkout form. Test plan: 1. Check out to a patron who is blocked from checking out (for example a restricted or debarred patron) so the warning message with the "Checking out to ..." heading is shown. Note the name and card number are a link. 2. Go to Circulation > Batch check out and select a patron. Note the "Checking out to ..." legend contains a link. 3. Apply the patch and repeat steps 1 and 2. 4. Confirm both headings show the name and card number as plain text, with no link. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43220 [Bug 43220] Patron name and card number should not be clickable in headings -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.