https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19368 --- Comment #2 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 67373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67373 Bug 19368 - Ignore words when sorting serial search Review of attachment 67373: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19368&attachment=67373) ----------------------------------------------------------------- Nice enhancement David. Just few comments/issues, all looks easy to fix ;) In update database file, don't use INSERT IGNORE, it is mysqlism. Better to make update files using perl skeleton and do needed db tests in the code. ::: installer/data/mysql/sysprefs.sql @@ +475,4 @@
('SelfCheckTimeout','120','','Define the number of seconds before the Web-based Self Checkout times out a patron','Integer'), ('SeparateHoldings','0',NULL,'Separate current branch holdings from other holdings','YesNo'), ('SeparateHoldingsBranch','homebranch','homebranch|holdingbranch','Branch used to separate holdings','Choice'), +('SerialSortIgnoreWords','des du de la le les leur d l an a the',NULL,'Words to ignore in serial search','Free'),
Your commit message says, it's empty by default... which is good idea IMHO ::: koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-search.tt @@ +38,4 @@
return confirm(_("Are you sure you want to reopen this subscription?")); }); }); + $
typo? ::: serials/serials-search.pl @@ +139,5 @@
+ } + $subsctitle =~ s/^\s+//; + $sub->{titlesort} = ucfirst($subsctitle); + + warn $subsctitle;
please, remove this warn -- You are receiving this mail because: You are watching all bug changes.