http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org Status|Signed Off |Failed QA --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have stared at this for a while, there are some things I am not completely happy with: 1) There is a visible change on the result list with this patch - the added 'Call number: ' in front of every entry. This can be hidden with CSS, so I think it's probably ok. Example: Availability: Items available for loan: Fairfield [Call number: 320] (1), Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). 2) I am stumbling a bit over 'CommasWithLinebreaks' as a class name. I'd like something that describes the content better. 3) The 'Call number: ' change is not consistent. If you have an item whose item type is marked as not for loan, it will show up separately: Example: Availability: Items available for loan: Franklin [Call number: 320] (1), Riverside [Call number: 320] (1), Union [Call number: 320] (1). Items available for reference: Fairfield [320] (1 ). Failing for 3) - would be good to get another opinion on 1) and 2). -- You are receiving this mail because: You are watching all bug changes.