http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #61)
(In reply to Chris Nighswonger from comment #59)
Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this.
If found a solution that use current code :)
I think you may be misunderstanding me. Using your proposed fix will result in justification code in multiple places. This is bad a practice otherwise known as spaghetti code[1]. It also makes the "fix" inaccessible via the C4::Labels module by placing it at the script level. This is bad practice as no other scripts (existing or future) will have access to this "fix." Unless this is corrected, I will (as the module maintainer) be forced to hold this bug in "failed-QA" status. Just to clarify: I have no issue with the proposed fix in principle. We just need to put it into the correct place in the code. [1]http://www.computerhope.com/jargon/s/spaghett.htm -- You are receiving this mail because: You are watching all bug changes.