[Bug 8375] New: Common diacritics not shown correctly when exporting batch label to PDF
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Priority: P5 - low Change sponsored?: --- Bug ID: 8375 Assignee: cnighswonger@foundations.edu Summary: Common diacritics not shown correctly when exporting batch label to PDF Severity: normal Classification: Unclassified OS: Linux Reporter: matted-34813@mypacks.net Hardware: PC Status: NEW Version: unspecified Component: Label printing Product: Koha When exporting a PDF for labels, many common diacritics display as 2 unrelated characters. ----------------- Steps to reproduce bug: a) setup a koha test environment b) get a record with a diacritic in your system catalogue search -> Z3950 search -> Author: jurgen -> select the record matching the one i selectd above (jahre) -> save record -> add item -> wait for zebra to index (5min) -> catalog serach: jahre c) generate a label batch more -> tools -> label creator -> batch -> new -> add item -> title: jahre -> select and add checked (select library if not already set) d) export as PDF select record -> export batch -> export as PDF e) open and view PDF (zoom as necessary) (you can select text with PDF viewer and cut to cllipboard if needed) Actual Results: Example PDF output that I cut and pasted: 1150Jahre Marköbel, 850 Jahre Baiersröderhof 3886542378 Books 943/.416 Expected Results: The output should have the diacritic for ö correctly displayed. 1150 Jahre Marköbel, 850 Jahre Baiersröderhof Build Date & Platform: master 2012-07-05 on Debian Squeeze Linux 2.6.32 Additional Information: Refer to my detailed efforts in bug 2246. There were too many different target solutions, so I broke the specific behavior out in this new bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |2246 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- I'm marking these label/diacritical related bugs as WONTFIX due to the well rehearsed issues of the pdf standard and diacriticals. If someone wants to put time into this, feel free to reopen and take ownership of these bugs. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- --- Comment #2 from wajasu <matted-34813@mypacks.net> --- I'm adding a fix for this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |matted-34813@mypacks.net |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #3 from wajasu <matted-34813@mypacks.net> --- Created attachment 10651 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10651&action=edit Patch enables some diacritics to show correctly when exporting labels to PDF The patch changes one line in labels/label-create-pdf.pl and calls utf8::decode($line); and it helps toggle the utf8 flag accordingly. This patch helps my diacritics to show correctly when exporting labels batches to PDF. Problem Label: 1150Jahre Marköbel, 850 Jahre Baiersröderhof 3886542378 Books 943/.416 Better Label: 1150Jahre Marköbel, 850Jahre Baiersröderhof 3886542378 Books 943/.416 The fix decodes the text we send to the PDF and turns off the utf8 flag as needed. Note: I suspect this is just a baby step for a certain subset of diacritics and someone with more extensive diacritics may not see a benefit. This patch does not fix larger unicode/embedded font issues, which require more extensive work, but it may buy time until that work is accomplished. I hope this works for others. wajasu [bug8375 0b0f8f5] Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 10652 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10652&action=edit Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10651|0 |1 is obsolete| | Attachment #10652|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 10653 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10653&action=edit Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF Signed-off-by: Mason James <mtj@kohaaloha.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mtj@kohaaloha.com --- Comment #6 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #5)
Created attachment 10653 [details] Bug 8375 - Patch for Common diacritics not shown correctly when exporting batch label to PDF
Signed-off-by: Mason James <mtj@kohaaloha.com>
works for me, nice spotting! :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 10654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10654&action=edit pic ... and a pic too -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #8 from wajasu <matted-34813@mypacks.net> --- I did some further testing. I added a second label, but with some unicode Hindi text, and that was enough to prevent this fix from working if one other label has unicode text in the batch. It prevented the utf8::decode from flipping the utf8 flag. This fix helps some of the time, and is a best effort, and will help for many latin1 cases. But this might be applicable for many one off spine label or small batch runs. Block-C1_Controls_and_Latin-1_Supplement is probably what is being enable here. Block-Latin_Extended-A - may not be. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: tiny patch, perlcritic OK after the patch passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|unspecified |rel_3_8 --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- wajasu = I think you're not on the developer list, in docs/history.txt Could you dive me your complete name ? (I can put "wajasu" in history.txt if it's your name, just confirm ;-) ) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, no string changes, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #12 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I'm getting Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 825. errors when I try to use label printing with utf-8 characters (with or without this patch). However, when changing utf8::decode to utf8::encode in this patch, everything works. Let me try to explain why: PDF::Reuse does binmode on it's file-handle so we shouldn't pass any utf-8 characters ("wide characters") to it. However, this patch proposes using utf8::decode which (according to perldoc utf8) does: · $success = utf8::decode($string) Attempts to convert in-place the octet sequence in UTF-X to the corresponding character sequence. The UTF-8 flag is turned on only if the source string contains multiple-byte UTF-X characters. If $string is invalid as UTF-X, returns false; otherwise returns true. So decode is used when we are converting bytes into utf-8 strings, not the other way around. However, utf8::encode does exactly what we need: · utf8::encode($string) Converts in-place the character sequence to the corresponding octet sequence in UTF-X. The UTF8 flag is turned off, so that after this operation, the string is a byte string. Returns nothing. Which is exactly why I'm proposing to change this patch to use encode instead of decode. I guess that this patch has passed sign-off and QA because it's a special case: We are not correctly converting latin-1 characters into utf-8 when using Z39.50 search, so we get utf-8 marked string which contains latin1 umlauts inside it. In that case, utf8::decode correctly strips utf-8 flag and everything works, but this change also breaks real string which have utf-8 characters in them. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #12)
I'm getting
Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 825.
errors when I try to use label printing with utf-8 characters (with or without this patch).
So this patch makes things no worse, and fixes them in one case? Is it possible to do a follow up which can do decode,or encode depending on certain conditions. Or better yet fix the encoding in other places and then a patch here to switch to encode. If this patch is not breaking anything more, and is fixing things in one case, it certainly isn't a regression, and so I see no need to revert it. It does improve things in one situation, until a more proper fix is done. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #14 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 11031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11031&action=edit use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts, so this example has single path hard-coded. I don't know if it's better to put font path into koha-conf.xml or can we somehow get it from system. I did try to figure out if fc-list can display paths, but failed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Hmm hardcoded paths .... I think it's better to kill this code and focus on a css based approach. But if this can be made to work with the free (as in freedom) fonts http://packages.debian.org/squeeze/ttf-liberation or ttf-dejavu-core (which I see you are using) I don't see why it couldn't go in until a better solution is committed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #16 from wajasu <matted-34813@mypacks.net> --- Here is an article that helps one see how perl has things internally encoded. Just for future reference. http://blog.twoshortplanks.com/2009/12/02/under-the-hood/ But I'm sure you experts know about this sort of stuff. I think its worth investigating the truetype option. Although I agree that some web font css label solution or such may be the worth pursuing. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to comment #16)
Although I agree that some web font css label solution or such may be the worth pursuing.
I investigated a lot Perl libraries for managing PDF. I feel we will have a better results investigating the CSS way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- I also agree HTML/CSS is far better in the long run than PDF. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11031|0 |1 is obsolete| | --- Comment #19 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 12925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12925&action=edit use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts, so this example has single path hard-coded. I don't know if it's better to put font path into koha-conf.xml or can we somehow get it from system. I did try to figure out if fc-list can display paths, but failed. http://bugs.koha-community.org/show_bug.cgi?id=8375 Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |mirko@abunchofthings.net --- Comment #20 from Mirko Tietgen <mirko@abunchofthings.net> --- Confirming that Dobrica's patch works for the example given by wajasu. Using TrueType fonts makes sense to me, the hardcoded path is ugly though. Since PDF (and the problems it comes with) is what we have now that should have precedence over what would be nice to have in the future. What about putting the font path in a syspref instead of hardcoding? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #21 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #20)
Confirming that Dobrica's patch works for the example given by wajasu. Using TrueType fonts makes sense to me, the hardcoded path is ugly though.
Since PDF (and the problems it comes with) is what we have now that should have precedence over what would be nice to have in the future.
What about putting the font path in a syspref instead of hardcoding?
+1 agreed, thats a great idea fyi: the 'ttf-dejavu*' packages need to be added to the debian/control file too -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off CC| |mjr@software.coop --- Comment #22 from MJ Ray (software.coop) <mjr@software.coop> --- Could we apply this latest patch and open new bugs for the hardcoded paths and packaging changes? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #23 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #22)
Could we apply this latest patch and open new bugs for the hardcoded paths and packaging changes?
yep, sounds like a good idea. i've created 2 new bugs for the above issues http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|2246 |9854 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9854, 9856 Depends on|9854 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #24 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #23)
(In reply to comment #22)
Could we apply this latest patch and open new bugs for the hardcoded paths and packaging changes?
yep, sounds like a good idea. i've created 2 new bugs for the above issues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9854 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856
2 signed-off patches now waiting for QA... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10653|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #25 from Dobrica Pavlinusic <dpavlin@rot13.org> --- First patch was already applied to master back in 2012, so I obsoleted it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12925|0 |1 is obsolete| | --- Comment #26 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Created attachment 16548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16548&action=edit Bug 8375 - use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts which are included in koha-conf.xml under new <ttf> section. Without this directive in kona-conf.xml code will still use latin-1 built-in pdf fonts. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #27 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I opted to use ttf font mapping in koha-conf.xml since it enables uses to use non-free msttcorefonts package to get more precise mappings to built-in pdf fonts (at expense of theirs freedom). This patch also supports correctly italic, bold and bold-italic. If there are no objections to this approach, I would love to address other two bugs which are related to this patch during this week. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #28 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Having said all that, patron cards suffer from same problems as labels do, so I will open separate bug to fix that if this mapping is good idea. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #29 from Chris Cormack <chris@bigballofwax.co.nz> --- Im happy to sign off on this as soon as bug 9856 and bug 9854 have patches to sign off on as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Vitor Fernandes <vfernandes@keep.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vfernandes@keep.pt --- Comment #30 from Vitor Fernandes <vfernandes@keep.pt> --- This patch works fine for me! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #31 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to comment #29)
Im happy to sign off on this as soon as bug 9856 and bug 9854 have patches to sign off on as well.
It looks like we are still lacking patches to move ttf pathing to a syspref. RE bugs 9854 and 9856... Embedding fonts is the only way to fix the problems according to a software engineer at Adobe who I corresponded with a couple of years back concerning this very issue. So this sounds like a good thing for now. Once patches for the above mentioned bugs are submitted, I'd be glad to sign off on this as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com Blocks|9854, 9856 | Depends on| |9854, 9856 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- I've switched the dependencies around since folks are requesting patches for 9854 and 9856 before signing off on this one, although I wonder if all three bugs should just be merged. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |d.lyons@thebeijingcenter.or | |g --- Comment #33 from Chris Nighswonger <cnighswonger@foundations.edu> --- *** Bug 10512 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paola.rossi@cineca.it --- Comment #34 from Paola Rossi <paola.rossi@cineca.it> --- Under Debian 7.1 wheezy, the master 3.13.00.021 displays the expected results: in output, the diacritic for ö is correct. After selecting: applied template: Avery 5160 | 1 x 2-5/8 applied layout: Lable Test stating lable position:1 and downloading as pdf, as required, the lable of LOC 88126978 biblio is: Dekonstruktionen, oder, Vom Widersprechen in Bildern : Schöttler-Boll, Doris, 3792709910 book 333444555666 [Schöttler-Boll, Doris is 100 MARC21 tag]. So I don't sign off the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16548|0 |1 is obsolete| | --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 21458 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21458&action=edit Bug 8375 - use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts which are included in koha-conf.xml under new <ttf> section. Without this directive in kona-conf.xml code will still use latin-1 built-in pdf fonts. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #36 from Chris Nighswonger <cnighswonger@foundations.edu> --- This will, of course, require that the user have the appropriate TTF fonts installed on their system. We visited this idea some years ago (I had code to do this very thing then), but encountered some resistance to "requiring" the user to install fonts which may not be available in the default install of thier OS. Maybe times have changed, and we no longer have issues with that aspect of the fix. Here is some historical context into which to fit this problem: http://comments.gmane.org/gmane.education.libraries.koha.devel/3413/ Also see Bug 2246 FTR: I'm all for embedded ttf fonts as it is the only realistic way to fix the problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Version|3.8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #37 from Paul Poulain <paul.poulain@biblibre.com> --- (In reply to Paola Rossi from comment #34)
Under Debian 7.1 wheezy, the master 3.13.00.021 displays the expected results: in output, the diacritic for ö is correct. <snip> So I don't sign off the patch.
Paola, I don't understand : you say "the diacritic is correct" then "I don't sign off the patch". Did you wanted to say "I sign off the patch" ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #38 from Paola Rossi <paola.rossi@cineca.it> --- (In reply to Paul Poulain from comment #37)
(In reply to Paola Rossi from comment #34)
Under Debian 7.1 wheezy, the master 3.13.00.021 displays the expected results: in output, the diacritic for ö is correct. <snip> So I don't sign off the patch.
Paola, I don't understand : you say "the diacritic is correct" then "I don't sign off the patch". Did you wanted to say "I sign off the patch" ?
Kind Paul, I wanted to say: "I don't sign off the patch" because the master was already OK without applying the patch: the master didn't show diacritics badly. I write the details of my test, because the bug could appear in another case, or in another install. In my opinion, with the test required I couldn't know if the patch fixed a bug or not, neither if it really improved master in some way. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #39 from Paul Poulain <paul.poulain@biblibre.com> --- Kyle, could you confirm that/if the problem exist BEFORE the path please ? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ghulam_murtaza692@hotmail.c | |om --- Comment #40 from Chris Nighswonger <cnighswonger@foundations.edu> --- *** Bug 11423 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #41 from MJ Ray (software.coop) <mjr@software.coop> --- (In reply to Paola Rossi from comment #38)
Kind Paul, I wanted to say: "I don't sign off the patch" because the master was already OK without applying the patch: the master didn't show diacritics badly.
That diacritic was o-umlaut which is character F6 in the latin-1 character set, wasn't it? Therefore, I think it wouldn't trigger both aspects of this bug. You're correct that the test case isn't great in that regard. I'm still getting "Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 819" when attempting to print a record containing a stroked-l (B3 from latin-2, whatever that is in utf8). I will investigate further soon but would really appreciate any thoughts from the wise heads here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #42 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. We have an open question from MJ, going back to January 9. The patch depends on something that is in status NEW and on another patch that is breaking records for being in PQA (seeing why now..) No strict dependency.. The 9856 dependency does actually not contain any code. Since the previous comment looks like a "Failed QA", I would like to ask Dobrica or Kyle to respond now. Changing status in the meantime. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Karam Qubsi <karamqubsi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karamqubsi@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bug 8375 depends on bug 9856, which changed state. Bug 9856 Summary: Add TTF font path in a syspref instead of hardcoding, for labels printing (bug 8375) http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9856 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #43 from Dobrica Pavlinusic <dpavlin@rot13.org> --- bug 9856 is obsoleted by moving ttf paths into kona-conf.xml which is better place since it involves system paths so it should be under control of system administrators as opposed to end users. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #44 from Dobrica Pavlinusic <dpavlin@rot13.org> --- I'm not getting "Wide character in compress" error from PDF::Reuse, but I do get a Use of uninitialized value within @PDF::Reuse::objekt in sprintf at /usr/share/perl5/PDF/Reuse.pm line 1092 and a bounch of Use of uninitialized value in addition (+) at /usr/share/perl5/PDF/Reuse.pm line 1286 Bottom one referes to table which exists only for built-in pdf fonts, and upper one would require me to know more about internal pdf structure than I do now. I don't have solution for those, but from my tests this patch still apply cleanly on current master and works as expected, so I would love to get it in. WRT, "Wide character in compress" we could probably fix it by digging through PDF::Reuse code and marking something utf-8 (or declaring output to use :raw handler) but in plack we are not really emitting to STDOUT but to scalar. Do you think that this is show-stopper to get this into master? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was testing this today with Dobrica's help and we are not quite there yet... but I hope some of my notes will be helpful in fixing the remaining issues: - ttf-dejavu is installed - Added the following mapping to my koha-conf.xml file: <!-- true type font mapping accoding to type from $font_types in C4/Creators/Lib.pm --> <ttf> <font type="TR"
/usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif.ttf</font> <font type="TB" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Bold.ttf</font> <font type="TI" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-Italic.ttf</font> <font type="TBI">/usr/share/fonts/truetype/ttf-dejavu/DejaVuSerif-BoldItalic.ttf</font> <font type="C" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono.ttf</font> <font type="CB" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Bold.ttf</font> <font type="CO" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-Oblique.ttf</font> <font type="CBO">/usr/share/fonts/truetype/ttf-dejavu/DejaVuSansMono-BoldOblique.ttf</font> <font type="H" >/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans.ttf</font> <font type="HB" /usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-Bold.ttf</font> <font type="HBO">/usr/share/fonts/truetype/ttf-dejavu/DejaVuSans-BoldOblique.ttf</font> </ttf>
- Created a batch with 2 items, one German with umlauts and the other Arabic. - Tried exporting the batch into PDF: -- Times New Roman: PDF opens, but the Arabic characters show up as little squares, the German record is correctly printed -- Helvetica: PDF cannot be opened, if you open it in a text editor, you can see the usual error: <pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 819 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #46 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Katrin Fischer from comment #45)
- ttf-dejavu is installed
-- Times New Roman: PDF opens, but the Arabic characters show up as little squares...
It appears that DejaVu does not support Arabic ATM: "Following scripts aren't available in all the styles: Hebrew Arabic N'ko Lao Canadian Aboriginal Syllabics Ogham Tifinagh Lisu" [1] I believe you will need to install a font which supports whatever language you would like to generate pdfs in. [1] http://dejavu-fonts.org/wiki/index.php?title=Main_Page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #47 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Today I re-invented this fix trying to answer a mail :( Comments: 1. Of DejaVu fonts, only Sans version has a good collection of chars, so we can advice to use only Helvetica if you want Arabic for example. It's not a problem of the proposed solution, but a shortcoming of the available font. I think it's the best we can do for now. 2. Helvetica (DejaVuSans) PDF fails because the wrong code is passed to the file selection on Creators/PDF.pm, I will add a followup 3. Have you tried changing justification on layout? The result is wrong. I will add another followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #48 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26905&action=edit Bug 8375 - Followup - Fix font code This follow up fixes font code taking it from layout. To test: 1. Try making a batch using Helvética, downloaded PDF do not open. 2. Apply the patch 3. Try again, now it's correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #49 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26906&action=edit Bug 8375 - Followup 2 - Fix label justification/aligning This patch use prText alignment to produce center or right align in text To test (with former patches applied): 1. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. I would suggest to use Helvetica 2. Apply the patch 3. Verify again, now strings must be correctly aligned -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #50 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26907&action=edit pic2 another pic -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #51 from MJ Ray (software.coop) <mjr@software.coop> --- Is there any reason not to fix the alignment? In other words, could we combine the two patches? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #52 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to MJ Ray (software.coop) from comment #51)
Is there any reason not to fix the alignment? In other words, could we combine the two patches?
Yes, of course. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #53 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26928&action=edit Bug 8375 - Followup - Fix font code and alignment This follow up fixes font code taking it from layout, and alignment. To test: 1. Try making a batch using Helvética, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26905|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26906|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #54 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26976&action=edit Bad right-to-left text -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #55 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26977&action=edit Good right-to-left text -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #56 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 26978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26978&action=edit Bug 8375 - Followup - Use unicode bidi for rtl languages If you print a label using arabic/hebrew script, letters are printed in logical direction, from left to right, giving a mangled result (see LTR-bag.png) This patch will try to fix those cases adding a new perl dependency, Text::Bidi, and using the automagic feature if it's log2vis() function to rearrange chars based on detected text 'direction' To test: 1. Install Text::Bidi package (apt-get install libtext-bidi-perl) 2. Try a batch, using Helvetica, with a mix of ltr and rtl (arabic/hebrew) titles, chars are good, but direction is bad 3. Apply the patch 4. Try again, now the result is good (see LTR-good.png) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #57 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #56)
This patch will try to fix those cases adding a new perl dependency, Text::Bidi, and using the automagic feature if it's log2vis() function to rearrange chars based on detected text 'direction'
This should probably have its own bug since it adds a dep. and is really unrelated to diacrticals. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12068 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #58 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Chris Nighswonger from comment #57)
This should probably have its own bug since it adds a dep. and is really unrelated to diacrticals.
Ok, Bug 12068 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #59 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #53)
Created attachment 26928 [details] [review] Bug 8375 - Followup - Fix font code and alignment
This follow up fixes font code taking it from layout, and alignment.
I see no obvious problem with the using prText for alignment (thought I have a nagging feeling there were some issues with it), however, this fix is applied in the wrong location in the code. The text justification mechanism is housed at the module level in C4::Labels::Label[1] and fixes should probably be applied there or else things will turn to spaghetti pretty fast. Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this. [1]http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.pm... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26928|0 |1 is obsolete| | --- Comment #60 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27335 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27335&action=edit Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #61 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Chris Nighswonger from comment #59)
Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this.
If found a solution that use current code :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #62 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #61)
(In reply to Chris Nighswonger from comment #59)
Also, its not apparent how this fix interacts with the existing justification code, if at all, which makes it further desirable to rewrite/replace it. Although this patch may fix the immediately apparent problem, there may be unexpected hidden side effects because of this.
If found a solution that use current code :)
I think you may be misunderstanding me. Using your proposed fix will result in justification code in multiple places. This is bad a practice otherwise known as spaghetti code[1]. It also makes the "fix" inaccessible via the C4::Labels module by placing it at the script level. This is bad practice as no other scripts (existing or future) will have access to this "fix." Unless this is corrected, I will (as the module maintainer) be forced to hold this bug in "failed-QA" status. Just to clarify: I have no issue with the proposed fix in principle. We just need to put it into the correct place in the code. [1]http://www.computerhope.com/jargon/s/spaghett.htm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #63 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Chris Nighswonger from comment #62)
I think you may be misunderstanding me.
Using your proposed fix will result in justification code in multiple places. This is bad a practice otherwise known as spaghetti code[1]. It also makes the "fix" inaccessible via the C4::Labels module by placing it at the script level. This is bad practice as no other scripts (existing or future) will have access to this "fix."
Unless this is corrected, I will (as the module maintainer) be forced to hold this bug in "failed-QA" status.
Just to clarify: I have no issue with the proposed fix in principle. We just need to put it into the correct place in the code.
Chris, I changed completely the solution. Please, take a look (second patch) The fix IS in Label.pm, that was the meaning of 'using current code.' Your were right, I was bypassing current justification code, and that was wrong. I found the real problem (non-existent font code and bad parameter to StrWidth) and fixed that. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #64 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #63)
(In reply to Chris Nighswonger from comment #62)
I think you may be misunderstanding me.
I changed completely the solution. Please, take a look (second patch) The fix IS in Label.pm, that was the meaning of 'using current code.'
Ouch! My bad. I apologize for my misunderstanding.
I found the real problem (non-existent font code and bad parameter to StrWidth) and fixed that.
I'll take a look at it now and sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #65 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Chris Nighswonger from comment #64)
Ouch! My bad. I apologize for my misunderstanding.
No problem :)
I'll take a look at it now and sign off.
Thinking about the patch, perhaps $fontCode/fontObject (or font_code/font_object) are better than $fontName, I can change that (or you, if you like) StrWidth was receiving 'TI' or 'HO' for example, not Ft1/Ft2 for embedded fonts, nor 'Times-Italic' or 'Helvetica-Oblique', in that way it use Helvetica, which is approximately good for latin scripts[1] [1] http://search.cpan.org/dist/PDF-Reuse/Reuse.pm#prStrWidth_-_calculate_the_st... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #66 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 27363 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27363&action=edit Arabic records to test with -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21458|0 |1 is obsolete| | Attachment #27335|0 |1 is obsolete| | --- Comment #67 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 27480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27480&action=edit Bug 10859: (follow-up) clarify logic on multiple loans on same bib This patch clarifies the logic for determining if a given item to be checked out would be the second (or third, etc.) loan on the same bib. As a conseqence, if the item is already on loan to the patron, the circ staffer won't see the multiple-loans-on-a-bib warning, just the confirmation to renew the loan or the warning that no more renewals are lest. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #68 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 27482 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27482&action=edit [SIGNED-OFF] Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27482|0 |1 is obsolete| | --- Comment #69 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 27483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27483&action=edit [SIGNED-OFF] Bug 8375 - use truetype fonts in PDF::Reuse Since built-in PDF fonts suport just latin-1 encoding, we have to switch to truetype fonts to correctly encode all utf-8 characters (which we should be getting from database anyway). This approach also nicely sidesteps our encoding cludges, but requires paths to truetype fonts which are included in koha-conf.xml under new <ttf> section. Without this directive in kona-conf.xml code will still use latin-1 built-in pdf fonts. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #70 from Chris Nighswonger <cnighswonger@foundations.edu> --- Created attachment 27484 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27484&action=edit [SIGNED-OFF] Bug 8375 - Followup - Fix font code and alignment This patch fixes two problems: a) Bad PDF when using Helvetica font. Current label code assigns 'italic' or 'oblique' variants to title. Helvetica-Oblique was not defined, but is present b) Bad alignment using center/right justification Problem was bad font parameter passed to StrWidth routine To test: 1. Try making a batch using Helvetica, downloaded PDF do not open. 2. Try a batch of mixed scripts with layout alignment center or right, only latin scripts align almost correctly. 3. Apply the patch and update your koha-conf.xml to add Oblique variant 4. Try again 1, now PDF opens 5. Try 2, now alignment is correct New problem (for another bug): DejaVuSans has a good support for arabic, but not Oblique variant. As selection of italic/oblique is hardcoded, now Arabic titles are not displayed. I'll try to add a checkbox to select or not this feature. Added a FIXME for the hardcoded forced oblique -chris_n Signed-off-by: Chris Nighswonger <cnighswonger@foundations.edu> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #71 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Can be changed to 'Signed-off'? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #72 from Chris Nighswonger <cnighswonger@foundations.edu> --- This works as described for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #73 from Jonathan Druart <jonathan.druart@biblibre.com> --- I never used the label creator tools, but it does not seem to work for me (tested with my UNIMARC DB and with my MARC21 using the "Arabic records" in attachment). I got badly encoded characters for barcodes 50 and 51 (see attachment). Moreover, I don't really understand why the usefulness of the font list in the koha-conf file. The font list already exist in a pl, why not just put the directory path (/usr/share/fonts/truetype/ttf-dejavu)? If a font is added in the koha-conf, it won't be added to the list in the Koha interface, which is quite odd. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #74 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Jonathan Druart from comment #73)
I never used the label creator tools, but it does not seem to work for me (tested with my UNIMARC DB and with my MARC21 using the "Arabic records" in attachment).
I got badly encoded characters for barcodes 50 and 51 (see attachment).
I seem to be missing the attachment. Please give more description of your test procedure as well.
Moreover, I don't really understand why the usefulness of the font list in the koha-conf file. The font list already exist in a pl, why not just put the directory path (/usr/share/fonts/truetype/ttf-dejavu)? If a font is added in the koha-conf, it won't be added to the list in the Koha interface, which is quite odd.
We only support the hardcoded fonts ATM. It would be good to fix the problem of hard coding but in another bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #75 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Chris Nighswonger from comment #74)
I seem to be missing the attachment. Please give more description of your test procedure as well.
Yep, sorry, it's coming. I imported the record, go on "Currently Available Layouts", edit the first layout, type:"Barcode/biblio". Manage batches > new batch > add items barcode 50, 51 > Export batch > Export > Download as pdf. And I got it, see attachment (I won't forget this time!). (I updated the koha-conf.xml, of course). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #76 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 27917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27917&action=edit pdf broken with barcode 50&51 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #77 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Jonathan Druart from comment #76)
Created attachment 27917 [details] pdf broken with barcode 50&51
With the attached records you will need to use the following fields: 245a, author, itemtype, itemcallnumber -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #78 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Jonathan Druart from comment #76)
Created attachment 27917 [details] pdf broken with barcode 50&51
Also check to be sure your ttf config tags fall inside of the <config> tags in koha-conf.xml -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #79 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #75)
(In reply to Chris Nighswonger from comment #74)
I seem to be missing the attachment. Please give more description of your test procedure as well.
Yep, sorry, it's coming. I imported the record, go on "Currently Available Layouts", edit the first layout, type:"Barcode/biblio". Manage batches > new batch > add items barcode 50, 51 > Export batch > Export > Download as pdf. And I got it, see attachment (I won't forget this time!). (I updated the koha-conf.xml, of course).
Seems that you are using Times-Roman in Layout, please confirm. If that is the case, what you view is the expected result, because there are no glyphs for that chars in DejaVuSerif. Using Helvetica will give you something better, mapping HO to DejaVuSans better, and with Bug 12063 correct display (See new attached image) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #80 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 27918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27918&action=edit Display variations -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #81 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #79)
something better, mapping HO to DejaVuSans better, and with Bug 12063
Sorry, Bug 12068 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #82 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #79)
Seems that you are using Times-Roman in Layout, please confirm. haaa! Ok thanks. I used Times-Roman.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #83 from Jonathan Druart <jonathan.druart@biblibre.com> --- hum, weird, I got ERROR in koha-conf.xml -- missing <font type="HBOO">/path/to/font.ttf</font> at /home/koha/src/C4/Creators/PDF.pm line 123ERROR in koha-conf.xml -- missing <font type="HBOO">/path/to/font.ttf</font> at /home/koha/src/C4/Creators/PDF.pm line 123 when I select "Helvetica-Bold-Oblique". The value is correct in DB: font: HBO -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #84 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #83)
hum, weird, I got ERROR in koha-conf.xml -- missing <font type="HBOO">/path/to/font.ttf</font> at /home/koha/src/C4/Creators/PDF.pm line 123ERROR in koha-conf.xml -- missing <font type="HBOO">/path/to/font.ttf</font> at /home/koha/src/C4/Creators/PDF.pm line 123
when I select "Helvetica-Bold-Oblique". The value is correct in DB: font: HBO
Problem is that current code appends an 'O' to selected font for title C4/Labels/Label.pm:400: ($field->{'code'} eq 'title') ? (($font =~ /T/) ? ($font = 'TI') : ($font = ($font . 'O'))) : ($font = $font); If you select HBO as main font, then it would search for HBOO for title -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #85 from Galen Charlton <gmcharlt@gmail.com> --- In this case, I agree with Chris. Since we have two independent signoffs, I've gone ahead and pushed this. Thanks, Dobrica! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #86 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Bernardo Gonzalez Kriegel from comment #84)
Problem is that current code appends an 'O' to selected font for title C4/Labels/Label.pm:400: ($field->{'code'} eq 'title') ? (($font =~ /T/) ? ($font = 'TI') : ($font = ($font . 'O'))) : ($font = $font);
If you select HBO as main font, then it would search for HBOO for title
Bernardo, what meant this comment? Is there a bug somewhere? I get the error on master now (with the patches). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #87 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Jonathan Druart from comment #86)
(In reply to Bernardo Gonzalez Kriegel from comment #84)
Problem is that current code appends an 'O' to selected font for title C4/Labels/Label.pm:400: ($field->{'code'} eq 'title') ? (($font =~ /T/) ? ($font = 'TI') : ($font = ($font . 'O'))) : ($font = $font);
If you select HBO as main font, then it would search for HBOO for title
Bernardo, what meant this comment? Is there a bug somewhere? I get the error on master now (with the patches).
Yes. It'a bug, but a pre-existent one, and it makes you try to use nonexistent fonts. I can add a patch, but for now do not select CO, CBO, HO or HBO for main font Can be fixed changing line 400 of C4/Labels/Label.pm with if ( $field->{'code'} eq 'title' ) { if ( $font =~ /^(T|TB)$/ ) { $font .= 'I'; } if ( $font !~ /^T/ and $font !~ /O$/ ) { $font .= 'O'; } } or something better -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #88 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Bernardo Gonzalez Kriegel from comment #87)
(In reply to Jonathan Druart from comment #86)
(In reply to Bernardo Gonzalez Kriegel from comment #84)
Problem is that current code appends an 'O' to selected font for title C4/Labels/Label.pm:400: ($field->{'code'} eq 'title') ? (($font =~ /T/) ? ($font = 'TI') : ($font = ($font . 'O'))) : ($font = $font);
If you select HBO as main font, then it would search for HBOO for title
Bernardo, what meant this comment? Is there a bug somewhere? I get the error on master now (with the patches).
Yes. It'a bug, but a pre-existent one, and it makes you try to use nonexistent fonts. I can add a patch, but for now do not select CO, CBO, HO or HBO for main font
Can be fixed changing line 400 of C4/Labels/Label.pm with
if ( $field->{'code'} eq 'title' ) { if ( $font =~ /^(T|TB)$/ ) { $font .= 'I'; } if ( $font !~ /^T/ and $font !~ /O$/ ) { $font .= 'O'; } }
or something better
This code really needs to be revisited. It would be great if Jonathan coould open a bug for it. I'll try to get to it in the next week or so. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12194 --- Comment #89 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Chris Nighswonger from comment #88)
This code really needs to be revisited. It would be great if Jonathan coould open a bug for it. I'll try to get to it in the next week or so.
Bug 12194 created. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |vimal0212@gmail.com --- Comment #90 from Chris Nighswonger <cnighswonger@foundations.edu> --- *** Bug 12286 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Barton Chittenden <barton@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|CLOSED |REOPENED CC| |barton@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #91 from Barton Chittenden <barton@bywatersolutions.com> --- Under 3.19.00.016, printing the title field containing RIGHT SINGLE QUOTATION MARK (UTF-8 0xe28099) causes the following text to be written to the PDF file. <h1>Software error:</h1> <pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820. </pre> <p> For help, please send mail to the webmaster (<a href="mailto:staff@bywatersolutions.com">staff@bywatersolutions.com</a>), giving this error message and the time and date of the error. </p> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #92 from Barton Chittenden <barton@bywatersolutions.com> --- Created attachment 37279 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37279&action=edit Marc file containing record with UTF-8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #93 from Barton Chittenden <barton@bywatersolutions.com> --- Steps to re-create bug: 1) Import 'Marc file containing record with UTF-8', create item record. [the record has a title containing 0xe28099 ] 2) Go to Tools->Labels, click 'New Batch' button. 3) Add barcode of item created in step 1. 4) Click 'Manage Batches' 5) Select the check-box for the new batch 6) Click 'Export' 7) Select a layout which contains the 'Title' field 8) Click 'Export' 9) Click 'Download as PDF' The exported PDF will read as follows: <h1>Software error:</h1> <pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820. </pre> <p> For help, please send mail to the webmaster (<a href="mailto:staff@bywatersolutions.com">staff@bywatersolutions.com</a>), giving this error message and the time and date of the error. </p> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED --- Comment #94 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Barton Chittenden from comment #91)
Under 3.19.00.016, printing the title field containing RIGHT SINGLE QUOTATION MARK (UTF-8 0xe28099) causes the following text to be written to the PDF file.
<h1>Software error:</h1> <pre>Wide character in compress at /usr/share/perl5/PDF/Reuse.pm line 820. </pre> <p> For help, please send mail to the webmaster (<a href="mailto:staff@bywatersolutions.com">staff@bywatersolutions.com</a>), giving this error message and the time and date of the error.
</p>
This is unrelated to this bug, Please open a new bug for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 --- Comment #95 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 37285 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37285&action=edit UTF-8 Quotes Hi, on current master it works for me (see the screenshot) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14463 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Rolando Isidoro <rolando.isidoro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rolando.isidoro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8375 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11121 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org