http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- First I've seen this bug, I like the feature as a whole..
From a QA perspective I think I agree with Katrin and Jonathan. As much as I'm not as totally against splitting up some of the code into smaller more manageable files I think having a standard approach to coding this stuff is important for developers to adopts and adhere to, and I feel there isn't sufficient reasoning here to split the script into multiple smaller scripts. A clearly written $op eq '' set is pretty darn clear and it makes the relation between tt -> pl and pm clearer too.
I'd prefer the single script approach here. -- You are receiving this mail because: You are watching all bug changes.