http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Magnus Enger from comment #1)

This sounds interesting! Who should be able to place the requests? Local patrons or other libraries? Is this something you will be working on, or is it more of an idea?

I'm actively developing this. This is for local patrons ( though libraries could have accounts ). In essence it is somewhat similar to how holds work, but instead of a hold for a item, it's a request for a photocopy ( or digital copy ) of part of an item. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #3 from Magnus Enger <magnus@libriotech.no> --- (In reply to Kyle M Hall from comment #2)

I'm actively developing this. This is for local patrons ( though libraries could have accounts ).

Yeah, in Norway we have a whole infrastructure for letting libraries log on to the OPACs of other libraries, in order to place ILL requests.

In essence it is somewhat similar to how holds work, but instead of a hold for a item, it's a request for a photocopy ( or digital copy ) of part of an item.

So from a Norwegian perspective, this sounds like it would take care of the copy part of ILL. Now Alex from PTFS Europe is already working on ILL over on bug 7317. Maybe it could be worthwhile to have a look at his work and see if your efforts can be combined? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com, | |nicole@bywatersolutions.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42822 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42822&action=edit Bug 14610 - Add ability to place document delivery / article requests in Koha -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42824&action=edit Bug 14610 - Update DBIC -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42826 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42826&action=edit Bug 14610 - Update circ rules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42828&action=edit Bug 14610 - Add ability to place document delivery / article requests in Koha -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Kyle, is there a description of the feature available somewhere? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Kyle! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ability to place |Add ability to place |document delivery / article |article requests in Koha |requests in Koha | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42823|0 |1 is obsolete| | Attachment #42824|0 |1 is obsolete| | Attachment #42825|0 |1 is obsolete| | Attachment #42826|0 |1 is obsolete| | Attachment #42827|0 |1 is obsolete| | Attachment #42828|0 |1 is obsolete| | Attachment #42829|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43198 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43198&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43200 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43200&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43202 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43202&action=edit Bug 14610 - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43198|0 |1 is obsolete| | Attachment #43199|0 |1 is obsolete| | Attachment #43200|0 |1 is obsolete| | Attachment #43201|0 |1 is obsolete| | Attachment #43202|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43264 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43264&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43266&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43268 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43268&action=edit Bug 14610 - Add unit tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43271&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43273&action=edit Bug 14610 - Add and update scripts -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43270|0 |1 is obsolete| | Attachment #43271|0 |1 is obsolete| | Attachment #43272|0 |1 is obsolete| | Attachment #43273|0 |1 is obsolete| | Attachment #43274|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43278 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43278&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43280 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43280&action=edit Bug 14610 - Add and update modules -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43282&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43278|0 |1 is obsolete| | Attachment #43279|0 |1 is obsolete| | Attachment #43280|0 |1 is obsolete| | Attachment #43281|0 |1 is obsolete| | Attachment #43282|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43654&action=edit [SIGNED-OFF] Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43656&action=edit [SIGNED-OFF] Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43658&action=edit [SIGNED-OFF] Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44220 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44220&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44222&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44224 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44224&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44226&action=edit Bug 14610 [QA Followup] - Add notices for all translations -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44228&action=edit Bug 14610 [QA Followup] - Change 'Opan' to 'Pending' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #53 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44230 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44230&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44232&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44234 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44234&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44236&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44238&action=edit Bug 14610 [QA Followup] - Add notices for all translations -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44240 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44240&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44242 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44242&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44238|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44917 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44917&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44919&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #71 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44921&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44923&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 44925 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44925&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #77 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, I don't see the point to have 1 file / action. I really would prefer to stick to the same structure as usual (if $op == 'add' elsif...). Why did you change that? Do you have a particular reason? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #79 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #78)

(In reply to Jonathan Druart from comment #77)

...

Kyle, I don't see the point to have 1 file / action. I really would prefer to stick to the same structure as usual (if $op == 'add' elsif...). Why did you change that? Do you have a particular reason?

It makes for simpler scripts and templates. Simplicity = less prone to have bugs.

But it means duplication of code and a change in the current practice. IMO, this should not be done without a discussion during a dev meeting. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44916|0 |1 is obsolete| | Attachment #44917|0 |1 is obsolete| | Attachment #44918|0 |1 is obsolete| | Attachment #44919|0 |1 is obsolete| | Attachment #44920|0 |1 is obsolete| | Attachment #44921|0 |1 is obsolete| | Attachment #44922|0 |1 is obsolete| | Attachment #44923|0 |1 is obsolete| | Attachment #44924|0 |1 is obsolete| | Attachment #44925|0 |1 is obsolete| | Attachment #44926|0 |1 is obsolete| | --- Comment #81 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45946&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #83 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45948&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #85 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45950 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45950&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45952&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45954&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 45956 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45956&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #94 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46519 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46519&action=edit Bug 14610 - Add and update modules Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #96 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46521 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46521&action=edit Bug 14610 - Add unit tests Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #98 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46523&action=edit Bug 14610 [QA Followup] - Remove bad copyright lines -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #100 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46525&action=edit Bug 14610 [QA Followup] - Make prompt tranlatable, only show comma if firstname is set -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #102 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46527&action=edit Bug 14610 - Update Schema files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #104 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #80)

Hm, I tend to agree with Jonathan on first glance. I think the new object code tends to be quite short and readable - so having it all in one file seems easier to comprehend. Some of the newly introduced files by this patch are really very short and the copyright/license is almost the biggest part of them. A 1:1-relation between template and .pl file also often makes it easier to navigate the code for me.

I must respectfully disagree. I think assertion that this is without precedent is also incorrect. Please see modrequest.pl, placerequest.pl, and modrequest_suspendall.pl, add_message.pl, deletemem.pl, mod_debarment.pl, setstatus.pl for examples of similar behavior. At this point those scripts are simple enough that it may seem silly, but I'm sure memberentry.pl was quite simple when it was first written as well. Now it has if statments like: if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq 'duplicate') and ($step == 0 or $step == 3 )){ I also believe the assertion that this duplicates code is incorrect. There is actually very little code shared between the two scripts if you don't count the boilerplate that all Koha cgi scripts have. Basically the duplicated code is the get_template_and_user call. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #106 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46529 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46529&action=edit Bug 14610 [QA Followup] - Don't call get_template_and_user for request-article-do.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #108 from Nick Clemens <nick@bywatersolutions.com> --- Two issues I saw: 1 - 'New request' messages are not being queued, I didn't see them when placing requests via opac or staff side 2 - Search from the article request tab only works with cardnumber. Enter patron name and press enter and the screen reloads. Works when you choose from the search options that appear as you type. Current search only checks at 3+ characters but should allow for 2 letter last names Everything else is request: * - There should be a 'Place request' button on detail.pl * - On article-requests.pl the count in the tab doesn't reload when you change the number (2 requests, mark one completed, the table updates but tab still says 2) * - Similarly, take action 'process request' and it disappears from the pending tab but does not show on the processing tab until you click update button or refresh page * - It would be nice to see article requests on circulation.pl and moremember.pl * - It would be nice to have an 'All libraries' option in the dropdown on article-requests.pl * - Article-requests.pl doesn't show owning library for a specific item request. I can follow the logic that all requests go to the pickup library, but they shold be able to see where the item is from. It might be nice to have the patrons library visible as well * - For consistency it would be nice to have the count of article requests show as holds do on detail.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46518|0 |1 is obsolete| | Attachment #46519|0 |1 is obsolete| | Attachment #46520|0 |1 is obsolete| | Attachment #46521|0 |1 is obsolete| | Attachment #46522|0 |1 is obsolete| | Attachment #46523|0 |1 is obsolete| | Attachment #46524|0 |1 is obsolete| | Attachment #46525|0 |1 is obsolete| | Attachment #46526|0 |1 is obsolete| | Attachment #46527|0 |1 is obsolete| | Attachment #46528|0 |1 is obsolete| | Attachment #46530|0 |1 is obsolete| | --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46595&action=edit Bug 14610 - Add ability to place article requests in Koha - Update database Article Requests are somewhat similar to holds, but are not requests for an item to check out. Instead, article requests are requests for a photocopy of a particular section of a book ( most often ). This is very common in academic libraries where researchers may request a copy of a single article found in a journal. This patch set adds the ability to place article requests in Koha. It allows the control of what can be requested via the circulation rules. Since article requests of electronic resources are not outside the realm of possibility, the feature will check not only the items for requstability, but the record itself as well ( i.e. both items.itype and biblio.itemtype ). Article requests can be placed for patrons from the opac and staff intranet and can be viewed in most areas where holds are viewed ( e.g. patron details, record details, etc ). There is a script to view article requests in progress within the circulation module. Article requests can be Open ( i.e. new ), In Processing, Completed, or Canceled. The status of a given request can be updated from this script. Test Plan: 1) Apply the patch set 2) Run updatedatabase.pl 3) Enable the system preference ArticleRequests 4) Set up some required fields in: ArticleRequestsMandatoryFields ArticleRequestsMandatoryFieldsItemsOnly ArticleRequestsMandatoryFieldsRecordOnly 5) Edit your circ rules, set article requests to 'yes' for something 6) Test the ability to add an article request from the opac ( required fields enforced ) 7) Test the ability to add an article request from the staff interface ( required fields no enforced ) 8) Note you can choose item level or record level requests 9) Change the rule to "record only" 10) Repeat 6 and 7 11) Note you cannot choose items 12) Change the rule to "item only" 13) Repeat 6 and 7 14) Note you must choose an item 15) Note that the 'new request' message is queued for each new request 16) Browse to /cgi-bin/koha/circ/article-requests.pl 17) Note requests are split by pickup branch 18) Test slip printing via the "Print slip" action 19) Process request vai "Process request" action 20) Note an email notice is queued for patron 21) Refresh /cgi-bin/koha/circ/article-requests.pl 22) Note request has moved to "processing" tab. 23) Complete request with "Complete request" action 24) Note message is queued for patron 25) Cancel a request, add cancelation note. 26) Note message is queued for patron Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46597 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46597&action=edit Bug 14610 - Add and update scripts Signed-off-by: Jennifer Schmidt <jschmidt@switchinc.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46599 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46599&action=edit Bug 14610 [QA Followup] - Rename AR_PRINT to AR_SLIP -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46601 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46601&action=edit Bug 14610 [QA Followup] - Fix issuingrules database update -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46603 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46603&action=edit Bug 14610 [QA Followup] - Change 'Open' to 'Pending' -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46605&action=edit Bug 14610 - Update opac.css via less -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46607&action=edit Bug 14610 [QA Followup] - Add non-ajax patron search -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46609&action=edit Bug 14610 [QA Followup] - Update article request counts in tabs -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46611&action=edit Bug 14610 [QA Followup] - Add "All libraries" option to article-requests.pl -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #127 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- First I've seen this bug, I like the feature as a whole..

From a QA perspective I think I agree with Katrin and Jonathan. As much as I'm not as totally against splitting up some of the code into smaller more manageable files I think having a standard approach to coding this stuff is important for developers to adopts and adhere to, and I feel there isn't sufficient reasoning here to split the script into multiple smaller scripts. A clearly written $op eq '' set is pretty darn clear and it makes the relation between tt -> pl and pm clearer too.

I'd prefer the single script approach here. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I think we need to talk together when a developer wants to introduce a new practice. On comment 79, I have suggested to have this discussion during the next (?) dev meeting. -- You are receiving this mail because: You are watching all bug changes.