https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36596 Bug ID: 36596 Summary: Opening/closing hours should be forced to be set together Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org It only seems to make sense to set a closing hour if an opening hour has been set, otherwise it would be open 24 hs :-D A method needs to be added to Koha::Library: * set_hours( $dow, $opening, $closing ) * The method needs to throw an exception if one of them is not passed * If none is passed then it means the library would not be open, and then all hours for the * The code for setting the hours in branches.pl should be removed and this method used instead * The method MUST BE COVERED BY TESTS NOTE: I don't personally like the chosen column name 'day'. I would use either 'dow' or 'day_of_week'. And it should be clear which one is the first in the comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.