https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 192964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192964&action=edit Bug 41813: Use library's From-address for ILL staff notifications When sending ILL staff notifications, the email "To" and "From" addresses are set equal. Libraries' sending address may differ from receiving address, so this feature should be using the usual From-address that Koha uses in any other types of email notifications. This patch changes ILL staff notifications to use the usual From address. Before applying this patch, to reproduce: 1. Create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to test@example.org 7. Set system preference KohaAdminEmailAddress to library@example.org 8. Navigate to OPAC 9. Create a new ILL request from OPAC 10. Run your SQL report from step 1 11. Observe first row column from_address as test@example.org It should be library@example.org instead Apply this patch To test: 1. Unless you already didn't, create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to test@example.org 7. Set system preference KohaAdminEmailAddress to library@example.org 8. Navigate to OPAC 9. Create a new ILL request from OPAC 10. Run your SQL report from step 1 11. Observe first row column from_address as library@example.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.