https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 --- Comment #1 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 192964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192964&action=edit Bug 41813: Use library's From-address for ILL staff notifications When sending ILL staff notifications, the email "To" and "From" addresses are set equal. Libraries' sending address may differ from receiving address, so this feature should be using the usual From-address that Koha uses in any other types of email notifications. This patch changes ILL staff notifications to use the usual From address. Before applying this patch, to reproduce: 1. Create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to test@example.org 7. Set system preference KohaAdminEmailAddress to library@example.org 8. Navigate to OPAC 9. Create a new ILL request from OPAC 10. Run your SQL report from step 1 11. Observe first row column from_address as test@example.org It should be library@example.org instead Apply this patch To test: 1. Unless you already didn't, create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to test@example.org 7. Set system preference KohaAdminEmailAddress to library@example.org 8. Navigate to OPAC 9. Create a new ILL request from OPAC 10. Run your SQL report from step 1 11. Observe first row column from_address as library@example.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Failed QA --- Comment #3 from David Nind <david@davidnind.com> --- Have changed to failed QA. I followed all the steps for "Before applying this patch, to reproduce", but the SQL report is empty for me, and I can't reproduce. So I think there is a step missing somewhere, or something else is required. For step 8, there is no ILL_REQ_CREATED notice under Tools > Patrons and circulation > Notices and slips. I was using a default/fresh KTD and using the koha user, and also: - added a primary email address to the koha user - added an SMTP server - enabled patron messaging preferences for Interlibrary loan ready, Interlibrary loan unavailable, Interlibrary loan updated Other testing notes: 1. For steps 3 to 5, I used the Centerville library 2. The patch still applies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 Lari Taskula <lari.taskula@hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #192965|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <lari.taskula@hypernova.fi> --- Created attachment 194195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194195&action=edit Bug 41813: Use library's From-address for ILL staff notifications When sending ILL staff notifications, the email "To" and "From" addresses are set equal. Libraries' sending address may differ from receiving address, so this feature should be using the usual From-address that Koha uses in any other types of email notifications. This patch changes ILL staff notifications to use the usual From address. Before applying this patch, to reproduce: 1. Create the following SQL report SELECT * FROM message_queue ORDER BY message_id DESC; 2. Enable ILL requests using system preference ILLModule 3. Navigate to Administration > Libraries 4. Make sure "ILL staff email" is empty 5. Make sure "Email" is empty 6. Set system preference ILLDefaultStaffEmail to test@example.org 7. Set system preference KohaAdminEmailAddress to library@example.org 8. Set system preference ILLSendStaffNotices to ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED|ILL_PICKUP_READY|ILL_PARTNER_REQ|ILL_REQUEST_UNAVAIL|ILL_REQUEST_UPDATE 9. Navigate to OPAC 10. Create a new ILL request from OPAC 11. Navigate to "Interlibrary loan requests" and click "View" for you recently created request 12. Write "test" to the "Notes" field 13. Click "Submit modification" 14. Navigate to staff client 15. Run your SQL report from step 1 16. Observe first row column from_address as test@example.org It should be library@example.org instead Apply this patch To test: 1. Repeat steps 1-15 from the "to reproduce" section above 2. Observe first row column from_address as library@example.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41813 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks for the updates Lari - I managed to get this to work. The main change was to view the request from the OPAC and add or edit the note field to get a notice. Testing notes (using KTD): 1. There was no need to add a primary email address, set messaging preferences for the patron used to create the ILL request, or set up an SMTP server. 2. For steps 3 to 5, I used the Centerville library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.