http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9416 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 27274 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27274 [PATCH] Bug 9416: In each order, add a new note made for the vendor Review of attachment 27274: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=9416&attachment=27274) ----------------------------------------------------------------- Hi Mathieu, 1) A few small things in the templates could be improved, I noted those below (minor) 2) On editing an order line an existing internal or vendor note doesn't show up in the input fields (major) 3) Just a note: When I looked at the CSV export I realized it does export the internal note, as before. I wonder how the new vendor note will be used, it doesn't show up on the PDFs or in the CSV export. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt @@ +1,2 @@
[% INCLUDE 'doc-head-open.inc' %] +<title>Koha › Acquisition › Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note</title>
Constructs like this are hard to translate. For example in German one translation for vendor note would be Lieferantennotiz - so both words together. And I think in some other languages the adjective would go after the subject. @@ +5,5 @@
<body> [% INCLUDE 'header.inc' %]
+<div id="breadcrumbs"><a href="/cgi-bin/koha/mainpage.pl">Home</a> › <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisition</a> › <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid %]">[% booksellername|html %]</a> › <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno %]">Basket [% basketname|html %] ([% basketno %])</a> › Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note</div>
Same here. Sometimes being more verbose is good. @@ +11,5 @@
<div id="doc" class="yui-t7">
<div id="bd"> <div id="yui-main"> + <h1>Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note (order no. [% ordernumber %])</h1>
And here. @@ +16,3 @@
<form action="/cgi-bin/koha/acqui/modordernotes.pl" method="post"> <fieldset class="brief"> + <label for="ordernotes">Note:</label>
Should this be vendor or internal note? -- You are receiving this mail because: You are watching all bug changes.