https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36020 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #22 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Lisette Scheer from comment #20)
(In reply to Aleisha Amohia from comment #19)
Thanks Lisette. One of our libraries is happy to sponsor this so let me know if I can help you out. Maybe I can test when you're ready.
Aleisha
I've done some work on it again and realized what stopped me last time I tried: In RETURN_RECALLED_ITEM:
[%~ INCLUDE 'patron-title.inc' patron => borrower, no_title => 1, no_cardnumber => 1 ~%],
comes out Henry Acevedo , and I can't make the extra space go away
The same thing happens in PICKUP_RECALLED_ITEM
Edna Acosta ,
I think this might be a bigger issue than this bug. I'm attaching the patches, but I'm not sure it's ready for SO until we can get the extra space fixed.
There's no space in the last name, the patron-title.inc doesn't seem to have one either.
I spent a really silly amount of time trying to fix this, but couldn't. Then I tested with the booking confirmation notice and it looks like the space happens there too. So I think fixing that space would be out of the scope for this. So I'll just test your patch! -- You are receiving this mail because: You are watching all bug changes.