https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #47)
diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 502963f8d6..120fc28a88 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -84,6 +84,7 @@ if ( C4::Context->config('enable_plugins') ) {
my $biblionumber = $query->param('biblionumber'); $biblionumber = HTML::Entities::encode($biblionumber); +# FIXME Special case here my $record = GetMarcBiblio({ biblionumber => $biblionumber }); my $biblio = Koha::Biblios->find( $biblionumber );
Not completely clear what this FIXME is doing here now. I assume that it relates to the encode biblionumber thing. But if it does, it would be a better idea to put it on the same line. In this context it could be something with this change too..
Hum, wondering if this is still valid. Maybe it was just a note for myself when I was writing the first patch. detail.pl is a special case as it's the only place where we deal with invalid metadata but there is nothing to fix. (In reply to Marcel de Rooy from comment #48)
+my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line..
Indeed. No idea what's better. Do you think we need to pass another variable to the template (invalid_marc_record set to 1)? (In reply to Marcel de Rooy from comment #49)
+++ b/misc/maintenance/process_record_through_filter.pl +my $biblio = Koha::Biblios->find($ARGV[0]); +unless ( $biblio ) { + print "Biblio not found\n,"; + exit;
Looks a bit odd with that comma.
Looks like a typo. -- You are receiving this mail because: You are watching all bug changes.