[Bug 29697] New: Excessive use of StripNonXmlChars
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Bug ID: 29697 Summary: Excessive use of StripNonXmlChars Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org We are using C4::Charset::StripNonXmlChars from different places of the code to remove characters that should not be part of the MARC::XML Historically we were removing them every time we were fetching the record. However, since we are starting to use Koha::Biblio::Metadata ($biblio->metadata->record) to retrieve the xml stored in the biblio_metadata table, such characters will not be removed and a degraded view will be displayed on the bibliographic detail page (see bug 23846). We didn't get a lot of complains, and it's part of Koha since 19.05.05. Shouldn't we start to use $biblio->metadata->record where GetMarcBiblio is actually used? Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=29307 Depends on| |23846, 29690 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 [Bug 29690] Software error in details.pl when invalid MARCXML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Joubu, can you give an example for such characters that would be stripped? I want to help, but not sure about why it was added. Maybe it would be enough to do it on import/saving a record? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- ?(In reply to Katrin Fischer from comment #1)
Hi Joubu, can you give an example for such characters that would be stripped? I want to help, but not sure about why it was added.
Short answer? I don't know. The long answer is a rabbit hole. The regex is 391 $str =~ s/[^\x09\x0A\x0D\x{0020}-\x{D7FF}\x{E000}-\x{FFFD}\x{10000}-\x{10FFFF}]//g; And it's related to: https://en.wikipedia.org/wiki/Valid_characters_in_XML U+0009, U+000A, U+000D: these are the only C0 controls accepted in XML 1.0; U+0020–U+D7FF, U+E000–U+FFFD: this excludes some (not all) non-characters in the BMP (all surrogates, U+FFFE and U+FFFF are forbidden); U+10000–U+10FFFF: this includes all code points in supplementary planes, including non-characters. So, some weird characters/non-characters :)
Maybe it would be enough to do it on import/saving a record?
Yes, that's why I was suggesting actually with "Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls." Also note that Galen wrote, as the time: commit b549d7e1f1b7d518e16fa48af7360a38e8233fec Date: Fri Feb 8 16:35:18 2008 -0600 added StripNonXmlChars to C4::Charset "StripNonXmlChars should not necessarily be used, as it may be better to reject a file or record if it contains that kind of encoding error." We ended up using it from almost everywhere, inconsistently. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Sounds reasonable to move such checks to import only sections in the codebase (if they are needed at all?). And yes, a logical step would be going to ->record now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129757&action=edit Bug 29697: Special case - opac not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129758&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129759&action=edit Bug 29697: Remove GetHiddenItemnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129760&action=edit Bug 29697: Use flag embed_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 129761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129761&action=edit Bug 29697: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Excessive use of |Replace GetMarcBiblio |StripNonXmlChars |occurrences with | |$biblio->metadata->record --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I went "a bit" further, and completely replaced GetMarcBiblio with $biblio->metadata->record. The patches also remove GetHiddenItemnumbers (was called by the embed items code) and EmbedItemsInMarcBiblio. I first tried to create a Koha::MARC::Record class that would inherit from MARC::Record (and would have prevented the (not nice) class method call trick in Koha::Biblio::Metadata->record), but it's not trivial at all: From /usr/share/perl5/MARC/File/XML.pm 155 sub MARC::Record::new_from_xml { [...] 163 return( MARC::File::XML::decode( $xml, $enc, $format ) ); I think this is a move we must do ASAP, the diff is big but most of the changes are trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Bug 29697 depends on bug 29690, which changed state. Bug 29690 Summary: Software error in details.pl when invalid MARCXML https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29690 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #0)
Either we assume the MARC::XML that is stored is correct, or we need to add more StripNonXmlChars calls.
And, so? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29486 [Bug 29486] _koha_marc_update_bib_ids no longer needed for GetMarcBiblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- *** Bug 29307 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30008 [Bug 30008] Software error in details.pl when invalid MARCXML and showing component records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129757|0 |1 is obsolete| | Attachment #129758|0 |1 is obsolete| | Attachment #129759|0 |1 is obsolete| | Attachment #129760|0 |1 is obsolete| | Attachment #129761|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131868&action=edit Bug 29697: Special case - opac not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131869&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131870&action=edit Bug 29697: Remove GetHiddenItemnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131871&action=edit Bug 29697: Use flag embed_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131872&action=edit Bug 29697: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #18 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 131873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131873&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Ready for signoff! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can we move this one forward please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #20)
Can we move this one forward please?
Test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #22 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Nick Clemens from comment #21)
(In reply to Jonathan Druart from comment #20)
Can we move this one forward please?
Test plan?
No test plan, the diff it too big. What we need here are QA eyes :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #22)
(In reply to Nick Clemens from comment #21)
(In reply to Jonathan Druart from comment #20)
Can we move this one forward please?
Test plan?
No test plan, the diff it too big. What we need here are QA eyes :)
I doesn't apply. Please rebase and I'll test it right away. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131868|0 |1 is obsolete| | Attachment #131869|0 |1 is obsolete| | Attachment #131870|0 |1 is obsolete| | Attachment #131871|0 |1 is obsolete| | Attachment #131872|0 |1 is obsolete| | Attachment #131873|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134066&action=edit Bug 29697: Special case - opac not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134067&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #26 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134068&action=edit Bug 29697: Remove GetHiddenItemnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #27 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134069&action=edit Bug 29697: Use flag embed_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #28 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134070&action=edit Bug 29697: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #29 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 134071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134071&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I get sha1 issues trying to apply this.. more than happy to use gitlab branches if that's easier ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #30)
I get sha1 issues trying to apply this.. more than happy to use gitlab branches if that's easier ?
https://gitlab.com/joubu/Koha/-/commits/bug_29697 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #32 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Comment on attachment 134069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134069 Bug 29697: Use flag embed_items Review of attachment 134069: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29697&attachment=134069) ----------------------------------------------------------------- This is a great start, but I think we can golf this between us next cycle and come up with something considerably cleaner working towards efficiency ::: Koha/Biblio/Metadata.pm @@ +65,5 @@
+ biblionumber => $biblionumber, + itemnumbers => $itemnumbers, + opac => $opac + } + );
I think I'd rather see a distinct ->filtered_record() method as opposed to adding filtering functionality into the existing method..? @@ +67,5 @@
+ opac => $opac + } + ); + +Given a MARC::Record object containing a bib record,
You've made this a class method as well as an object method now I see.. the POD isn't entirely clear though.. we can work on that. @@ +72,5 @@
+modify it to include the items attached to it as 9XX +per the bib's MARC framework. +if $itemnumbers is defined, only specified itemnumbers are embedded. + +If $opac is true, then opac-relevant suppressions are included.
Actually.. as far as I can tell.. you're only doing OPAC filtering on the embedded items.. I'd love to have seem RecordProcessor used here and the actual record to get fully filtered using the framework display stuff.. @@ +170,5 @@
+ for my $itemnumber ( @itemnumbers ) { + my $item_marc = C4::Items::GetMarcItem( $biblionumber, $itemnumber ); + push @item_fields, $item_marc->field($itemtag); + } + $record->append_fields(@item_fields);
We should use Koha::Filter::EmbedItems here.. this is exactly what it was designed for I reckon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134066|0 |1 is obsolete| | Attachment #134067|0 |1 is obsolete| | Attachment #134068|0 |1 is obsolete| | Attachment #134069|0 |1 is obsolete| | Attachment #134070|0 |1 is obsolete| | Attachment #134071|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135574&action=edit Bug 29697: Special case - opac not needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #34 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135575&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #35 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135576&action=edit Bug 29697: Remove GetHiddenItemnumbers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #36 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135577&action=edit Bug 29697: Use flag embed_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #37 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135578&action=edit Bug 29697: Fix tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #38 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135579&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Martin Renvoize from comment #32)
Comment on attachment 134069 [details] [review] Bug 29697: Use flag embed_items
Review of attachment 134069 [details] [review]: -----------------------------------------------------------------
This is a great start, but I think we can golf this between us next cycle and come up with something considerably cleaner working towards efficiency
I would love to improve more, but the problem here will be to maintain the patches up-to-date. There will be easy rebases, but that will be a nightmare to keep up. What about "baby" steps instead? The diff is huge already. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #40 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135580&action=edit Bug 29697: (follow-up) Use flag embed_items -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Needs Signoff |BLOCKED --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Once saw this: t/db_dependent/Biblio.t .. 1/14 # Failed test 'expected warnings when adding too long LCCN' # at t/db_dependent/Biblio.t line 61. # didn't find a warning # expected to find warning: (?^u:Data too long for column 'lccn') # expected to find warning: (?^u:Data too long for column 'lccn') # Failed test 'AddBiblio returns undef for biblionumber if something went wrong' # at t/db_dependent/Biblio.t line 63. # got: '281' # expected: undef # Failed test 'AddBiblio returns undef for biblioitemnumber if something went wrong' # at t/db_dependent/Biblio.t line 65. # got: '243' # expected: undef # Failed test 'No biblio should have been added if something went wrong' # at t/db_dependent/Biblio.t line 68. # got: '3' # expected: '2' # Looks like you failed 4 tests of 5. t/db_dependent/Biblio.t .. 2/14 # Failed test 'AddBiblio' # at t/db_dependent/Biblio.t line 83. t/db_dependent/Biblio.t .. 9/14 # Looks like you failed 1 test of 14. t/db_dependent/Biblio.t .. Dubious, test returned 1 (wstat 256, 0x100) But I cannot reproduce it anymore with and without strict mode.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #43 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Subject: [PATCH 7/7] Bug 29697: (follow-up) Use flag embed_items - ? Koha::Biblios->find($id)->metadata->record({ embed_items => 1 }) + ? Koha::Biblios->find($record_id)->metadata->record({ embed_items => 1 }) This puzzles me. We always passed the flag, but it seems that we passed the wrong identifier? The commit name is weird? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- See also IRC - my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber }); + my $biblio = Koha::Biblios->find($biblionumber); + my $marcrecord = $biblio->metadata->record; This is a general pattern for most of the changes. Do you have performance figures ? In some cases we did NOT look up the biblio before! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #43)
Subject: [PATCH 7/7] Bug 29697: (follow-up) Use flag embed_items
- ? Koha::Biblios->find($id)->metadata->record({ embed_items => 1 }) + ? Koha::Biblios->find($record_id)->metadata->record({ embed_items => 1 })
This puzzles me. We always passed the flag, but it seems that we passed the wrong identifier? The commit name is weird?
Answered on IRC, this patch must be squashed with the other one with the same name, I was lazy yesterday. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #44)
See also IRC
- my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber }); + my $biblio = Koha::Biblios->find($biblionumber); + my $marcrecord = $biblio->metadata->record;
This is a general pattern for most of the changes. Do you have performance figures ?
In some cases we did NOT look up the biblio before!
Still from IRC 09:59 <@Joubu> Koha::Biblio::Metadatas->search({ biblionumber => 42 })->next 09:59 <@Joubu> then ->record 09:59 <@Joubu> You will assume that there is only one row (per record) in the table 10:01 < marcelr> assumptions are generally dangerous :) 10:01 <@Joubu> actually Koha::Biblio::Metadatas->find({ biblionumber => 42, format => 'marcxml', schema => C4::Context->preference('marcflavour') }) 10:01 <@Joubu> that's getting messy a bit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #47 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 502963f8d6..120fc28a88 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -84,6 +84,7 @@ if ( C4::Context->config('enable_plugins') ) { my $biblionumber = $query->param('biblionumber'); $biblionumber = HTML::Entities::encode($biblionumber); +# FIXME Special case here my $record = GetMarcBiblio({ biblionumber => $biblionumber }); my $biblio = Koha::Biblios->find( $biblionumber ); Not completely clear what this FIXME is doing here now. I assume that it relates to the encode biblionumber thing. But if it does, it would be a better idea to put it on the same line. In this context it could be something with this change too.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ ); Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- +++ b/misc/maintenance/process_record_through_filter.pl +my $biblio = Koha::Biblios->find($ARGV[0]); +unless ( $biblio ) { + print "Biblio not found\n,"; + exit; Looks a bit odd with that comma. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135574|0 |1 is obsolete| | --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135662&action=edit Bug 29697: Special case - opac not needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135575|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135663&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135576|0 |1 is obsolete| | --- Comment #52 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135664&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135577|0 |1 is obsolete| | --- Comment #53 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135665&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135578|0 |1 is obsolete| | --- Comment #54 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135666&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135579|0 |1 is obsolete| | --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 135667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135667&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #56 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Good work. See earlier comments. Most minor details, apart from the performance remark where we would call GetMarcBiblio in a loop without fetching the biblio object before. Hard call for the RM. This deserves a quick push but will interfere with a lot of other stuff that you want to backport.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a bit of post testing ;) Crash on opening cart Not a HASH reference at /usr/share/koha/opac/opac-basket.pl line 99 my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; 98: foreach my $item (@items) { 99: my $reserve_status = C4::Reserves::GetReserveStatus($item->{itemnumber}); Sub search returns a result set now, heh? So we need to iterate with ->next.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #58 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- opac/opac-detail.pl: if ( scalar @all_items >= 1 ) { @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) ->filter_by_visible_in_opac( { patron => $patron } ); opac/opac-tags.pl: my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #47)
diff --git a/catalogue/detail.pl b/catalogue/detail.pl index 502963f8d6..120fc28a88 100755 --- a/catalogue/detail.pl +++ b/catalogue/detail.pl @@ -84,6 +84,7 @@ if ( C4::Context->config('enable_plugins') ) {
my $biblionumber = $query->param('biblionumber'); $biblionumber = HTML::Entities::encode($biblionumber); +# FIXME Special case here my $record = GetMarcBiblio({ biblionumber => $biblionumber }); my $biblio = Koha::Biblios->find( $biblionumber );
Not completely clear what this FIXME is doing here now. I assume that it relates to the encode biblionumber thing. But if it does, it would be a better idea to put it on the same line. In this context it could be something with this change too..
Hum, wondering if this is still valid. Maybe it was just a note for myself when I was writing the first patch. detail.pl is a special case as it's the only place where we deal with invalid metadata but there is nothing to fix. (In reply to Marcel de Rooy from comment #48)
+my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line..
Indeed. No idea what's better. Do you think we need to pass another variable to the template (invalid_marc_record set to 1)? (In reply to Marcel de Rooy from comment #49)
+++ b/misc/maintenance/process_record_through_filter.pl +my $biblio = Koha::Biblios->find($ARGV[0]); +unless ( $biblio ) { + print "Biblio not found\n,"; + exit;
Looks a bit odd with that comma.
Looks like a typo. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #60 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #59)
(In reply to Marcel de Rooy from comment #48)
+my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line..
Indeed. No idea what's better. Do you think we need to pass another variable to the template (invalid_marc_record set to 1)?
Or just $@ // 'some great message' to keep it simple and not touch the template? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135662|0 |1 is obsolete| | Attachment #135663|0 |1 is obsolete| | Attachment #135664|0 |1 is obsolete| | Attachment #135665|0 |1 is obsolete| | Attachment #135666|0 |1 is obsolete| | Attachment #135667|0 |1 is obsolete| | --- Comment #61 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135668&action=edit Bug 29697: Special case - opac not needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #62 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135669&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD Amended patch: -# FIXME Special case here - print "Biblio not found\n,"; + print "Biblio not found\n"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #63 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135670&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: - my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; - foreach my $item (@items) { + my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; + foreach my $item (@$items) { - for my $itm (@items) { + for my $itm (@$items) { - $dat->{ITEM_RESULTS} = \@items; + $dat->{ITEM_RESULTS} = $items; - @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) - ->filter_by_visible_in_opac( { patron => $patron } ); + @items_to_show = Koha::Items->search( { itemnumber => [ map { $_->{itemnumber} } @all_items ] } ) + ->filter_by_visible_in_opac( { patron => $patron } )->as_list; - my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); + my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #64 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135671&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #65 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135672&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135673&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #60)
(In reply to Jonathan Druart from comment #59)
(In reply to Marcel de Rooy from comment #48)
+my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line..
Indeed. No idea what's better. Do you think we need to pass another variable to the template (invalid_marc_record set to 1)?
Or just $@ // 'some great message' to keep it simple and not touch the template?
An untranslatable message? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #68 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #67)
(In reply to Marcel de Rooy from comment #60)
(In reply to Jonathan Druart from comment #59)
(In reply to Marcel de Rooy from comment #48)
+my $invalid_marc_record = $@ || !$marc_record; +if ($invalid_marc_record) { + $template->param( decoding_error => $@ );
Theoretically $@ might be empty but there is not $marc_record. So you could provide a fallback for no error message in the last line..
Indeed. No idea what's better. Do you think we need to pass another variable to the template (invalid_marc_record set to 1)?
Or just $@ // 'some great message' to keep it simple and not touch the template?
An untranslatable message? :)
I would keep like that for now, and see if we need to improve later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #69 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marcel de Rooy from comment #44)
See also IRC
- my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber }); + my $biblio = Koha::Biblios->find($biblionumber); + my $marcrecord = $biblio->metadata->record;
This is a general pattern for most of the changes. Do you have performance figures ?
We should add `{ prefetch => [ 'metadata' ] }` on the biblio search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #70 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #69)
(In reply to Marcel de Rooy from comment #44)
See also IRC
- my $marcrecord = C4::Biblio::GetMarcBiblio({ biblionumber => $biblionumber }); + my $biblio = Koha::Biblios->find($biblionumber); + my $marcrecord = $biblio->metadata->record;
This is a general pattern for most of the changes. Do you have performance figures ?
We should add `{ prefetch => [ 'metadata' ] }` on the biblio search.
For a single record, I don't think it's better. See: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30169 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135668|0 |1 is obsolete| | Attachment #135669|0 |1 is obsolete| | Attachment #135670|0 |1 is obsolete| | Attachment #135671|0 |1 is obsolete| | Attachment #135672|0 |1 is obsolete| | Attachment #135673|0 |1 is obsolete| | --- Comment #71 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135797&action=edit Bug 29697: Special case - opac not needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #72 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135798&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD Amended patch: -# FIXME Special case here - print "Biblio not found\n,"; + print "Biblio not found\n"; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #73 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135799&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: - my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; - foreach my $item (@items) { + my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; + foreach my $item (@$items) { - for my $itm (@items) { + for my $itm (@$items) { - $dat->{ITEM_RESULTS} = \@items; + $dat->{ITEM_RESULTS} = $items; - @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) - ->filter_by_visible_in_opac( { patron => $patron } ); + @items_to_show = Koha::Items->search( { itemnumber => [ map { $_->{itemnumber} } @all_items ] } ) + ->filter_by_visible_in_opac( { patron => $patron } )->as_list; - my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); + my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #74 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135800&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #75 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135801&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #76 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135802&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #77 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Patches rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi Status|Passed QA |Failed QA --- Comment #78 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- This patch series breaks easy analytic link creation. To reproduce: 1. Enable EasyAnalyticalRecords syspref 2. Go to any biblio page in the staff interface 3. Click New -> Analyze items 4. On one of the items for the biblio click "Create analytics" 5. Notice you get the following error:
Can't use string ("Koha::Biblio") as a HASH ref while "strict refs" in use at /kohadevbox/koha/Koha/Object.pm line 830
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch, Joonas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #80 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- I found another problem, after this patch the zebra rebuild doesn't work: root@kohadevbox:koha(master)$ koha-shell kohadev $ perl misc/migration_tools/rebuild_zebra.pl -b error retrieving biblio 369 at misc/migration_tools/rebuild_zebra.pl line 689. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #81 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Joonas Kylmälä from comment #80)
I found another problem, after this patch the zebra rebuild doesn't work:
root@kohadevbox:koha(master)$ koha-shell kohadev $ perl misc/migration_tools/rebuild_zebra.pl -b error retrieving biblio 369 at misc/migration_tools/rebuild_zebra.pl line 689.
It is actually fixing a bug :) Biblio 369 has a bad MARCXML, and so code is expecting this warning (before and after this patch): eval { my $biblio = Koha::Biblios->find($record_number); $marc = $biblio->metadata->record({ embed_items => 1 }); }; if ($@ || !$marc) { # here we do warn since catching an exception # means that the bib was found but failed # to be parsed warn "error retrieving biblio $record_number"; return; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #82 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Joonas, I let you switch the status back to PQA if you agree with the previous comment. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #83 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I missed the other comment anyway, so not ready for PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135798|0 |1 is obsolete| | Attachment #135799|0 |1 is obsolete| | Attachment #135800|0 |1 is obsolete| | Attachment #135801|0 |1 is obsolete| | Attachment #135802|0 |1 is obsolete| | --- Comment #84 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135978&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD Amended patch: -# FIXME Special case here - print "Biblio not found\n,"; + print "Biblio not found\n"; - my $biblio = Koha::Biblio->find($hostbiblionumber); + my $biblio = Koha::Biblios->find($hostbiblionumber); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #85 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135979&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: - my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; - foreach my $item (@items) { + my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; + foreach my $item (@$items) { - for my $itm (@items) { + for my $itm (@$items) { - $dat->{ITEM_RESULTS} = \@items; + $dat->{ITEM_RESULTS} = $items; - @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) - ->filter_by_visible_in_opac( { patron => $patron } ); + @items_to_show = Koha::Items->search( { itemnumber => [ map { $_->{itemnumber} } @all_items ] } ) + ->filter_by_visible_in_opac( { patron => $patron } )->as_list; - my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); + my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #86 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135980&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #87 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135981&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #88 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135982&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #89 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #83)
I missed the other comment anyway, so not ready for PQA.
Fixed. Waiting for Joonas to approve comment 81. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #90 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #89)
(In reply to Jonathan Druart from comment #83)
I missed the other comment anyway, so not ready for PQA.
Fixed.
Waiting for Joonas to approve comment 81.
All good now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #91 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Doesn't apply anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135797|0 |1 is obsolete| | Attachment #135978|0 |1 is obsolete| | Attachment #135979|0 |1 is obsolete| | Attachment #135980|0 |1 is obsolete| | Attachment #135981|0 |1 is obsolete| | Attachment #135982|0 |1 is obsolete| | --- Comment #92 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137835&action=edit Bug 29697: Special case - opac not needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #93 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137836&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD Amended patch: -# FIXME Special case here - print "Biblio not found\n,"; + print "Biblio not found\n"; - my $biblio = Koha::Biblio->find($hostbiblionumber); + my $biblio = Koha::Biblios->find($hostbiblionumber); Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #94 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137837&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: - my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; - foreach my $item (@items) { + my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; + foreach my $item (@$items) { - for my $itm (@items) { + for my $itm (@$items) { - $dat->{ITEM_RESULTS} = \@items; + $dat->{ITEM_RESULTS} = $items; - @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) - ->filter_by_visible_in_opac( { patron => $patron } ); + @items_to_show = Koha::Items->search( { itemnumber => [ map { $_->{itemnumber} } @all_items ] } ) + ->filter_by_visible_in_opac( { patron => $patron } )->as_list; - my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); + my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #95 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137838&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #96 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137839&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #97 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137840&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #98 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #99 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like ktd is failing to setup if those patches are applied and KOHA_ELASTICSEARCH is set to 1. koha_1 | [942] Indexing biblios koha_1 | Invalid data, cannot decode metadata object (biblio_metadata.id=368, biblionumber=369, format=marcxml, schema=MARC21, decoding_error=':8: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="001">00aD000015937</controlfield> koha_1 | ^ koha_1 | :9: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="004">00satmrnu0</controlfield> koha_1 | ^ koha_1 | :9: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="004">00satmrnu0</controlfield> koha_1 | ^ koha_1 | :9: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="004">00satmrnu0</controlfield> koha_1 | ^ koha_1 | :9: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="004">00satmrnu0</controlfield> koha_1 | ^ koha_1 | :10: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="008">00ar19881981bdkldan</controlfield> koha_1 | ^ koha_1 | :10: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="008">00ar19881981bdkldan</controlfield> koha_1 | ^ koha_1 | :10: parser error : PCDATA invalid Char value 31 koha_1 | <controlfield tag="008">00ar19881981bdkldan</controlfield> db_1 | 2022-07-19 7:27:59 13 [Warning] Aborted connection 13 to db: 'koha_kohadev' user: 'koha_kohadev' host: '172.24.0.6' (Got an error reading communication packets) koha_1 | ^')koha_koha_1 exited with code 1 May need to be investigated before push. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #100 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #99)
May need to be investigated before push.
In comment 81 the cause was deemed to be an invalid MARC record. However, as this breaks the development setup, and the automated test server / jenkins I presume, then to me this is FQA. We need to provide a patch along with this change that removes the invalid MARC record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #101 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Joonas Kylmälä from comment #100)
(In reply to Jonathan Druart from comment #99)
May need to be investigated before push.
In comment 81 the cause was deemed to be an invalid MARC record. However, as this breaks the development setup, and the automated test server / jenkins I presume, then to me this is FQA. We need to provide a patch along with this change that removes the invalid MARC record.
This is actually a behavior change we need to address on this patchset. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #102 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137894&action=edit Bug 29697: Don't crash ES reindex if a record is wrong We don't want rebuild_elasticsearch.pl to crash if a record is wrong (also fix ktd setup). Note that now the script will output an error for the problematic record, which is certainly the expected behaviour as we are doing it already for authority records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #103 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last patch would benefit from a QA review but I don't want to set the status back to NQA and lose it for weeks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137835|0 |1 is obsolete| | --- Comment #104 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137918&action=edit Bug 29697: Special case - opac not needed Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137836|0 |1 is obsolete| | --- Comment #105 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137919&action=edit Bug 29697: Replace GetMarcBiblio occurrences with $biblio->metadata->record Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD Amended patch: -# FIXME Special case here - print "Biblio not found\n,"; + print "Biblio not found\n"; - my $biblio = Koha::Biblio->find($hostbiblionumber); + my $biblio = Koha::Biblios->find($hostbiblionumber); Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137837|0 |1 is obsolete| | --- Comment #106 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137920&action=edit Bug 29697: Remove GetHiddenItemnumbers Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> JD amended patch: - my @items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; - foreach my $item (@items) { + my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; + foreach my $item (@$items) { - for my $itm (@items) { + for my $itm (@$items) { - $dat->{ITEM_RESULTS} = \@items; + $dat->{ITEM_RESULTS} = $items; - @items_to_show = Koha::Items->search( { itemnumbers => [ map { $_->{itemnumber} } @all_items ] } ) - ->filter_by_visible_in_opac( { patron => $patron } ); + @items_to_show = Koha::Items->search( { itemnumber => [ map { $_->{itemnumber} } @all_items ] } ) + ->filter_by_visible_in_opac( { patron => $patron } )->as_list; - my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron }); + my @items_to_show = $items->filter_by_visible_in_opac({ opac => 1, patron => $patron })->as_list; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137838|0 |1 is obsolete| | --- Comment #107 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137921&action=edit Bug 29697: Use flag embed_items Includes: Bug 29697: (follow-up) Use flag embed_items Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137839|0 |1 is obsolete| | --- Comment #108 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137922&action=edit Bug 29697: Fix tests Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137840|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137923&action=edit Bug 29697: Deal with the degraded view in detail.pl In detail.pl we must provide a degraded view with an error message about invalid MARC::Record. We are then forced to reproduce the GetMarcBiblio behaviour and call StripNonXmlChars on the MARC::XML Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Rebased-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137894|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 137924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137924&action=edit Bug 29697: Don't crash ES reindex if a record is wrong We don't want rebuild_elasticsearch.pl to crash if a record is wrong (also fix ktd setup). Note that now the script will output an error for the problematic record, which is certainly the expected behaviour as we are doing it already for authority records. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #111 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137924|0 |1 is obsolete| | --- Comment #112 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 137948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137948&action=edit Bug 29697: Don't crash ES reindex if a record is wrong We don't want rebuild_elasticsearch.pl to crash if a record is wrong (also fix ktd setup). Note that now the script will output an error for the problematic record, which is certainly the expected behaviour as we are doing it already for authority records. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #113 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Jonathan Druart from comment #103)
Last patch would benefit from a QA review but I don't want to set the status back to NQA and lose it for weeks.
Looks good to me, handing off to the release manager. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #114 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138057&action=edit Bug 29697: (follow-up) Indexing a deleted record is not expected to crash Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #115 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31224 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31224 [Bug 31224] Koha::Biblio::Metadata->record should use the EmbedItems filter -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23247 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 [Bug 23247] Use EmbedItems in opac-MARCdetail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #116 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138076&action=edit Bug 29697: Replace some missing occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138076|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138077&action=edit Bug 29697: Replace some missing occurrences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #118 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138078&action=edit Bug 29697: Fix t/db_dependent/Exporter/Record.t Not sure about the warn, we shouldn't need it as we are raising an exception. But better (for now) than introducing regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #119 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138079&action=edit Bug 29697: Reintroduce wrongly removed import # Failed test 'No tests run for subtest "CancelHold"' # at t/db_dependent/ILSDI_Services.t line 806. Undefined subroutine &C4::ILSDI::Services::CanReserveBeCanceledFromOpac called at /kohadevbox/koha/C4/ILSDI/Services.pm line 941. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #120 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138080&action=edit Bug 29697: Fix t/Search.t # Failed test 'No tests run for subtest "searchResults PassItemMarcToXSLT test"' # at t/Search.t line 208. Undefined subroutine &C4::Biblio::EmbedItemsInMarcBiblio called at t/Search.t line 194. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #121 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138081&action=edit Bug 29697: Fix t/db_dependent/Search.t FIXME This does not seem correct. I bet it was coming from a problem in our test data but apparently all the items in t/db_dependent/data/marc21/zebraexport/biblio/exported_records have a 952$9 I don't fully understand why we reach this code without itemnumber. Not sure this is the correct fix -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #122 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138089&action=edit Bug 29697: tracklinks should not explode on invalid marc record Caught by t/db_dependent/www/regressions.t # Failed test '404 for itemnumber containing different URI' # at t/db_dependent/www/regressions.t line 124. # got: '500' # expected: '404' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 126. # got: '500' # expected: '302' # Failed test '404 for itemnumber containing different URI' # at t/db_dependent/www/regressions.t line 139. # got: '500' # expected: '404' # Failed test '302 for itemnumber with matching URI' # at t/db_dependent/www/regressions.t line 141. # got: '500' # expected: '302' # Looks like you failed 4 tests of 36. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138081|0 |1 is obsolete| | --- Comment #123 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 138090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138090&action=edit Bug 29697: Fix t/db_dependent/Search.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #124 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #123)
Created attachment 138090 [details] [review] Bug 29697: Fix t/db_dependent/Search.t
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I have looked at the wrong data apparently, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #125 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-ups pushed to master. We owe you some beers Jonathan. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #126 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #125)
Follow-ups pushed to master. We owe you some beers Jonathan. Thanks!
I broke, I fix ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #127 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This broke t/db_dependent/Search.t for non-LIGHT_RUN (Koha_Master). The data from koha-misc4dev are not inserted and there are no items in the DB. But those tests expect items with itemnumber=1 and 2. t/db_dependent/Search.t .. # Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 475. # got: 'false' # expected: 'true' Use of uninitialized value $fw in concatenation (.) or string at t/db_dependent/Search.t line 494. Use of uninitialized value $fw in concatenation (.) or string at t/db_dependent/Search.t line 503. # Failed test ''notforloancount' == 2 (Bug 12419)' # at t/db_dependent/Search.t line 758. # got: '0' # expected: '2' # Looks like you failed 2 tests of 92. t/db_dependent/Search.t .. 1/3 # Failed test 'MARC21 + DOM' # at t/db_dependent/Search.t line 914. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #128 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 138804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138804&action=edit Bug 29697: WIP - fix t/db_dependent/Search.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #129 from Jonathan Druart <jonathan.druart+koha@gmail.com> ---
From this change in C4::Search::searchResults
- # OPAC hidden items + # OPAC hidden items if ($is_opac) { - # hidden because lost - if ($hidelostitems && $item->{itemlost}) { + # hidden based on OpacHiddenItems syspref or because lost + my $hi = Koha::Items->search( { itemnumber => $item->{itemnumber} } ) + ->filter_by_visible_in_opac({ patron => $search_context->{patron} }); + unless ( $hi->count ) { push @hiddenitems, $item->{itemnumber}; $hideatopac_count++; next; } - # hidden based on OpacHiddenItems syspref - my @hi = C4::Items::GetHiddenItemnumbers({ items=> [ $item ], borcat => $search_context->{category} }); - if (scalar @hi) { - push @hiddenitems, @hi; - $hideatopac_count++; - next; - } } We are actually dealing with lost items HERE, when we were only dealing with "OpacHiddenItems" only prior to this change, and lost items where handled later. Is that a problem? I don't think so. Should we expect side-effects? The previous patch fixes the first error. The other one is still failing as we are expecting notforloan_count to be set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #130 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The following change should fix the second failure but it does not. diff --git a/C4/Search.pm b/C4/Search.pm index 75da21a4e6a..21b33d85fe9 100644 --- a/C4/Search.pm +++ b/C4/Search.pm @@ -1828,6 +1828,7 @@ sub searchResults { ->filter_by_visible_in_opac({ patron => $search_context->{patron} }); unless ( $hi->count ) { push @hiddenitems, $item->{itemnumber}; + $notforloan_count++; $hideatopac_count++; next; We are getting # got: '3' # expected: '2' Help needed! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #131 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (those tests are a mess!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #132 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139127&action=edit Bug 29697: (follow-up) Check against itemnumbers for visibility No items are shoing on the opac because we are comparing the itemnumber to an object This patch simplies check against the itemnumber Note: With this the inclusion of host_items it still broken as they won't be in the visible items list Bug 31313 will fix this completely -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139127|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Andrew Nugged <nugged@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged@gmail.com --- Comment #133 from Andrew Nugged <nugged@gmail.com> --- Some remnants in the master branch (I am trying to combine (oh that's the challenge!) these changes with Bug 20447, that's why giving some parallel feedback): I see this left: C4/Biblio.pm: 56: EmbedItemsInMarcBiblio I think that line is the only one that we have across all codebase, so just the remnants. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #134 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 138804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138804 Bug 29697: WIP - fix t/db_dependent/Search.t Review of attachment 138804: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=29697&attachment=138804) ----------------------------------------------------------------- ::: t/db_dependent/Search.t @@ +472,5 @@
+ Koha::Database::flush_schema_cache(); + fixtures_ok [ + Item => [ + [qw( itemnumber )], + [ 1 ],
Getting picky but... This is not entirely correct. When you look at data/marc21/zebraexport/large_biblio/exported_records.xml you see there are 4 items defined on that record. The itemnumbers for them are 123, 124, 125 and 126. Two of them are set to be not for loan (i.e. $7 1 in this case). That's why the test is expecting exactly 2 in the notforloancount return value for searchResults. This mock on the resultset 'fixes' the tests only because the ->count is returning 2, so unrelated to the actual itemnumbers. I think we should just do some simpler mocking. Will give it a try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #135 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140007&action=edit Bug 29697: (QA follow-up) Make tests less fragile This patch makes the tests less fragile to existing data. It does so by making sure that when checking if the item would be hidden by OpacHiddenItems and lost status, the item is not skipped, and thus the notforloan value, as retrieved from the search engine is picked for the notforloan_count calculation. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 --- Comment #136 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140008&action=edit Bug 29697: (QA follow-up) Remove useless warning Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138804|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Needs documenting CC| |lucas@bywatersolutions.com --- Comment #137 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x series -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Keywords|additional_work_needed | Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32798 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32798 [Bug 32798] build_oai_sets.pl passes wrong parameter to Koha::Biblio::Metadata->record -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33347 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33347 [Bug 33347] MARC preview broken when applying MARC modification template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33069 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33069 [Bug 33069] File download from list in OPAC gives error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34014 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34014 [Bug 34014] There is no way to fix records with broken MARCXML -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33270 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33270 [Bug 33270] OAI-PMH should not die on record errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34549 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34549 [Bug 34549] The cataloguing editor allows you to input invalid data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35490 [Bug 35490] Remove GetMarcItem from C4::Biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24424 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24424 [Bug 24424] Advanced editor - interface hangs as "Loading" when given an invalid bib number -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36834 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36834 [Bug 36834] (Bug 29697 follow-up) Koha explodes when trying to open in Labeled MARC view a bibliographic record with an invalid biblionumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37376 [Bug 37376] Item data added to incorrect OPAC export formats -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29697 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |38406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38406 [Bug 38406] Item fields should not be stored on the DB -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org