https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33104 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #30 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Katrin Fischer from comment #28)
1) I18N
ol.append(`<li><button class="btn btn-default" onclick="remove_interface(${i});"><i class="fa fa-trash"></i> Delete interface</li>`);
Fixed.
2) Vendor search
* I am seeing a strange effect there: the "My Vendor" vendor with booksellerid=1 is showing up twice after applying the patch. Switching back to master makes the doubled up vendor go away.
Fixed on bug 33103.
3) Vendor edit form
* Adding the email validation to the email field would be good.
Done in "Add email validation"
* If you add multiple interfaces, the type pull down empties/resets to "" for all interfaces when clicking on "Add another interface". This also happens to the already saved interfaces.
Done in "Prevent 'Type' to be cleared
4) Vendor details page
* The new information is not displaying correctly (see screenshot). I did a yarn build and reset_all, nothing would fix. Background is wrong and also the line height doesn't match with the other sections on the page.
What are you suggesting? I think this is nicer than the others :D https://snipboard.io/Iwetbx.jpg Contacts are missing padding, contracts are in a table (what we don't want here, it won't be easy to read). -- You are receiving this mail because: You are watching all bug changes.