https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 140412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140412 Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Review of attachment 140412: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28553&attachment=140412) ----------------------------------------------------------------- The patch title and patch note don't accurately describe the patch. They should say something like the following: Bug 28553: Add SMS notices for auto renew notices This patch adds support for SMS notices to the automatic_renewals.pl cronjob. Both digest and non-digest messages are supported. ::: misc/cronjobs/automatic_renewals.pl @@ +234,5 @@
); + for my $issue ( @{ $report{$borrowernumber} } ) { + my $item = $issue->item; + # Force sending of email and only email if pref is set to "cron" + my @transports = $send_notices_pref eq 'preferences' ? keys %{ $borrower_preferences->{'transports'} } : 'sms';
This is wrong. Instead of 'sms', it should be 'email'. -- You are receiving this mail because: You are watching all bug changes.