[Bug 28553] New: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Bug ID: 28553 Summary: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. We need to either teach the cron to send SMS notices or teach the messaging prefs to not allow you to select SMS. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=30355 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Blocks| |30355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30355 [Bug 30355] SMS auto renew digest notices are only generated if patron is also set to receive email -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 137830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=137830&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1) Set a patron to recieve auto-renewals via SMS, leave digest mode disabled. Ensure no other transports are enabled either. 2) Auto-renew some items 3) Note the SMS auto-renewal notice was generated! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Rachael <rachael.laritz@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rachael.laritz@inlibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Rachael <rachael.laritz@inlibro.com> --- Under NOTICES, nothing shows that an SMS was sent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #137830|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139021&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1 - Set pref AutoRenewalNotices - 'according to patron messaging preferences' 2 - Set circ rule with: Loan period: 5 days No renewal before: 5 AutoRenewal: Yes Renewals allowed: 5 3 - Set SMS Send driver to Email 4 - Find a patron and set them to receive auto renewal notices via SMS and no other transport 5 - Provide a proivder and sms number for the patron 6 - Checkout an item to the patron, set due date to yesterday 7 - Run auto renewals: perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 8 - Item renewed, no message sent 9 - Check in item, checkout again due yesterday 10 - Apply patch 11 - Browse to Tools->notices and slips 12 - Edit AUTO_RENEWALS and AUTO_RENEWALS_DIGEST to copy email template to sms and add a title 13 - perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 14 - Item renewed, confirm patron has a notice in their account 15 - Check the digest option, check in item, checkout again as due, repeat cronjob and note digest notic 16 - sign off https://bugs.koha-community.org/show_bug.cgi?id=30355 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139021|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 140412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140412&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1 - Set pref AutoRenewalNotices - 'according to patron messaging preferences' 2 - Set circ rule with: Loan period: 5 days No renewal before: 5 AutoRenewal: Yes Renewals allowed: 5 3 - Set SMS Send driver to Email 4 - Find a patron and set them to receive auto renewal notices via SMS and no other transport 5 - Provide a proivder and sms number for the patron 6 - Checkout an item to the patron, set due date to yesterday 7 - Run auto renewals: perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 8 - Item renewed, no message sent 9 - Check in item, checkout again due yesterday 10 - Apply patch 11 - Browse to Tools->notices and slips 12 - Edit AUTO_RENEWALS and AUTO_RENEWALS_DIGEST to copy email template to sms and add a title 13 - perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 14 - Item renewed, confirm patron has a notice in their account 15 - Check the digest option, check in item, checkout again as due, repeat cronjob and note digest notic 16 - sign off https://bugs.koha-community.org/show_bug.cgi?id=30355 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Note that for the AUTO_RENEWALS notice, this message appears for the Email notice, before the last updated date: Template Toolkit error: undef error - : filter not found This message appears before the patch is applied - I'm not sure what is causing this, as it doesn't appear for a sample of other notices I checked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Nind from comment #5)
Note that for the AUTO_RENEWALS notice, this message appears for the Email notice, before the last updated date:
Template Toolkit error: undef error - : filter not found
This message appears before the patch is applied - I'm not sure what is causing this, as it doesn't appear for a sample of other notices I checked.
My guess would be due to the following line: The following item, [% biblio.title %], has correctly been renewed and is now due on [% checkout.date_due | $KohaDates as_due_date => 1 %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 140412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140412 Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Review of attachment 140412: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=28553&attachment=140412) ----------------------------------------------------------------- The patch title and patch note don't accurately describe the patch. They should say something like the following: Bug 28553: Add SMS notices for auto renew notices This patch adds support for SMS notices to the automatic_renewals.pl cronjob. Both digest and non-digest messages are supported. ::: misc/cronjobs/automatic_renewals.pl @@ +234,5 @@
); + for my $issue ( @{ $report{$borrowernumber} } ) { + my $item = $issue->item; + # Force sending of email and only email if pref is set to "cron" + my @transports = $send_notices_pref eq 'preferences' ? keys %{ $borrower_preferences->{'transports'} } : 'sms';
This is wrong. Instead of 'sms', it should be 'email'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- *** Bug 30355 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
::: misc/cronjobs/automatic_renewals.pl @@ +234,5 @@
); + for my $issue ( @{ $report{$borrowernumber} } ) { + my $item = $issue->item; + # Force sending of email and only email if pref is set to "cron" + my @transports = $send_notices_pref eq 'preferences' ? keys %{ $borrower_preferences->{'transports'} } : 'sms';
This is wrong. Instead of 'sms', it should be 'email'.
I'll shortly attach a follow-up patch to fix this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140412|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 140510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140510&action=edit Bug 28553: Patrons can be set to receive auto_renew notices as SMS, but Koha does not generate them Following bug 18532, one can set a patron's messaging prefs to deliver an auto-renew notice via SMS. However, the auto_renewals cron only knows how to generate email notices. We should not allow the selection of non-functional transport types. Test Plan: 1 - Set pref AutoRenewalNotices - 'according to patron messaging preferences' 2 - Set circ rule with: Loan period: 5 days No renewal before: 5 AutoRenewal: Yes Renewals allowed: 5 3 - Set SMS Send driver to Email 4 - Find a patron and set them to receive auto renewal notices via SMS and no other transport 5 - Provide a proivder and sms number for the patron 6 - Checkout an item to the patron, set due date to yesterday 7 - Run auto renewals: perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 8 - Item renewed, no message sent 9 - Check in item, checkout again due yesterday 10 - Apply patch 11 - Browse to Tools->notices and slips 12 - Edit AUTO_RENEWALS and AUTO_RENEWALS_DIGEST to copy email template to sms and add a title 13 - perl misc/cronjobs/automatic_renewals.pl -v --send-notices -c 14 - Item renewed, confirm patron has a notice in their account 15 - Check the digest option, check in item, checkout again as due, repeat cronjob and note digest notic 16 - sign off https://bugs.koha-community.org/show_bug.cgi?id=30355 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #11 from David Cook <dcook@prosentient.com.au> --- Created attachment 140511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140511&action=edit Bug 28553: [QA followup] default to auto renew email when cron switched used This patch defaults to using "email" rather than "sms" notices when AutoRenewalNotices is set to use the --send-notices cron switch Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Despite my comments about the title/note on the first patch, which would probably ordinarily be a QA fail, I think that the patch is important enough to still Pass QA. Going to leave it up to the RM to decide if it needs to be rewritten, or to rewrite it, or to let it go. Thanks for the patch, Bywater folk! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 --- Comment #15 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18532 CC| |victor@tuxayo.net --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- I guess this depends on bug 18532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 [Bug 18532] Messaging preferences for auto renewals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28553 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED Version(s)|22.11.00, 22.05.07, |22.11.00, 22.05.07, released in|21.11.14 |21.11.14, 21.05.21 --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for the upcoming release (21.05.21) Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org