https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #340 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #336)
Patches still apply with a tiny rebase :)
I've added the rebased patch set with 2 tiny follow-ups, but have some issues I am struggling with:
1) Tests don't pass and there is a warning that might relate to some rebase issue:
kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. Subroutine libraries_where_can_see_patrons redefined at /kohadevbox/koha/Koha/Patron.pm line 1610.
Should be fixed with this latest followup!
2) Permission descriptions
We now have:
* Edit any item. If not set the logged in user can only edit items whose home library matches the logged in library. (edit_any_item) * Edit items (edit_items)
I think we need to actually rephrase Edit items if the note on edit_any_item rings true. Also, we need to factor in the library group feature somehow...
Edit all items with user's home library and from libaries within the edit item library group (edit_items)
It makes me realize I am not super sure yet how the library groups and permissions work together, can you please check and maybe explain a little more?
I've added a followup to update those descriptions. I think the new ones are better, but if anyone has more improvements they would be welcome!
3) Library groups
<li>Limit item editing for librarians outside of this group.</li>
Maybe this would be clearer as:
<li>Limit item editing to librarians inside of this group</li>
But I might be misunderstanding something?
That sounds good to me! -- You are receiving this mail because: You are watching all bug changes.