https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- 1) There is an extra closing bracket in view_holdsqueue.tt preventing the table from rendering at all, had to make the following to test further: @@ -392,7 +392,6 @@ if (!row.patron || !row.patron.category) return ""; return (row.patron.category.name || "").escapeHtml() + " (" + (row.patron.category_id || "").escapeHtml() + ")"; }, - }, }, { 2) HidePatronName sys pref support is gone. Test before and after applying patches, with HidePatronName enabled and disabled. Notice that patron name is displayed in accordance to HidePatronName before the patches, but always shows after the patches, completely ignoring the sys pref. 3) Before, one of the following labels would show on the barcode column: - Only item: <barcode> - <barcode> or any item from item group - <barcode> or any available But now, the item group case (2nd) is gone entirely. To test, apply only the sample data script patch + my follow-up and run: cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Ensure 'or any item from item group' exists on the holds queue page when loading all 40 for All libraries. Apply all patches, run: $ yarn api:bundle $ koha-plack --restart kohadev. Notice the 'or any item from item group' is gone. 4) The old table had per-column text filter inputs in the header row — those are gone, replaced by sidebar-only filtering. Loss of functionality. Not major but worth flagging. 5) encodeURIComponent on the mailto href will encode @ to %40, producing broken mailto links. Hover over any email address on the patron column. Notice the produced mailto link is e.g. 'patron1%40example.com'. -- You are receiving this mail because: You are watching all bug changes.