[Bug 42503] New: Optimize retrieval and display of the holds queue
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Bug ID: 42503 Summary: Optimize retrieval and display of the holds queue Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, lisette@bywatersolutions.com, tomascohen@gmail.com The holds queue page (view_holdsqueue.pl) should be reworked to fetch data via API to improve performance for large systems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198918&action=edit [DO NOT PUSH] Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198919&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). New files: - Koha/REST/V1/Holds/Queue.pm: controller with list method - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Changes: - Koha/Hold/HoldsQueueItem.pm: adds to_api_mapping - api/v1/swagger/swagger.yaml: registers path and definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: biblio, item, item+strings, patron, patron.notice_email_address. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove xt/api.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198920&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198919|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #4 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198921&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). New files: - Koha/REST/V1/Holds/Queue.pm: controller with list method - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Changes: - Koha/Hold/HoldsQueueItem.pm: adds to_api_mapping - api/v1/swagger/swagger.yaml: registers path and definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: biblio, item, item+strings, patron, patron.notice_email_address. Test plan: 1. Apply patch 2. Run: $ ktd --shell k$ prove xt/api.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #5 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 198922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198922&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Optimize retrieval and |Render the holds queue |display of the holds queue |using the REST API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Alex Carver [Acerock7] <alex@rcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alex@rcls.org --- Comment #6 from Alex Carver [Acerock7] <alex@rcls.org> --- I'm running into trouble at step 4. After populating the holds queue with sample_holds_queue.pl, navigating to the holds queue and submitting the filters form generates a popup error: Something went wrong with loading the table. 404: Not Found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #7 from Alex Carver [Acerock7] <alex@rcls.org> --- Running yarn build after step four gets me further in the test plan. I am now failing at step 8. Attempting to sort on the following columns generates a 500 error: Publication Details Patron Patron Category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198918|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198921|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198922|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199145&action=edit [DO NOT PUSH] Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199146&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #10 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199147&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #11 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199148&action=edit Bug 42503: (follow-up) Cache library names in strings_map The original holds queue page resolved library names using Branches.GetName() per row per field in the template, resulting in individual DB queries for each cell. The initial API implementation replicated this with Koha::Libraries->find() per field. This patch uses the shared 'libraries:name' cache (the same one populated by C4::Biblio::GetAuthorisedValueDesc) so library name resolution is a single DB query regardless of result set size. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42607 --- Comment #12 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi! (In reply to Alex Carver [Acerock7] from comment #7)
Running yarn build after step four gets me further in the test plan. I am
I amended the test plan to include the missing step. Thanks!
now failing at step 8. Attempting to sort on the following columns generates a 500 error:
Publication Details Patron Patron Category
Solved with the submitted patchset. I also included a nice optimization. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42607 [Bug 42607] Holds queue: Remove intermediate filter page now that results are API-driven -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42609 Attachment #199146|0 |1 is obsolete| | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42609 [Bug 42609] Koha::Patron->strings_map triggers per-row DB queries for library and category -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199147|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199148|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #13 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199160&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #14 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199161&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #15 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199162&action=edit Bug 42503: (follow-up) Sort libraries and category by name Sorting on library and category columns was ordering by code values (branchcode, categorycode) rather than human-readable names. This patch: - Adds item.holding_library, item.home_library, and pickup_library embeds so the library names are JOINed and sortable - Adds patron.category and patron.library embeds for the same reason - Adds a pickup_library relationship alias to TmpHoldsqueue - Changes data fields to point to the .name columns for sorting Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #16 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- I've been testing the table side-by-side with the current one, and noticed my implementation was sorting by code in some fields like patron category or pickup library (and even home/holding library code, which were hidden in my setup). Because of that, I reworked how things are retrieved/embedded using the API and ended up not needing the `strings_map` at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emmi.takkinen@koha-suomi.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk, | |pedro.amorim@openfifth.co.u | |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- 1) There is an extra closing bracket in view_holdsqueue.tt preventing the table from rendering at all, had to make the following to test further: @@ -392,7 +392,6 @@ if (!row.patron || !row.patron.category) return ""; return (row.patron.category.name || "").escapeHtml() + " (" + (row.patron.category_id || "").escapeHtml() + ")"; }, - }, }, { 2) HidePatronName sys pref support is gone. Test before and after applying patches, with HidePatronName enabled and disabled. Notice that patron name is displayed in accordance to HidePatronName before the patches, but always shows after the patches, completely ignoring the sys pref. 3) Before, one of the following labels would show on the barcode column: - Only item: <barcode> - <barcode> or any item from item group - <barcode> or any available But now, the item group case (2nd) is gone entirely. To test, apply only the sample data script patch + my follow-up and run: cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Ensure 'or any item from item group' exists on the holds queue page when loading all 40 for All libraries. Apply all patches, run: $ yarn api:bundle $ koha-plack --restart kohadev. Notice the 'or any item from item group' is gone. 4) The old table had per-column text filter inputs in the header row — those are gone, replaced by sidebar-only filtering. Loss of functionality. Not major but worth flagging. 5) encodeURIComponent on the mailto href will encode @ to %40, producing broken mailto links. Hover over any email address on the patron column. Notice the produced mailto link is e.g. 'patron1%40example.com'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199251&action=edit [DO NOT PUSH] Bug 42503: Add item groups to population script Patch from commit e6df817 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |pedro.amorim@openfifth.co.u |y.org |k -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #19 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi Pedro! Thanks for the valuable feedback! (In reply to Pedro Amorim (ammopt) from comment #17)
1) There is an extra closing bracket in view_holdsqueue.tt preventing the table from rendering at all, had to make the following to test further:
@@ -392,7 +392,6 @@ if (!row.patron || !row.patron.category) return ""; return (row.patron.category.name || "").escapeHtml() + " (" + (row.patron.category_id || "").escapeHtml() + ")"; }, - }, }, {
I think I messed up with several submissions because of submitting from the wrong worktree! Thanks for pointing this out. I'll take a closer look at my workflow! I've been testing this and didn't notice it.
2) HidePatronName sys pref support is gone. Test before and after applying patches, with HidePatronName enabled and disabled. Notice that patron name is displayed in accordance to HidePatronName before the patches, but always shows after the patches, completely ignoring the sys pref.
I didn't really think about the syspref. This will be very tricky.
3) Before, one of the following labels would show on the barcode column: - Only item: <barcode> - <barcode> or any item from item group - <barcode> or any available
But now, the item group case (2nd) is gone entirely.
To test, apply only the sample data script patch + my follow-up and run: cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl
Ensure 'or any item from item group' exists on the holds queue page when loading all 40 for All libraries. Apply all patches, run: $ yarn api:bundle $ koha-plack --restart kohadev.
Notice the 'or any item from item group' is gone.
Thanks, I'll add the relevant embeds for this.
4) The old table had per-column text filter inputs in the header row — those are gone, replaced by sidebar-only filtering. Loss of functionality. Not major but worth flagging.
Will add it back, thanks!
5) encodeURIComponent on the mailto href will encode @ to %40, producing broken mailto links. Hover over any email address on the patron column. Notice the produced mailto link is e.g. 'patron1%40example.com'.
Hm, taking a look! Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199145|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199160|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199161|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199162|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199251|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #20 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199347&action=edit Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #21 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199348&action=edit Bug 42503: Add item groups to population script Patch from commit 3755040 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #22 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199349&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #23 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199350&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #24 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199351&action=edit Bug 42503: (follow-up) Respect HidePatronName system preference The old server-rendered template hid patron name, phone and email when HidePatronName was enabled, showing only the cardnumber. This patch redacts patron personal fields server-side in the controller when HidePatronName is set, keeping only patron_id, cardnumber, category_id and the embedded category. The JS falls back to displaying the cardnumber when surname is absent. Superlibrarians are exempt from the redaction as they have unrestricted access to patron data. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #25 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 199385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199385&action=edit Bug 42503: (follow-up) Restore per-column text filters The old table had per-column text filter inputs in the header row. These were lost in the conversion to the API-driven DataTable. Pass add_filters to kohaTable so it auto-generates filter inputs for all searchable columns. Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #26 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #17)
1) There is an extra closing bracket in view_holdsqueue.tt preventing the table from rendering at all, had to make the following to test further:
Solved!
2) HidePatronName sys pref support is gone. Test before and after applying patches, with HidePatronName enabled and disabled. Notice that patron name is displayed in accordance to HidePatronName before the patches, but always shows after the patches, completely ignoring the sys pref.
Solved! (with some TODO with much broader scope)
3) Before, one of the following labels would show on the barcode column: - Only item: <barcode> - <barcode> or any item from item group - <barcode> or any available
But now, the item group case (2nd) is gone entirely.
Thanks for patching the helper script! It become evident. Solved by adding an embed and doing the same checks it did before
4) The old table had per-column text filter inputs in the header row — those are gone, replaced by sidebar-only filtering. Loss of functionality. Not major but worth flagging.
Done!
5) encodeURIComponent on the mailto href will encode @ to %40, producing broken mailto links. Hover over any email address on the patron column. Notice the produced mailto link is e.g. 'patron1%40example.com'.
Done! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #27 from Alex Carver [Acerock7] <alex@rcls.org> --- Hi Tomás. It looks like this latest version doesn't allow sorting on the Collection, Shelving Location, or Item Type columns. I think the previous version did. Also tested the interaction with the HidePatronName syspref with a new non-superlibrarian account. The update works and shows the cardnumber only in the patron column. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Alex Carver [Acerock7] from comment #27)
Hi Tomás. It looks like this latest version doesn't allow sorting on the Collection, Shelving Location, or Item Type columns. I think the previous version did.
I can confirm current main allows sorting by these columns but the patches here do not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199347|0 |1 is obsolete| | Attachment #199348|0 |1 is obsolete| | Attachment #199349|0 |1 is obsolete| | Attachment #199350|0 |1 is obsolete| | Attachment #199351|0 |1 is obsolete| | Attachment #199385|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #29 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200380&action=edit Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #30 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200381&action=edit Bug 42503: Add item groups to population script Patch from commit df6ada2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #31 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200382&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #32 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200383&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #33 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200384&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference (superlibrarians exempt). Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #34 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200385&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200386&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200386|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #36 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200387&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42842 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42842 [Bug 42842] Remove materialized patron data from tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200380|0 |1 is obsolete| | Attachment #200381|0 |1 is obsolete| | Attachment #200382|0 |1 is obsolete| | Attachment #200383|0 |1 is obsolete| | Attachment #200384|0 |1 is obsolete| | Attachment #200385|0 |1 is obsolete| | Attachment #200387|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #37 from David Nind <david@davidnind.com> --- Created attachment 200439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200439&action=edit Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #38 from David Nind <david@davidnind.com> --- Created attachment 200440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200440&action=edit Bug 42503: Add item groups to population script Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #39 from David Nind <david@davidnind.com> --- Created attachment 200441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200441&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #40 from David Nind <david@davidnind.com> --- Created attachment 200442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200442&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #41 from David Nind <david@davidnind.com> --- Created attachment 200443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200443&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference (superlibrarians exempt). Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 200444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200444&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 200445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200445&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #44 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Apply all the patches 2. Update the database: updatedatabase 3. Rebuild everything: yarn build 4. Restart everything: restart_all 5. Run tests - should pass: prove t/db_dependent/HoldsQueue/materialized_descriptions.t prove t/db_dependent/api/v1/holds_queue.t 6. Populate the holds queue: cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl 7. Build the holds queue (correct command - add missing underscore): perl misc/cronjobs/holds/build_holds_queue.pl 8. Columns in the holds queue: - Current library and Home library are hidden by default (need to toggle using columns) - Other columns shown are: . Publication details . Patron category 9. Sorting: Patron category - can't filter by patron category codes, for example, PT (shown in table as `Patron (PT)`) 10. API endpoint tested using Bruno: - GET 127.0.0.1:8081/api/v1/holds/queue - Headers: . Name: x-koha-embed . Value: biblio,item+strings,patron+strings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|pedro.amorim@openfifth.co.u |lucas@bywatersolutions.com |k | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #45 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- A couple questions, not necessarily blockers: 1. In CreatePicklistFromItemMap, do we need to fetch the itype_description, ccode_description, and location_description each time through the loop? 2. Should these fallback to code, or undef, in the cases of no description? my $ccode_description = Koha::AuthorisedValues->get_description_by_koha_field( { kohafield => 'items.ccode', authorised_value => $item->ccode } )->{lib}; 3. What is $context in this ... context? sub api_query_fixer { my ( $self, $query, $context, $no_quotes ) = @_; return Koha::Biblios->new->api_query_fixer( $query, 'biblio', $no_quotes ); } Blocker: 1. Setting HidePatronName to 'Don't show', the patron name still appears in the holds queue! 2. Schema changes to Result/TmpHoldsqueue.pm should be move to their own patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #46 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Lucas Gass (lukeg) from comment #45)
A couple questions, not necessarily blockers:
1. In CreatePicklistFromItemMap, do we need to fetch the itype_description, ccode_description, and location_description each time through the loop?
`get_description_by_koha_field` already uses Koha::Cache::Memory::Lite, so repeated calls for the same value are cached. No change needed.
2. Should these fallback to code, or undef, in the cases of no description? my $ccode_description = Koha::AuthorisedValues->get_description_by_koha_field( { kohafield => 'items.ccode', authorised_value => $item->ccode } )->{lib};
It already returns undef when no description found (the hashref is {}, so ->{lib} is undef). That's appropriate - the column is nullable.
3. What is $context in this ... context? sub api_query_fixer { my ( $self, $query, $context, $no_quotes ) = @_; return Koha::Biblios->new->api_query_fixer( $query, 'biblio', $no_quotes ); }
The $context parameter is the nesting prefix that tells the query fixer where to find the fields it needs to rewrite. Example: In /api/v1/acquisitions/orders, biblio is embedded one level deep. When a user sorts by "biblio.isbn", DBIC cannot resolve it directly because isbn lives on the biblioitems table, not biblio. The fixer is called with $context = 'biblio': Input: "biblio.isbn" Output: "biblio.biblioitem.isbn" This lets DBIC resolve the correct join path. If $context were empty (as in /api/v1/biblios), it would match bare field names: Input: "isbn" Output: "biblioitem.isbn" In our holds queue endpoint, biblio is embedded directly on the queue item, so we pass $context = 'biblio' when delegating to Koha::Biblios->api_query_fixer. The outer call from the controller uses $context = '' because the holds queue item itself is at the top level. I will try to document this better.
Blocker:
1. Setting HidePatronName to 'Don't show', the patron name still appears in the holds queue!
Right. I added an exception for superlibrarians, I'll just remove it to preserve behavior for now.
2. Schema changes to Result/TmpHoldsqueue.pm should be move to their own patch.
Oops! Bad commits reorganization! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200439|0 |1 is obsolete| | Attachment #200440|0 |1 is obsolete| | Attachment #200441|0 |1 is obsolete| | Attachment #200442|0 |1 is obsolete| | Attachment #200443|0 |1 is obsolete| | Attachment #200444|0 |1 is obsolete| | Attachment #200445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #47 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200552&action=edit Bug 42503: Sample holds queue population script Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #48 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200553&action=edit Bug 42503: Add item groups to population script Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200554&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #50 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200555&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #51 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200556&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #52 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200557&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #53 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200558&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #54 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200559&action=edit [DO NOT PUSH] Bug 42503: Schema changes for tmp_holdsqueue The Schema changes in this patchset (added in 'Add materialized description columns' commit) will be regenerated by the RM. They are included for testers to be able to run the code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #55 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 200564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200564&action=edit Bug 42503: (follow-up) Remove unnecessary api_query_fixer indirection Call Koha::Biblios->api_query_fixer directly from the controller with the correct context ('biblio'), matching the pattern used in Koha::REST::V1::Acquisitions::Orders. The HoldsQueueItems::api_query_fixer method was a pointless wrapper that ignored its $context parameter and hardcoded 'biblio' internally. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43017 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43017 [Bug 43017] [OMNIBUS] Interface optimization -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|42643 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42643 [Bug 42643] [OMNIBUS] Assorted performance and stability work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #56 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi Tomás, I am currently looking at this one, check this: [DO NOT PUSH] Bug 42503: Schema changes for tmp_holdsqueue (496 bytes, patch) <= it's almost empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #57 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Ah, it somehow ended up here: Bug 42503: Add materialized description columns to tmp_holdsqueue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #58 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks Tomás! A few things before passing QA: 1. The [DO NOT PUSH] schema patch (attachment 200559) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them). 2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch? 3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t. 4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/? 5. Minor: does patron duplicate the existing borrower relationship because of the embed name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #59 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Sorry, just noticed Lucas was already doing qa (didn't read the thread first, my bad). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #60 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Came here because of Bug 42842. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #61 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Almost forgot, this currently doesn't apply because of Bug 42278. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |43130 --- Comment #62 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Hi! (In reply to Paul Derscheid from comment #58)
Thanks Tomás! A few things before passing QA:
1. The [DO NOT PUSH] schema patch (attachment 200559 [details] [review]) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them). 2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch? 3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t. 4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/? 5. Minor: does patron duplicate the existing borrower relationship because of the embed name?
I'm having some sort of deja-vu as I already fixed those in a local branch. I'll resubmit shortly. Also: the `t/lib/sample_holds.pl` commit was also `[DO NOT PUSH]`. Not sure how it got lost. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43130 [Bug 43130] Vue-ify the Holds queue report (circ/view_holdsqueue.pl) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #200552|0 |1 is obsolete| | Attachment #200553|0 |1 is obsolete| | Attachment #200554|0 |1 is obsolete| | Attachment #200555|0 |1 is obsolete| | Attachment #200556|0 |1 is obsolete| | Attachment #200557|0 |1 is obsolete| | Attachment #200558|0 |1 is obsolete| | Attachment #200559|0 |1 is obsolete| | Attachment #200564|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #63 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202712&action=edit Bug 42503: Sample holds queue population script [DO NOT PUSH] Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #64 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202713&action=edit Bug 42503: Add item groups to population script [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #65 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202714&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #66 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202715&action=edit Bug 42503: DBIC schema Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #67 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202716&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #68 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202717&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #69 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202718&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #70 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202719&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #71 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202720&action=edit Bug 42503: (follow-up) Drop is_superlibrarian from HidePatronName check When HidePatronName is enabled, the patron embed should be redacted for all users regardless of superlibrarian status. The API contract is consistent: the syspref controls visibility universally. Adds test coverage for HidePatronName behavior including verification that superlibrarians are also subject to the redaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #72 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Paul Derscheid from comment #58)
Thanks Tomás! A few things before passing QA:
1. The [DO NOT PUSH] schema patch (attachment 200559 [details] [review]) is empty. The schema changes ended up in "Add materialized description columns". Also, the patron/pickup_library belongs_to aliases are below the md5 line, so they need to move to a regular patch ("Add holds queue REST API endpoint" already claims them).
Yeah, I reorganized it now. @RM, the fact we need tweaking the schema made me remove the 'DO NOT PUSH' status for that patch.
2. The rename follow-up also drops !is_superlibrarian from the HidePatronName check. The change looks right, but it should be squashed into the endpoint patch?
That was clearly a bad rebase. As it's been a discussed matter in community, I kept it now as a self-contained patch.
3. No test coverage for HidePatronName in t/db_dependent/api/v1/holds_queue.t.
Done, in the follow-up commit.
4. t/lib/sample_holds_queue.pl would be the first executable script in t/lib. Intentional, or should it live in misc/devel/?
This is a 'DO NOT PUSH' commit, shouldn't be a problem
5. Minor: does patron duplicate the existing borrower relationship because of the embed name?
That's correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #73 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 202787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202787&action=edit Bug 42503: (follow-up) Fix broken links in circ-nav.inc The page view_holdsqueue got renamed to holds_queue. This patch changes last remaining occurences of view_holdsqueue.pl to holds_queue.pl in 'circ-nav.inc'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202712|0 |1 is obsolete| | Attachment #202713|0 |1 is obsolete| | Attachment #202714|0 |1 is obsolete| | Attachment #202715|0 |1 is obsolete| | Attachment #202716|0 |1 is obsolete| | Attachment #202717|0 |1 is obsolete| | Attachment #202718|0 |1 is obsolete| | Attachment #202719|0 |1 is obsolete| | Attachment #202720|0 |1 is obsolete| | Attachment #202787|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #74 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202861&action=edit Bug 42503: Sample holds queue population script [DO NOT PUSH] Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #75 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202862&action=edit Bug 42503: Add item groups to population script [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #76 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202863&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #77 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202864&action=edit Bug 42503: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #78 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202865&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #79 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202866&action=edit Bug 42503: DBIC schema changes Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #80 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202867&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #81 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202868&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #82 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202869&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #83 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202870&action=edit Bug 42503: (follow-up) Drop is_superlibrarian from HidePatronName check When HidePatronName is enabled, the patron embed should be redacted for all users regardless of superlibrarian status. The API contract is consistent: the syspref controls visibility universally. Adds test coverage for HidePatronName behavior including verification that superlibrarians are also subject to the redaction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #84 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 202871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202871&action=edit Bug 42503: (follow-up) Fix broken links in circ-nav.inc The page view_holdsqueue got renamed to holds_queue. This patch changes last remaining occurences of view_holdsqueue.pl to holds_queue.pl in 'circ-nav.inc'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|lucas@bywatersolutions.com |me@paulderscheid.xyz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202861|0 |1 is obsolete| | Attachment #202862|0 |1 is obsolete| | Attachment #202863|0 |1 is obsolete| | Attachment #202864|0 |1 is obsolete| | Attachment #202865|0 |1 is obsolete| | Attachment #202866|0 |1 is obsolete| | Attachment #202867|0 |1 is obsolete| | Attachment #202868|0 |1 is obsolete| | Attachment #202869|0 |1 is obsolete| | Attachment #202870|0 |1 is obsolete| | Attachment #202871|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #85 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204866&action=edit Bug 42503: Sample holds queue population script [DO NOT PUSH] Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #86 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204867&action=edit Bug 42503: Add item groups to population script [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #87 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204868&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #88 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204869&action=edit Bug 42503: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #89 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204870&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #90 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204871&action=edit Bug 42503: DBIC schema changes Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #91 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204872&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #92 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204873&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #93 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204874&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #94 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204875&action=edit Bug 42503: (follow-up) Drop is_superlibrarian from HidePatronName check When HidePatronName is enabled, the patron embed should be redacted for all users regardless of superlibrarian status. The API contract is consistent: the syspref controls visibility universally. Adds test coverage for HidePatronName behavior including verification that superlibrarians are also subject to the redaction. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #95 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204876&action=edit Bug 42503: (follow-up) Fix broken links in circ-nav.inc The page view_holdsqueue got renamed to holds_queue. This patch changes last remaining occurences of view_holdsqueue.pl to holds_queue.pl in 'circ-nav.inc'. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #96 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 204877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204877&action=edit Bug 42503: (QA follow-up) Update sample script [DO NOT PUSH] The sample script is only created by the [DO NOT PUSH] patches, so the pushable patches can't contribute hunks to it. Moved them into this commit. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zoho.roboto@bywatersolution | |s.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #97 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- *** Bug 28974 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_26_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |26.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204866|0 |1 is obsolete| | Attachment #204867|0 |1 is obsolete| | Attachment #204868|0 |1 is obsolete| | Attachment #204869|0 |1 is obsolete| | Attachment #204870|0 |1 is obsolete| | Attachment #204871|0 |1 is obsolete| | Attachment #204872|0 |1 is obsolete| | Attachment #204873|0 |1 is obsolete| | Attachment #204874|0 |1 is obsolete| | Attachment #204875|0 |1 is obsolete| | Attachment #204876|0 |1 is obsolete| | Attachment #204877|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #98 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207538&action=edit Bug 42503: Sample holds queue population script [DO NOT PUSH] Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #99 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207539&action=edit Bug 42503: Add item groups to population script [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #100 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207540&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #101 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207541&action=edit Bug 42503: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #102 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207542&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #103 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207543&action=edit Bug 42503: DBIC schema changes Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #104 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207544&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #105 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207545&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #106 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207546&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #107 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207547&action=edit Bug 42503: (follow-up) Drop is_superlibrarian from HidePatronName check When HidePatronName is enabled, the patron embed should be redacted for all users regardless of superlibrarian status. The API contract is consistent: the syspref controls visibility universally. Adds test coverage for HidePatronName behavior including verification that superlibrarians are also subject to the redaction. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #108 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207548&action=edit Bug 42503: (follow-up) Fix broken links in circ-nav.inc The page view_holdsqueue got renamed to holds_queue. This patch changes last remaining occurences of view_holdsqueue.pl to holds_queue.pl in 'circ-nav.inc'. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #109 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 207549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207549&action=edit Bug 42503: (QA follow-up) Update sample script [DO NOT PUSH] The sample script is only created by the [DO NOT PUSH] patches, so the pushable patches can't contribute hunks to it. Moved them into this commit. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #110 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, 3 blockers here that should be easy to fix: Setup: 1) Apply the patches, then: updatedatabase && yarn build && restart_all 2) Populate the queue: perl t/lib/sample_holds_queue.pl 3) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1 Blocker 1: patron name ignores preferred name 1) Pick a patron in the queue and edit them: set 'Preferred name' to something different from 'First name'. 2) Reload the holds queue. The patron shows as "Surname, Firstname" with no card number. Before the patches it showed "Surname, Preferredname (cardnumber)". Blocker 2: patrons from other libraries show an empty cell 1) Log in as a staff user from another library with only 'catalogue' and 'circulate_remaining_permissions' (no 'view_borrower_infos_from_any_libraries'). 2) Open the holds queue. The patron cell is empty. Before the patches it said "A patron from library <name>". Blocker 3: publication details are trimmed 1) Look at the 'Publication details' column for a record with an ISBN or pages. Only edition, publisher and year are shown. Before, it also showed pages, size and ISBN, and fell back to the copyright date when there was no publication year. Not blockers, but worth a follow-up bug and/or the release notes: Non-blocker 1: item types aren't translated 1) Install French in the KTD shell (takes a few minutes): cd /kohadevbox/koha/misc/translator && perl translate install fr-FR 2) In 'Administration' > 'System preferences', search for 'StaffInterfaceLanguages', tick 'Français (fr-FR)' and save. 3) Go to 'Administration' > 'Item types' and edit 'Books'. Next to 'Description', click 'Translate into other languages', add "Livres" for fr-FR, and save. 4) Switch the staff interface to Français using the language selector at the bottom of the page. 5) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1. The item type column still shows "Books". 6) Open any record with a Books item, e.g. one from the queue. Its holdings table shows "Livres", which is what the holds queue showed before the patches. Non-blocker 2: old URL is gone 1) Open http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl. It returns 404. People bookmark this page, so worth a mention in the release notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #207538|0 |1 is obsolete| | Attachment #207539|0 |1 is obsolete| | Attachment #207540|0 |1 is obsolete| | Attachment #207541|0 |1 is obsolete| | Attachment #207542|0 |1 is obsolete| | Attachment #207543|0 |1 is obsolete| | Attachment #207544|0 |1 is obsolete| | Attachment #207545|0 |1 is obsolete| | Attachment #207546|0 |1 is obsolete| | Attachment #207547|0 |1 is obsolete| | Attachment #207548|0 |1 is obsolete| | Attachment #207549|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #111 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208116&action=edit Bug 42503: Sample holds queue population script [DO NOT PUSH] Usage: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #112 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208117&action=edit Bug 42503: Add item groups to population script [DO NOT PUSH] Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #113 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208118&action=edit Bug 42503: Add materialized description columns to tmp_holdsqueue Add itype_description, ccode_description, and location_description columns to the tmp_holdsqueue table. These store the human-readable descriptions at queue-build time, enabling server-side sorting by description rather than code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #114 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208119&action=edit Bug 42503: DBIC schema [DO NOT PUSH] Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #115 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208120&action=edit Bug 42503: Populate materialized descriptions during queue build The tmp_holdsqueue table already materializes patron (surname, firstname, phone, cardnumber) and biblio (title) fields to avoid joins at read time. This extends the pattern to item type, collection code, and shelving location descriptions. C4::HoldsQueue::AddToHoldsQueue now resolves and stores: - itype_description: from effective item type (Koha::ItemType->description) - ccode_description: from authorised values (CCODE category) - location_description: from authorised values (LOC category) This enables server-side sorting by human-readable descriptions rather than internal codes. Test plan: $ ktd --shell k$ prove t/db_dependent/HoldsQueue/materialized_descriptions.t => SUCCESS: All tests pass Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #116 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208121&action=edit Bug 42503: DBIC schema changes Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #117 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208122&action=edit Bug 42503: Add holds queue REST API endpoint Adds GET /api/v1/holds/queue backed by Koha::Hold::HoldsQueueItems (the tmp_holdsqueue table populated by the holds queue cron job). Changes: - Koha/REST/V1/Holds/Queue.pm: controller with list method - Koha/Hold/HoldsQueueItem.pm: Koha::Object class with relationship accessors (patron, biblio, item), strings_map, and to_api_mapping - Koha/Hold/HoldsQueueItems.pm: Koha::Objects class with api_query_fixer for biblioitem field resolution - Koha/Schema/Result/TmpHoldsqueue.pm: adds 'patron' relationship alias so patron.* fields are embeddable and sortable - api/v1/swagger/paths/holds_queue.yaml: path spec - api/v1/swagger/definitions/holds_queue_item.yaml: definition Supports filtering by holding_library_id, pickup_library_id, biblio_id, item_id, patron_id, item_level. Embeds: +strings, biblio, item, item+strings, patron, patron+strings, patron.notice_email_address. Sorting on embedded fields (patron.surname, patron.category_id, biblio.publisher) works correctly. Respects HidePatronName system preference. Test plan: 1. Apply all patches for this bug 2. Run: $ ktd --shell k$ yarn build ; koha-plack --restart kohadev k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: Tests pass! 3. Populate the holds queue: k$ perl misc/cronjobs/holds/build_holdsqueue.pl 4. Verify the endpoint: GET /api/v1/holds/queue x-koha-embed: biblio,item+strings,patron+strings => SUCCESS: Returns holds queue items with embedded data 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #118 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208123&action=edit Bug 42503: Convert holds queue page to API-driven The holds queue page (circ/view_holdsqueue.pl) loaded all queue items at once server-side via GetHoldsQueueItems(), which is slow for large systems. This patch converts it to use the new /api/v1/holds/queue endpoint with DataTables for paginated, server-side rendering. Changes: - circ/view_holdsqueue.pl: stripped to auth + template params only. Data loading removed entirely. - view_holdsqueue.tt: replaced server-rendered FOREACH loop with a kohaTable instance calling /api/v1/holds/queue with dynamic filters via additional_filters (ILL table pattern). The sidebar form redraws the table without page reload on subsequent filter changes. - Embeds used: biblio, item+strings, patron, patron.notice_email_address - Removed publication details column (available via biblio embed if needed in the future) and patron category column (simplification, can be re-added as patron+strings embed) Test plan: 1. Apply patches (including the [DO NOT PUSH] sample data commit) 2. Populate the holds queue: $ ktd --shell k$ cd /kohadevbox/koha && perl t/lib/sample_holds_queue.pl => SUCCESS: 40 items populated 3. Navigate to Circulation > Holds queue 4. Submit the filter form (select a library or leave as All) => SUCCESS: Table loads data via API with pagination 5. Verify columns: title, author, current library, home library, collection, location, item type, call number, copy number, enumeration, barcode, patron (name+phone+email), send to, date, notes 6. Change library filter in sidebar, click Submit => SUCCESS: Table redraws without page reload 7. Click Clear button => SUCCESS: All filters reset, full results shown 8. Verify sorting works on columns 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #119 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208124&action=edit Bug 42503: (follow-up) Rename view_holdsqueue to holds_queue Renames circ/view_holdsqueue.{pl,tt} to circ/holds_queue.{pl,tt} for consistency with other circ pages. Updates all references: circulation-home, Koha::Manual, columns_settings.yml, and the template's internal links. Includes a DB migration to rename saved column preferences from view_holdsqueue to holds_queue. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #120 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208125&action=edit Bug 42503: (follow-up) Drop is_superlibrarian from HidePatronName check When HidePatronName is enabled, the patron embed should be redacted for all users regardless of superlibrarian status. The API contract is consistent: the syspref controls visibility universally. Adds test coverage for HidePatronName behavior including verification that superlibrarians are also subject to the redaction. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #121 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208126&action=edit Bug 42503: (follow-up) Fix broken links in circ-nav.inc The page view_holdsqueue got renamed to holds_queue. This patch changes last remaining occurences of view_holdsqueue.pl to holds_queue.pl in 'circ-nav.inc'. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #122 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208127&action=edit Bug 42503: (QA follow-up) Update sample script [DO NOT PUSH] The sample script is only created by the [DO NOT PUSH] patches, so the pushable patches can't contribute hunks to it. Moved them into this commit. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #123 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208128&action=edit Bug 42503: (follow-up) Restore publication details fields in holds queue The API-driven holds queue 'Publication details' column regressed when the page was converted to use DataTables. The original view_holdsqueue.tt rendered edition statement, publisher, publication year (falling back to the copyright date), pages, material size and ISBN. The new render function only emitted edition statement, publisher and publication year. This patch restores the missing fields in the column render function. All the required data is already available on the embedded biblio object, so no API or embed change is needed. Changes: - koha-tmpl/.../circ/holds_queue.tt: rebuild the publication details string to include: - copyright_date fallback when publication_year is empty - pages (prefixed with ': ') - material_size - isbn (as 'ISBN: ...') - No functional change to the API or the embed set Test plan: 1. Apply all patches for this bug 2. Make sure a biblio in the queue has pages, size, ISBN and a copyright date but no publication year 3. Populate the holds queue: $ ktd --shell k$ perl t/lib/sample_holds_queue.pl 4. Navigate to Circulation > Holds queue and look at the 'Publication details' column => FAIL: Only edition, publisher and year are shown. Pages, size, ISBN and the copyright date fallback are missing 5. Apply this patch 6. Rebuild assets and reload the page: k$ yarn build 7. Repeat step 4 => SUCCESS: Pages, size, ISBN and the copyright date fallback are shown again, matching the previous behaviour 8. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #124 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208129&action=edit Bug 42503: (follow-up) Use $patron_to_html for the holds queue patron column The holds queue patron column formatted the name by hand, which caused two regressions compared to the original view_holdsqueue.tt (which used patron-title.inc): - the preferred name and card number were ignored: the column showed 'Surname, Firstname' instead of 'Surname, Preferredname (cardnumber)' - patrons the logged-in staff member may not see (no 'view_borrower_infos_from_any_libraries' for the patron's library) showed an empty cell instead of 'A patron from <library>' Both are display-only problems. The API already does the right thing: identifying fields are redacted by Koha::Patron->is_accessible during to_api serialisation, while library_id/library are preserved. Rather than reimplement the formatting rules, this patch reuses the shared window.$patron_to_html helper (koha-tmpl/.../js/patron-format.js, already loaded globally via js_includes.inc and used by holds.js, ill-list-table.js, etc.). It handles the preferred name, middle/other names, the card number, the 'A patron from <library>' fallback for redacted patrons, and the circulation link, all consistently with the rest of the staff interface. Changes: - koha-tmpl/.../circ/holds_queue.tt: - render the patron column with $patron_to_html(row.patron, { invert_name, display_cardnumber, url: 'circulation_reserves' }) - keep the 'patron.library' embed (used by the helper's fallback) - t/db_dependent/api/v1/holds_queue.t: add a 'patron visibility across libraries' subtest verifying identifying fields are redacted for a restricted cross-library staff user while library_id is preserved, and that a superlibrarian still sees the full patron Test plan: 1. Apply all patches for this bug 2. Run the API tests: $ ktd --shell k$ prove t/db_dependent/api/v1/holds_queue.t => SUCCESS: all tests pass, including the new cross-library subtest 3. Edit a patron in the queue: set 'Preferred name' different from 'First name' 4. Reload Circulation > Holds queue => FAIL (before this patch): patron shows 'Surname, Firstname', no card number 5. Create a staff user at library A with only 'catalogue' and 'circulate_remaining_permissions' (no 'view_borrower_infos_from_any_libraries'); make sure the queue has a hold for a patron from library B 6. Log in as that staff user and open the holds queue => FAIL (before this patch): the patron cell is empty 7. Apply this patch and rebuild assets: k$ yarn build 8. Repeat steps 4 and 6 => SUCCESS: the patron shows 'Surname, Preferredname (cardnumber)', and the cross-library patron shows 'A patron from <library>' 9. Sign off :-D Assisted-by: Sonnet 4.6 (Anthropic) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #125 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208130&action=edit Bug 42503: Show translated item type in the holds queue The holds queue "Item type" column displayed a single materialized, default-language description. This makes it show the translated item type description according to the staff interface language. To do this the item type *code* is now materialized on tmp_holdsqueue (new `itype` column, FK to itemtypes), and the translated description is resolved through the standard `+strings` API embed convention: - tmp_holdsqueue gains an `itype` column (varchar(10)) with a foreign key to itemtypes(itemtype) (ON DELETE SET NULL / ON UPDATE CASCADE), added via kohastructure.sql and an idempotent atomic update. - Koha::Hold::HoldsQueueItem gains a strings_map() implementing the `+strings` convention for `itype` (translated_description), and maps itype => item_type_id in to_api_mapping. - The holds_queue_item API definition exposes item_type_id and _strings. - C4::HoldsQueue populates `itype` when building the queue and filters on the joined item.itype/item.ccode/item.location columns. - The holds queue template renders the column from _strings.item_type_id.str, falling back to the materialized itype_description. Sorting/filtering is on the item type code; sorting by translated description is left as a follow-up. Test plan: 1. Apply the atomic update (updatedatabase.pl). 2. Translate an item type description (Administration > Item types > "Translate into other languages") into a non-default language. 3. Rebuild the holds queue (build_holds_queue.pl) with items of that type. 4. View the holds queue in the staff interface in that language. => The Item type column shows the translated description. 5. prove t/db_dependent/HoldsQueue.t t/db_dependent/api/v1/holds_queue.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #126 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 208131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208131&action=edit Bug 42503: (follow-up) Make local_holdgroup_match exclusivity test deterministic The "local_holdgroup_match uses exclusivity controls, not LocalHoldsPriority controls" subtest built its patron with TestBuilder's default (random) category. When that category happened to have exclude_from_local_holds_priority = 1, the LocalHoldsPriority phase in C4::HoldsQueue::MapItemsToHoldRequests was skipped for the patron: next if $patron->category->exclude_from_local_holds_priority; With LHP skipped, item targeting fell through to the generic allocation path, which iterates branches/items in Perl hash order and is therefore not deterministic. In that case the queue could target item_b instead of the expected item_c, failing the assertion roughly 25-30% of the time. Build the patron with a category that explicitly has exclude_from_local_holds_priority = 0 so the LocalHoldsPriority path the subtest is meant to exercise always runs. Note: this only fixes the test. The underlying generic-allocation ordering in MapItemsToHoldRequests is itself non-deterministic (it iterates keys %items_by_branch and does not honor StaticHoldsQueueWeight, as the existing FIXME in that sub notes). That is a pre-existing issue with a wider blast radius and should be addressed separately. Test plan: 1. Run the test in a loop, e.g.: for i in $(seq 1 50); do prove t/db_dependent/HoldsQueue.t || break; done 2. Without this patch it fails intermittently (~25-30% of runs) on "LHP correctly targeted the lib_c item". 3. With this patch it passes consistently (50/50). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #127 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Pedro Amorim (ammopt) from comment #110)
Hi all, 3 blockers here that should be easy to fix:
Setup: 1) Apply the patches, then: updatedatabase && yarn build && restart_all 2) Populate the queue: perl t/lib/sample_holds_queue.pl 3) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1
Blocker 1: patron name ignores preferred name 1) Pick a patron in the queue and edit them: set 'Preferred name' to something different from 'First name'. 2) Reload the holds queue. The patron shows as "Surname, Firstname" with no card number. Before the patches it showed "Surname, Preferredname (cardnumber)".
Good catch! I fixed it and ran two instances in parallel to compare. Solved now!
Blocker 2: patrons from other libraries show an empty cell 1) Log in as a staff user from another library with only 'catalogue' and 'circulate_remaining_permissions' (no 'view_borrower_infos_from_any_libraries'). 2) Open the holds queue. The patron cell is empty. Before the patches it said "A patron from library <name>".
Correct. Same as the above, solved!
Blocker 3: publication details are trimmed 1) Look at the 'Publication details' column for a record with an ISBN or pages. Only edition, publisher and year are shown. Before, it also showed pages, size and ISBN, and fell back to the copyright date when there was no publication year.
Yeah, solved!
Not blockers, but worth a follow-up bug and/or the release notes:
Non-blocker 1: item types aren't translated 1) Install French in the KTD shell (takes a few minutes): cd /kohadevbox/koha/misc/translator && perl translate install fr-FR 2) In 'Administration' > 'System preferences', search for 'StaffInterfaceLanguages', tick 'Français (fr-FR)' and save. 3) Go to 'Administration' > 'Item types' and edit 'Books'. Next to 'Description', click 'Translate into other languages', add "Livres" for fr-FR, and save. 4) Switch the staff interface to Français using the language selector at the bottom of the page. 5) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1. The item type column still shows "Books". 6) Open any record with a Books item, e.g. one from the queue. Its holdings table shows "Livres", which is what the holds queue showed before the patches.
I will file a follow-up bug. It seems that when the translatability feature was pushed no one thought about the API/+strings use case and sorting. We will want a generic implementation I'd say. The hard part being the fallback when some cases don't have a translation and other do.
Non-blocker 2: old URL is gone 1) Open http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl. It returns 404. People bookmark this page, so worth a mention in the release notes.
Do you think it is worth restoring the original name? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #128 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 208300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208300&action=edit Bug 42503: (RM follow-up) Fix patron column when HidePatronName is enabled With HidePatronName enabled the API returns the patron with only patron_id, cardnumber and category, so $patron_to_html finds no name and renders "A patron from another library" for everyone. This patch: - renders the cardnumber, linked to the patron's holds, when the patron is accessible (patron_id present) but has no name - keeps library_id and the library embed in the HidePatronName redaction, so restricted staff get "A patron from <library>" as before the conversion - updates the HidePatronName API tests to expect library_id and the library embed Test plan: Setup: 1) Apply all patches for this bug except this one, then: updatedatabase && yarn build && restart_all 2) Populate the queue: perl t/lib/sample_holds_queue.pl A) The regression (as koha, superlibrarian): 1) In 'Administration' > 'System preferences', set 'HidePatronName' to 'Don't show' and save. 2) Open http://localhost:8081/cgi-bin/koha/circ/holds_queue.pl?run_report=1 3) Notice every 'Patron' cell says "A patron from another library", with no link. 4) Apply this patch, run restart_all and reload the page. 5) The 'Patron' column now shows the patron's cardnumber as a link, phone and email still hidden. 6) Click a cardnumber, it should land on http://localhost:8081/cgi-bin/koha/circ/circulation.pl?borrowernumber=X#rese... B) No regressions (with this patch applied): 1) Set 'HidePatronName' to 'Show'. Reload the queue, patrons show as "Surname, Preferredname (cardnumber)" plus phone/email. 2) Create a staff user at Centerville with only 'catalogue' and 'circulate_remaining_permissions' (no superlibrarian, no 'view_borrower_infos_from_any_libraries'), set a username/password. 3) Make sure the queue has a hold for a Centerville patron and one for a patron from another library (edit a patron's home library if needed). 4) Log in as that user and open the queue. 5) Centerville patron: "Surname, Preferredname (cardnumber)". Other library patron: "A patron from <library name>". 6) As koha, set 'HidePatronName' to 'Don't show', log back in as the restricted user and reload. 7) Centerville patron: cardnumber link only. Other library patron: "A patron from <library name>" (before this patch: "A patron from another library"). prove t/db_dependent/api/v1/holds_queue.t Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #129 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 208301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208301&action=edit Bug 42503: (RM follow-up) Make tmp_holdsqueue upgrade match kohastructure The atomic update added the new tmp_holdsqueue columns without the COMMENTs from kohastructure.sql, and added itype_description after local_holdgroup_match, which pushed item_type_id to the end of the table. Upgraded and fresh installs ended up with different tables. This patch adds the COMMENTs and adds itype_description after item_type_id, so both match. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #130 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #127)
I will file a follow-up bug. It seems that when the translatability feature was pushed no one thought about the API/+strings use case and sorting. We will want a generic implementation I'd say. The hard part being the fallback when some cases don't have a translation and other do.
Agreed.
Non-blocker 2: old URL is gone 1) Open http://localhost:8081/cgi-bin/koha/circ/view_holdsqueue.pl. It returns 404. People bookmark this page, so worth a mention in the release notes.
Release notes alone should be enough I'd say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 --- Comment #131 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #132 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice one but won't be backported to 26.05.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42503 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org