http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 40677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40677 Bug 13517 [QA Followup] - Add unit tests Review of attachment 40677: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13517&attachment=40677) ----------------------------------------------------------------- Please amend the last patch. ::: t/db_dependent/Hold.t @@ +48,5 @@
is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set");
is( $hold->is_waiting, 1, 'The hold is waiting' ); +is( $hold->is_found, 1, 'The hold is found'); +isnt( $hold->is_in_transit, 'The hold is not in transit' );
This is wrong. @@ +66,5 @@
$dt = $hold->waiting_expires_on(); is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )"); isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' ); +is( $hold->is_found, 0, 'The hold is not found' ); +isnt( $hold->is_in_transit, 'The hold is not in transit' );
Same here. -- You are receiving this mail because: You are watching all bug changes.