[Bug 13517] New: Show waiting date on reserve/request.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Bug ID: 13517 Summary: Show waiting date on reserve/request.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34958 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34958&action=edit Bug 13517 - Tidy request.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34959&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since <waitingdate>" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34959|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 35454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35454&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since <waitingdate>" Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Kyle M Hall from comment #1)
Created attachment 34958 [details] [review] Bug 13517 - Tidy request.pl
This is not needed, it will introduce conflict with other patches in the queue. Why did you tidy this file? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34958|0 |1 is obsolete| | Attachment #35454|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35834&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since <waitingdate>" Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 35834 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35834 Bug 13517 - Show waiting date on reserve/request.pl Review of attachment 35834: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13517&attachment=35834) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +303,4 @@
# Find the desired items in the reserves my @params; my $query = " + SELECT * FROM reserves WHERE biblionumber = ? ";
Please keep the field list. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35834|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35861&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl Test Plan: 1) Apply this patch 2) Find a waiting hold 3) Browse to reserve/request.pl for that record 4) Notice the "Item waiting" message now has "since <waitingdate>" Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35862&action=edit Bug 13517: Reintroduce the field list It is preferable to list the fields we retrieve from the DB. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 35863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35863&action=edit Bug 13517: Add a regression test Be sure GetReservesFromBiblionumber will return the waitingdate value. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35861|0 |1 is obsolete| | Attachment #35862|0 |1 is obsolete| | Attachment #35863|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36983&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13853 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36983|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36986 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36986&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13918 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14310 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36986|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40025&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40025|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40032&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40032|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40036&action=edit [SIGNED-OFF] Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Blocked by bug 13853. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40036|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40676 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40676&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40677&action=edit Bug 13517 [QA Followup] - Add unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Comment on attachment 40677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40677 Bug 13517 [QA Followup] - Add unit tests Review of attachment 40677: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13517&attachment=40677) ----------------------------------------------------------------- Please amend the last patch. ::: t/db_dependent/Hold.t @@ +48,5 @@
is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set");
is( $hold->is_waiting, 1, 'The hold is waiting' ); +is( $hold->is_found, 1, 'The hold is found'); +isnt( $hold->is_in_transit, 'The hold is not in transit' );
This is wrong. @@ +66,5 @@
$dt = $hold->waiting_expires_on(); is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )"); isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' ); +is( $hold->is_found, 0, 'The hold is not found' ); +isnt( $hold->is_in_transit, 'The hold is not in transit' );
Same here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40892 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40892&action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40892|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 40893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40893&action=edit Bug 13517 [QA Followup] - Fix unit tests -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- So... I was passing qa on this one (I promise!) and, during my last test, I have found a waiting reserve in my DB without itemnumber (??) Which makes the script explodes: Can't call method "holdingbranch" on an undefined value at /home/koha/src/reserve/request.pl line 488. It's an old data and a DB I used to test, so maybe this case is impossible to reach reserve_id: 2051 borrowernumber: 7781 reservedate: 2011-08-19 biblionumber: 4934 constrainttype: a branchcode: MAURES notificationdate: NULL reminderdate: NULL cancellationdate: NULL reservenotes: priority: 0 found: W timestamp: 2015-04-28 16:41:22 itemnumber: NULL waitingdate: 2015-04-28 expirationdate: NULL lowestPriority: 0 suspend: 0 suspend_until: NULL Sorry I don't remember what I did on April 28th :) I don't really know what to do, we could let the code as it, and see if someone report the issue. Or add an existing test on the item. What do you prefer? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40676|0 |1 is obsolete| | Attachment #40677|0 |1 is obsolete| | Attachment #40893|0 |1 is obsolete| | --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40898&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40899&action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 40900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40900&action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #21) Ok, let's consider it comes from my DB. I think it's better to know if a bug exists somewhere else, instead of adding useless tests in this (already messy) script. But, dear RM, don't push it just before the release :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14557 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 [Bug 14557] Add holds count to holds tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14557 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14557 [Bug 14557] Add holds count to holds tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40898|0 |1 is obsolete| | Attachment #40899|0 |1 is obsolete| | Attachment #40900|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42604 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42604&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42605 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42605&action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42606 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42606&action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- To test bug 13918 I need to apply this patch set before but it does not apply anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42604|0 |1 is obsolete| | Attachment #42605|0 |1 is obsolete| | Attachment #42606|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43066&action=edit Bug 13517 - Show waiting date on reserve/request.pl The holds table should show the waiting date for a hold in s similar manner to the way it does on catalogue/detail.pl In addition, if the ReservesMaxPickUpDelay syspref is set, we should display the date when the waiting hold expires. Test Plan: 1) Apply this patch 2) Set ReservesMaxPickUpDelay to 7 3) Find a waiting hold 4) Browse to reserve/request.pl for that record 5) Notice the "Item waiting" message now has "since <waitingdate>" 6) Notice the expiration field now has the date of <waitingdate> + 7 days Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Cathi Wiggins <CWIGGINS@ci.arcadia.ca.us> Signed-off-by: Megan Wianecki <mwianecki@mplmain.mtpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43067&action=edit Bug 13517 [QA Followup] - Add unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43068&action=edit Bug 13517 [QA Followup] - Fix unit tests Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14310 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14310 [Bug 14310] Add ability to suspend and resume individual holds from the patron holds table -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13517 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jweaver@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #33 from Jesse Weaver <jweaver@bywatersolutions.com> --- Pushed to master. Thanks for your contribution! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org