https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #23)
I clearly don't understand the need for the unit file, but it looks like the process shouldn't be running as root
https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/ scripts/koha-worker#L70
You're mixing up a couple things here. The "daemon" based koha-worker runs as <instance>-koha. It's all good. The issue is only with the systemd unit file from a different bug report. The systemd unit file would run the background worker as root (without the patch from 27844). I've already confirmed it in testing.
The shipped unit files are not linked to koha-create so I assume they are just not used. They are shipped just in case someone wants to use them.
I think you're right.
The current scripts make it easy not to depend on systemd (KTD) and things like koha-docker rely on supervisord.
supervisord would just be an alternative to systemd for process management. You shouldn't be using "daemon" with supervisord if I recall correctly. Can you elaborate on that point? As for koha-testing-docker... I think it would benefit from different process management anyway. (For what it's worth, I use ubi-init for a legacy app on Red Hat 8, which uses systemd in containers, and it works quite well for a multi-service container.)
My feeling is we need a good rfc to discuss the ultimate goal, and each involved detail. Adding a hard dependency on systemd specifics can have some impact, that needs to be pondered.
I support this work, I just would like more clear goals.
I agree. I've been saying for many years that we need goals and a long-term project roadmap instead of just stumbling along all separately. I think Jonathan has done great to make per-release road maps, but it would be good for there to be some discussion and consensus on where the project is going technically-speaking. Personally, I would like the community to pursue containerization, but I don't really see it happening. There's too much technical debt, moving parts, container inexperience, inertia, etc. I find systemd to be much better than "daemon" when working on a full VM. When it comes to containers, we should be using a different approach to process management anyway. If we want to do multiple services in a container, we could use systemd (see bug 27844). Or we could use supervisord. I know that supervisord is considered a "moderately heavy-weight" approach according to https://docs.docker.com/config/containers/multi-service_container/, but koha_koha_1 is a heavy-weight container. Anyway, I think we're off topic at this point anyway. -- You are receiving this mail because: You are watching all bug changes.