https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- I'm wondering if we should put connection information (ie hostname, port, username, password, vhost) in koha-conf.xml or have a dedicated file. I feel like koha-conf.xml is simpler for the developer, but a dedicated file would be easier for a sysadmin/operations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26742 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #4 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #3)

I forgot about this

Yeah it had slipped my mind as well -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |26742 Assignee|tomascohen@gmail.com |dcook@prosentient.com.au Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 [Bug 26742] Add configuration for message broker -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|dcook@prosentient.com.au |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114809&action=edit Bug 25674: Add placeholders for RabbitMQ configuration -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 114811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114811&action=edit Bug 25674: Add documentation -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #7)

Created attachment 114810 [details] [review] Bug 25674: Adapt koha-create

This patch adds the following option switches to koha-create:

--mb-host --mb-port --mb-user --mb-pass --mb-vhost

They are used to override the default values on instance creation.

To test: 1. Play with the several option switches and verify that the resulting koha-conf.xml contains the expected data. => SUCCESS: It works as expected 2. Sign off :-D

My test plan: 1. cp debian/templates/koha-conf-site.xml.in /etc/koha/koha-conf-site.xml.in 2. cp debian/scripts/koha-create /usr/sbin/koha-create 3. koha-create --create-db --mb-host test1 --mb-port 8000 --mb-user test2 --mb-pass test3 --mb-vhost test4 test5 4. vi /etc/koha/sites/test5/koha-conf.xml 5. Note the following block near the bottom of the file: <message_broker> <hostname>test1</hostname> <port>8000</port> <username>test2</username> <password>test3</password> <vhost>test4</vhost> </message_broker> 6. koha-create --create-db test6 7. vi /etc/koha/sites/test6/koha-conf.xml 8. Note the following block near the bottom of the file: <message_broker> <hostname>localhost</hostname> <port>61613</port> <username>guest</username> <password>guest</password> <vhost>koha_test6</vhost> </message_broker> I'm failing QA because it sets the feature defaults to a vhost of "koha_test6" when the vhost should be set to nothing by default. If someone tried to use koha-create --create-db test6 without any other intervention, the RabbitMQ functionality wouldn't work out of the box. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 115005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115005&action=edit Bug 25674: Remove default vhost -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is blocking bug 26742. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114809|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117529&action=edit Bug 25674: Add placeholders for RabbitMQ configuration Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114811|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 117531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117531&action=edit Bug 25674: Add documentation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- All works as expected, thanks.. Signing off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to Martin Renvoize from comment #21)

With bug 26363 adding a systemd unit file.. it raises the question of should this patch also do something for that.. Fridolin quite rightly raised questions about what user the unit worker should be running under.

I don't think so. I think that should be hard-coded to "%i-koha" like the rest of package Koha. Certainly a good catch by Frido though. I've opened bug 27844 for it. I'll do a patch for it quickly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I clearly don't understand the need for the unit file, but it looks like the process shouldn't be running as root https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/... The shipped unit files are not linked to koha-create so I assume they are just not used. They are shipped just in case someone wants to use them. The current scripts make it easy not to depend on systemd (KTD) and things like koha-docker rely on supervisord. My feeling is we need a good rfc to discuss the ultimate goal, and each involved detail. Adding a hard dependency on systemd specifics can have some impact, that needs to be pondered. I support this work, I just would like more clear goals. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Tomás Cohen Arazi from comment #23)

I clearly don't understand the need for the unit file, but it looks like the process shouldn't be running as root

https://git.koha-community.org/Koha-community/Koha/src/branch/master/debian/ scripts/koha-worker#L70

You're mixing up a couple things here. The "daemon" based koha-worker runs as <instance>-koha. It's all good. The issue is only with the systemd unit file from a different bug report. The systemd unit file would run the background worker as root (without the patch from 27844). I've already confirmed it in testing.

The shipped unit files are not linked to koha-create so I assume they are just not used. They are shipped just in case someone wants to use them.

I think you're right.

The current scripts make it easy not to depend on systemd (KTD) and things like koha-docker rely on supervisord.

supervisord would just be an alternative to systemd for process management. You shouldn't be using "daemon" with supervisord if I recall correctly. Can you elaborate on that point? As for koha-testing-docker... I think it would benefit from different process management anyway. (For what it's worth, I use ubi-init for a legacy app on Red Hat 8, which uses systemd in containers, and it works quite well for a multi-service container.)

My feeling is we need a good rfc to discuss the ultimate goal, and each involved detail. Adding a hard dependency on systemd specifics can have some impact, that needs to be pondered.

I support this work, I just would like more clear goals.

I agree. I've been saying for many years that we need goals and a long-term project roadmap instead of just stumbling along all separately. I think Jonathan has done great to make per-release road maps, but it would be good for there to be some discussion and consensus on where the project is going technically-speaking. Personally, I would like the community to pursue containerization, but I don't really see it happening. There's too much technical debt, moving parts, container inexperience, inertia, etc. I find systemd to be much better than "daemon" when working on a full VM. When it comes to containers, we should be using a different approach to process management anyway. If we want to do multiple services in a container, we could use systemd (see bug 27844). Or we could use supervisord. I know that supervisord is considered a "moderately heavy-weight" approach according to https://docs.docker.com/config/containers/multi-service_container/, but koha_koha_1 is a heavy-weight container. Anyway, I think we're off topic at this point anyway. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Yes, lets move the overarching systemd/containerisation/whatever conversation elsewhere. Any chance you could progress this bug with a QA stamp David... seems like we've discussed the only point I wasn't sure about and come to a reasonable conclusion so I reckon it's probably ready to go? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117529|0 |1 is obsolete| | --- Comment #29 from David Cook <dcook@prosentient.com.au> --- Created attachment 117776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117776&action=edit Bug 25674: Add placeholders for RabbitMQ configuration Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117531|0 |1 is obsolete| | --- Comment #31 from David Cook <dcook@prosentient.com.au> --- Created attachment 117778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117778&action=edit Bug 25674: Add documentation Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks David :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #35 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi from comment #24)

And I don't understand how this didn't get into 20.11.

My answer is 'yes'. But let's hear others! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Bug 25674 depends on bug 26742, which changed state. Bug 26742 Summary: Add configuration for message broker https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26742 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25674 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22417 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 [Bug 22417] Add a task queue -- You are receiving this mail because: You are watching all bug changes.