https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I think this should match the format of other information: my $itemtype = C4::Koha::xml_escape($item->effective_itemtype && exists $itemtypes->{$item->effective_itemtype} ? $itemtypes->{$item->effective_itemtype} : $item->effective_itemtype); Other wise we end up with undef when the effective itemtype is not an official itemtype, and I think we should still display the type code in that case. Also, we are xml escaping other values, so should on this one too -- You are receiving this mail because: You are watching all bug changes.