[Bug 36366] New: Itemtype can be used in XSLT
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Bug ID: 36366 Summary: Itemtype can be used in XSLT Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: wainuiwitikapark@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Item types should be able to be called in XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |wainuiwitikapark@catalyst.n | |et.nz Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 --- Comment #1 from wainuiwitikapark@catalyst.net.nz --- Created attachment 163488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163488&action=edit Bug 36366: Itemtype can be used in XSLT Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Wainui, Can we get a test plan? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163488|0 |1 is obsolete| | --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Created attachment 163763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163763&action=edit Bug 36366: Itemtype can be used in XSLT Test plan: - Apply patch - Go to one of the XSLT files e.g. MARC21slim2OPACResults.xsl - Use $itemtype defined in C4/XSLT.pm e.g. copy how $OPACItemLocation is used in MARC21slim2OPACResults.xsl - See if the XSLT changes worked e.g. go to search results and see if itemtype is there Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #163763|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 163784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163784&action=edit Bug 36366: Itemtype can be used in XSLT Test plan: - Apply patch - Go to one of the XSLT files e.g. MARC21slim2OPACResults.xsl - Use $itemtype defined in C4/XSLT.pm e.g. copy how $OPACItemLocation is used in MARC21slim2OPACResults.xsl - See if the XSLT changes worked e.g. go to search results and see if itemtype is there Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36366 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #5 from Nick Clemens <nick@bywatersolutions.com> --- I think this should match the format of other information: my $itemtype = C4::Koha::xml_escape($item->effective_itemtype && exists $itemtypes->{$item->effective_itemtype} ? $itemtypes->{$item->effective_itemtype} : $item->effective_itemtype); Other wise we end up with undef when the effective itemtype is not an official itemtype, and I think we should still display the type code in that case. Also, we are xml escaping other values, so should on this one too -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org