http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * patch does not apply anymore * in the 3rd patch, the Koha/Template/Plugin/Koha.pm is improperly named I think, it should be Systempreference.pm or something more meaningful than "Koha". I also think this new plugin is cool and could be in a separate bug, to be clearly visible in the release notes. Because it means we can improve performances by removing # these template parameters are set the same regardless of $in->{'type'} $template->param( "BiblioDefaultView".C4::Context->preference("BiblioDefaultView") => 1, EnhancedMessagingPreferences => C4::Context->preference('EnhancedMessagingPreferences'), GoogleJackets => C4::Context->preference("GoogleJackets"), OpenLibraryCovers => C4::Context->preference("OpenLibraryCovers"), KohaAdminEmailAddress => "" . C4::Context->preference("KohaAdminEmailAddress"), LoginBranchcode => (C4::Context->userenv?C4::Context->userenv->{"branch"}:"insecure"), LoginFirstname => (C4::Context->userenv?C4::Context->userenv->{"firstname"}:"Bel"), LoginSurname => C4::Context->userenv?C4::Context->userenv->{"surname"}:"Inconnu", emailaddress => C4::Context->userenv?C4::Context->userenv->{"emailaddress"}:undef, ... in C4/Auth.pm, in favour of adding [% use Systempreference %] and [% Systempreference.preference('What you need') %] where you need a given systempref. This change will be a long term goal, and deserve an OMNIBUS patch. At the end of this message, my request for this 2nd point is to create an omnibus to remove all those C4/Auth.pm lines. -- You are receiving this mail because: You are watching all bug changes.