[Bug 7441] New: search results showing wrong branch?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bug #: 7441 Summary: search results showing wrong branch? Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 - low Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: ian.walls@bywatersolutions.com When you search in the OPAC it shows you the HOME branch on the location in XSLT (see here: http://screencast.com/t/m870Mr8Wm), but if you click through to the detail page it shows you the CURRENT BRANCH in the holdings table which is very confusing to patrons. I don't know what's the right solution - home or holding branch, but they should be the same in both places for the patron's sake. If you do the same search in the staff client you see the right branch info on the search results and on the detail page. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #1 from Kyle M Hall <kyle.m.hall@gmail.com> --- I would definitely consider this a bug due to the fact that when not using XSLT the results page shows the holding library, but when using XSLT the results display the home library. I would consider that default ( non-XSLT ) results to be canonical and thus the XSLT results should be default replicate the standard results. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #2 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8656&action=edit Bug 7441 - search results showing wrong branch - Part 1 - Add holdingbranch to xml -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #3 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 8657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8657&action=edit Bug 7441 - search results showing wrong branch - Part 2 - Modify OPAC xsl file to display holding branch instead of home branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #4 from Liz Rea <wizzyrea@gmail.com> --- This is going to have to be a syspref - people are going to want to choose which to display on the OPAC. NEKLS, for example, would not want to see the holding branch. They would want to see the home branch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #5 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to comment #4)
This is going to have to be a syspref - people are going to want to choose which to display on the OPAC.
NEKLS, for example, would not want to see the holding branch. They would want to see the home branch.
The idea behind using XSLT is to add the ability to customize the results and details, rather than displaying Koha's default way of doing so. You would still be able to customize your xslt so that the home branch is displayed. The idea behind this patch is simply to bring the default xslt view in line with the default non-xslt view. It seems rather counter-intuitive for the default non-xslt to display the holding library, but for the default xslt to display the home library instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Kyle, I agree this is definitely a bug, but the problem in my eyes is with the "regular" view not the XSLT view. I think a syspref would be a good choice for this, because the patch as it stands eliminates functionality in the system for the sake of consistency (not that there's anything wrong with consistency, but I'd rather a slightly inconsistent interface that works for more people than a consistent interface that works for fewer). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think we can't make a change like that without making it configurable and leaving and defaulting to the current display. For me home branch is the logical choice for display. Holding branch probably makes sense when you have floating collections, but for most scenarios I can think of displaying the home branch would be what is expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Just to add my voice to chorus of fix the default view with a syspref. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #9 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9700 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9700&action=edit Bug 7441 - Followup - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9700|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 9701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9701&action=edit Bug 7441 - search results showing wrong branch - Part 3 - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #11 from Kyle M Hall <kyle.m.hall@gmail.com> --- My third followup to add a syspref causes XSLT errors. If anyone can help me out I would greatly appreciate it. compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element if element if only allowed within a template, variable or param compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element key element key only allowed as child of stylesheet compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element if element if only allowed within a template, variable or param compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element key element key only allowed as child of stylesheet compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element if xsltParseStylesheetTop: unknown if element compilation error: file /home/koha/kohaclone/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl element if xsltParseStylesheetTop: unknown if element at /home/koha/kohaclone/C4/XSLT.pm line 219 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #12 from Robin Sheat <robin@catalyst.net.nz> --- You should be using xsl:choose / xsl:when for those kinds of conditionals I think. xsl:if tends to be used for doing things like assigning a value based on a choice. I guess they're semantically different (I expect that xsl:if shortcuts, but I haven't finished reading the book on XSLT.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
From reading the error messages I suspect it's this part:
<xsl:key name="item-by-status" match="items:item" use="items:status"/> - <xsl:key name="item-by-status-and-branch" match="items:item" use="concat(items:status, ' ', items:holdingbranch)"/> + <xsl:if test="$OPACResultsBranchXSLT='holdingbranch'"> + <xsl:key name="item-by-status-and-branch" match="items:item" use="concat(items:status, ' ', items:holdingbranch)"/> + </xsl:if> + <xsl:if test="$OPACResultsBranchXSLT='homebranch'"> + <xsl:key name="item-by-status-and-branch" match="items:item" use="concat(items:status, ' ', items:homebranch)"/> + </xsl:if> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #14 from Robin Sheat <robin@catalyst.net.nz> --- Yeah, ignore what I said, it's not right :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #15 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I recommend using "items:$OPACResultsByBranchXSLT" in your key (eliminating the if). Also, don't forget to declare your variables, and note that you will need to declare the variable prior to its use. Also, remember to use <choose> instead of if when choosing between multiple options (in the "Copies available for loan" stanza). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9701|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12550 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12550&action=edit Bug 7441 - search results showing wrong branch - Part 3 - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12550|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12551 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12551&action=edit Bug 7441 - search results showing wrong branch - Part 3 - Control display of branch via system preference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12552 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12552&action=edit Bug 7441 - search results showing wrong branch - Part 1 - Add holdingbranch to xml -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8656|0 |1 is obsolete| | Attachment #8657|0 |1 is obsolete| | Attachment #12551|0 |1 is obsolete| | Attachment #12552|0 |1 is obsolete| | --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12553 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12553&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff CC| |kyle@bywatersolutions.com --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- I think I've got everything taken care of now. This new patch is a squashed version of the previous three patches, along with a fixed version of the xslt file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 delaye <stephane.delaye@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stephane.delaye@biblibre.co | |m --- Comment #21 from delaye <stephane.delaye@biblibre.com> --- I have the value 'default' in the preference systeme OPACXSLTResultsDisplay I have the value 'holdingbranch' in the in the preference systeme OPACResultsBranchXSLT but in the opac results the homebranch is display instead of the holdingbranch Is this the right test?... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #22 from Owen Leonard <oleonard@myacpl.org> --- This no longer applies for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12553|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13856 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13856&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Medium patch |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- merge marker in the updatedatabase.pl file +<<<<<<< HEAD -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13856|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 13888 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13888&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #26 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 14229 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14229&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #27 from Owen Leonard <oleonard@myacpl.org> --- Why add a preference which only affects the XSLT view? Why not have it affect both? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14361 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14361&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14361|0 |1 is obsolete| | --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 14362 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14362&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Test Plan: 1) Apply all the patches 2) Run updatedatabase.pl 4) Run a search that will show items with different home and holding branches 3) Test both settings of OPACResultsBranch with OPACXSLTResultsDisplay disabled and also set to 'default' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #31 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Tried to test, but first patch doesn't apply
Test Plan: 1) Apply all the patches
~/kohaclone$ git bz apply 7441 ... Patch failed at 0001 Bug 7441 - search results showing wrong branch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13888|0 |1 is obsolete| | --- Comment #32 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14977 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14977&action=edit [SIGNED-OFF] Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on current master (2013-01-31). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14229|0 |1 is obsolete| | --- Comment #33 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14978 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14978&action=edit [SIGNED-OFF] Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14362|0 |1 is obsolete| | --- Comment #34 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 14979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14979&action=edit [SIGNED-OFF] Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |paul.poulain@biblibre.com --- Comment #35 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * patch does not apply anymore * in the 3rd patch, the Koha/Template/Plugin/Koha.pm is improperly named I think, it should be Systempreference.pm or something more meaningful than "Koha". I also think this new plugin is cool and could be in a separate bug, to be clearly visible in the release notes. Because it means we can improve performances by removing # these template parameters are set the same regardless of $in->{'type'} $template->param( "BiblioDefaultView".C4::Context->preference("BiblioDefaultView") => 1, EnhancedMessagingPreferences => C4::Context->preference('EnhancedMessagingPreferences'), GoogleJackets => C4::Context->preference("GoogleJackets"), OpenLibraryCovers => C4::Context->preference("OpenLibraryCovers"), KohaAdminEmailAddress => "" . C4::Context->preference("KohaAdminEmailAddress"), LoginBranchcode => (C4::Context->userenv?C4::Context->userenv->{"branch"}:"insecure"), LoginFirstname => (C4::Context->userenv?C4::Context->userenv->{"firstname"}:"Bel"), LoginSurname => C4::Context->userenv?C4::Context->userenv->{"surname"}:"Inconnu", emailaddress => C4::Context->userenv?C4::Context->userenv->{"emailaddress"}:undef, ... in C4/Auth.pm, in favour of adding [% use Systempreference %] and [% Systempreference.preference('What you need') %] where you need a given systempref. This change will be a long term goal, and deserve an OMNIBUS patch. At the end of this message, my request for this 2nd point is to create an omnibus to remove all those C4/Auth.pm lines. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14977|0 |1 is obsolete| | Attachment #14978|0 |1 is obsolete| | Attachment #14979|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17901&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17902&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17903&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #39 from Kyle M Hall <kyle.m.hall@gmail.com> ---
* in the 3rd patch, the Koha/Template/Plugin/Koha.pm is improperly named I think, it should be Systempreference.pm or something more meaningful than "Koha".
I think we need a Koha-level TT plugin the same way we have a Koha.pm. It should be a place to put all the once-off plugin logic that does not have multiple functions. If we have a separate TT plugin for each action like this, we will end up with a dozen or more plugins, each of which will need a USE line at the top of each template. That seems unnecessary, doesn't it? [% Koha.Preference( PrefName ) %] seems more clean and sensible than [% KohaPreferences.Preference( PrefName ) %]. If you disagree with my logic here, just reset the status to Failed QA and I will make the requested modifications. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 17968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17968&action=edit Bug 7441 - search results showing wrong branch? - Followup - Delete Koha TT Plugin Deletes the Koha TT Plugin from this patch series, to move it to it's own bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10206 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #41 from Kyle M Hall <kyle.m.hall@gmail.com> --- This patch now depends on bug 10206 for the Koha TT Plugin. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.14 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, I had to rebase the first patch, because of a conflict in updatedatabase and found 1 problem: Third patch contains those lines: +[% USE Koha %] +[% USE KohaBranchName %] But fourth patch deletes the Koha TT plugin without removing them. I think as a result of that the QA script notes a problem with opac-results.tt: * koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt FAIL forbidden patterns OK tt_valid OK valid_template FAIL Koha: plugin not found Please fix and switch back to signed off if the only changes are the rebase and fixing the plugin problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #43 from Kyle M Hall <kyle.m.hall@gmail.com> --- Katrin, I split off the plugin to a separate bug and added it as a dependency on this bug. I'll still take are of the rebasing though. Kyle (In reply to comment #42)
Hi Kyle,
I had to rebase the first patch, because of a conflict in updatedatabase and found 1 problem:
Third patch contains those lines: +[% USE Koha %] +[% USE KohaBranchName %] But fourth patch deletes the Koha TT plugin without removing them.
I think as a result of that the QA script notes a problem with opac-results.tt:
* koha-tmpl/opac-tmpl/prog/en/modules/opac-results.tt FAIL forbidden patterns OK tt_valid OK valid_template FAIL Koha: plugin not found
Please fix and switch back to signed off if the only changes are the rebase and fixing the plugin problem.
-- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17901|0 |1 is obsolete| | --- Comment #44 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18151&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on current master (2013-01-31). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17902|0 |1 is obsolete| | --- Comment #45 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18152 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18152&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17903|0 |1 is obsolete| | --- Comment #46 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18153&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17968|0 |1 is obsolete| | --- Comment #47 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18154&action=edit Bug 7441 - search results showing wrong branch? - Followup - Delete Koha TT Plugin Deletes the Koha TT Plugin from this patch series, to move it to it's own bug. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18151|0 |1 is obsolete| | Attachment #18152|0 |1 is obsolete| | Attachment #18153|0 |1 is obsolete| | Attachment #18154|0 |1 is obsolete| | --- Comment #48 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18857 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18857&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #49 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18858 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18858&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #50 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18859 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18859&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #51 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 18942 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18942&action=edit Bug 7441 - search results showing wrong branch? - Followup - Fix XSLT for option "homebranch" + syspref description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us --- Comment #52 from Chris Rohde <crohde@roseville.ca.us> --- I'm Chris Rohde from Roseville Public Library, Roseville, California. I have tested this patch, both with and without XSLT, using the test plan in Comment 30. I would like to sign it off in my name. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18857|0 |1 is obsolete| | --- Comment #53 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19089&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on current master (2013-01-31). Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18858|0 |1 is obsolete| | --- Comment #54 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19090 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19090&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18859|0 |1 is obsolete| | --- Comment #55 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19091&action=edit Bug 7441 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia@bywatersolutions.com --- Comment #56 from Melia Meggs <melia@bywatersolutions.com> --- Hey, thanks Chris C for adding Chris R's sign off. I had that on my list to do today, and I am pleased to find that you've already taken care of it. Yay! :) Melia -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #57 from Chris Cormack <chris@bigballofwax.co.nz> --- Patch doesn't apply there is a conflict in koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACResults.xsl That I don't know how to fix -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18942|0 |1 is obsolete| | Attachment #19089|0 |1 is obsolete| | Attachment #19090|0 |1 is obsolete| | Attachment #19091|0 |1 is obsolete| | --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19470&action=edit Bug 7441 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on current master (2013-01-31). Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19471 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19471&action=edit Bug 7441: Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19470|0 |1 is obsolete| | Attachment #19471|0 |1 is obsolete| | --- Comment #60 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19472 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19472&action=edit Bug 7441 - Part 1 - search results showing wrong branch When you search in the OPAC it shows you the HOME branch on the location in XSLT, but if you click through to the detail page it shows you the HOLDING branch in the holdings table which is very confusing to patrons. Fixed by adding a system preference to choose whether to display the holding branch or the home branch on the XSLT OPAC search results page. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Rebased on current master (2013-01-31). Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19473 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19473&action=edit Bug 7441 - Part 2 - Followup search results showing wrong branch [UNIMARC] Unimarc modifications Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #62 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19474&action=edit Bug 7441 - Part 3 - search results showing wrong branch? - Followup - Use syspref for XSLT and non-XSLT Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Applied all patches. Tested with and without XLST display. Works as described. No errors. Not tested with UNIMARC Signed-off-by: Chris Rohde <crohde@roseville.ca.us> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19475 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19475&action=edit Bug 7441 - Part 4 - search results showing wrong branch? - Followup - Fix XSLT for option "homebranch" + syspref description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- At some point the patches got out of order. I've reuploaded them in the corrected order and added numbering to the patch titles. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #65 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think if we have UNIMARC and MARC21, we should not forget about NORMARC. Kyle, could you add a follow up for NORMARC please? I will continue testing these. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #66 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a problem in the non-XSLT display: Availability: Copies available: Demo Library (1), Demo Library (1), Items look like this: home library:holding library demo library:springfield demo library:demo library It works nicely for the XSLT view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 --- Comment #67 from Nicole C. Engard <nengard@gmail.com> --- Does this patch have to work for Non-XSLT? Can't we say it's an XSLT Only thing? Can we get this moving again? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #68 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nicole, we already have some features that work only with the XSLT view, so I think this probably should not block the feature. But I am not sure if my tests showed a problem in the non-XSLT views that was caused by the patches. I think we need to retest. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7441 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply Version|3.14 |master --- Comment #69 from Nick Clemens <nick@quecheelibrary.org> --- Patch no longer applies, I also see this problem in master so updating both status and version -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org