https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20028 --- Comment #57 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Lari raised various questions on this bug, but did not receive (many) answers. I do like what he wrote and I think it would be a good starting point to refine. Since it is controlled by a pref, I would not see much harm in pushing this first step and refining later.
Should we first implement something that simply returns all the data related to a patron, and if someone wants to focus on formatting it nicely, then solve that issue in another Bug? I would agree with that direction.
Another issue is how far do we want to expand the results? Hmm. This will open up a lot of trouble? Since there are so many relations, we would imo need some mechanism to do so instead of ad-hoc stuff.
The current patches completely ignore any REST API terminology guidelines we use. [...] This will become a terminology hell. Sure. Your approach is understandable. And you are using to_api now.
We also need pagination, but paginating the currently proposed model would be weird. How would one paginate such response? Should we instead return an array of objects with the same structure ... You added basic pagination with "_per_page" and "_page". Hard to say what would be the best pagination approach here ;)
I will ask these questions on koha-devel mailing list. I may have missed that one. I have searched in the archive, but could not find anything.
Passing QA to stir up the discussion ;) -- You are receiving this mail because: You are watching all bug changes.