http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #4)
QA comments:
Hi Maxime,
1/+ `seriallifespan` TINYINT(1) DEFAULT -1 You cannot store '10' into a TINYINT(1)
2/ 3 loops can be created to avoid a list of 10 lines: [% FOREACH i IN [ 2 .. 10 ] %] <option value="[% i %]" [% IF ( seriallifespan == [% i %] ) %]selected="selected"[% END %]>[% i %] years</option> [% END %]
Furthermore you cannot write this line :-/ (see Bug 8407)
And: [% IF seriallifespan == -1 %] <span>Immortal</span> [% ELSIF ( seriallifespan == 1 ) %] <span>1 year</span> [% ELSIF ( seriallifespan >= 10 ) %] [% FOREACH i IN [ 2 .. 10 ] %] <span>[% seriallifespan %] years</span> [% END %] [% END %]
Something like that, I didn't test.
3/ Fonctionnaly what is the goal of this field? Indeed, you don't use this field, just store and display.
Failed QA for 1 and 2
I think its just 2, tt inside a tag that is a problem, tinyint(1) is 0 - 255 unsigned and -128 to 127 signed. select seriallifespan from subscription; +----------------+ | seriallifespan | +----------------+ | 10 | +----------------+ (I tested that when signing off) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.