https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42231 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some release notes| |accessibility issues on the | |patron's OPAC summary | |section: Form elements must | |have labels. | | | |- Checked out "Renew" | |checkbox: adds a hidden | |label for screen readers | |- Add note pop-up window | |for "Report a problem" | |(when the | |AllowCheckoutNotes | | system preference is | |enabled): adds a hidden | |label for screen readers | | | |It also hides the item | |title on the report a | |problem and suspend hold | |pop-up windows. CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Just wanted to confirm that you intended to no longer show the item title on report a problem and suspend hold modals. Testing notes (using KTD): 1. Renew: - axe DevTools: Form elements must have labels - Lighthouse: Form elements do not have associated labels - Before: <input type="checkbox" name="issue" value="1"> - After: <label> <span class="visually-hidden">Select item to renew</span> <input type="checkbox" name="issue" value="1"> </label> 2. Report a problem: - Enable the AllowCheckoutNotes system preference - Now have "Report a problem" column with "Add note" button on Summary > Checked out table - axe DevTools: Form elements must have labels - Before the patch, the item title is displayed above the text box for the note - After the patch, the item title is not shown on the modal Before: <div class="modal-body" id="addNoteBody"> <h2 id="addNoteTitle">CGI programming with Perl / </h2> <input type="hidden" id="addNoteIssueId" name="issue_id" value="2"> <textarea name="note" id="addNote" rows="4"></textarea> <div class="hint">Your note will be shown to the librarian when the item is checked in.</div> </div> After: <div class="modal-body" id="addNoteBody"> <h2 id="addNoteTitle" hidden="">Programming Perl / </h2> <input type="hidden" id="addNoteIssueId" name="issue_id" value="1"> added--> <label for="addNote" class="visually-hidden">Note</label> <textarea name="note" id="addNote" rows="4"></textarea> <div class="hint">Your note will be shown to the librarian when the item is checked in.</div> </div> 3. Suspend holds: - Have a hold for the patron - Go to: Summary > Holds - Click "Suspend" for the hold - Before the patch, the item title is displayed in italics above the "Suspend until: [date picker]" - After the patch, the item title is not shown on the modal - axe DevTools: no problem reported - Before: <h2 id="suspendHoldTitle"><em>Intermediate Perl / </em></h2> - After: <h2 id="suspendHoldTitle" hidden=""><em>Intermediate Perl / </em></h2> -- You are receiving this mail because: You are watching all bug changes.