http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #11)
Based on my initial skimming of the patches, I think this looks great!
The only very minor nitpicky suggestion would be the naming of the clases. You could rename Koha::Virtualshelf to Koha::List and Koha::Virtualshelfshares to Koha::List::Sharess or something along those lines so that we can start down the road to having our internal nomenclature match our external nomenclature.
What do you think of that Jonathan?
It seems that a consensus on the name is not reach :) And I really don't want to rewrite the job already done or wait to find a name... I am sure it will be quite easy to rename everything (tables and classes) when this change will be done. -- You are receiving this mail because: You are watching all bug changes.